From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6F8AC433F5 for ; Tue, 10 May 2022 21:11:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3500A841B8; Tue, 10 May 2022 23:11:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="Kc1rhtxM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3AEF4841B8; Tue, 10 May 2022 23:11:18 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0209080163 for ; Tue, 10 May 2022 23:11:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 5B6D122238; Tue, 10 May 2022 23:11:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1652217074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oCzsfRinvud8RRYKFoYGafDMYtlw3Ow1zG5z/iHH7ys=; b=Kc1rhtxMr6q/cNC0pCKLj/2xEEwDO7IzlMk+1/Wmo79o1qjLeGbk8vCm05r4mGPa5y3Ef9 xiitWdK8qzOo6BnpPR8vetCH3kQGV1yL7cuGB6Q6ConxgsgODqYbJ88b34Mkj2Ytt3WLNb 7fKMND1DJCibguvlarTj00PF2iJ3CXE= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 10 May 2022 23:11:14 +0200 From: Michael Walle To: Vladimir Oltean Cc: "Y.B. Lu" , Priyanka Jain , u-boot@lists.denx.de, Tom Rini Subject: Re: [PATCH] ls1028a: hdp: Add config support for HDP firmware loading In-Reply-To: <20220510174741.x6sky47ckmhxtme7@skbuf> References: <20220510102910.31459-1-yangbo.lu@nxp.com> <20220510141832.3520801-1-michael@walle.cc> <20220510174741.x6sky47ckmhxtme7@skbuf> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <8567d6fb5ce18d67b52426053748d45c@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 2022-05-10 19:47, schrieb Vladimir Oltean: > On Tue, May 10, 2022 at 04:18:32PM +0200, Michael Walle wrote: >> > From: Alison Wang >> > >> > This patch adds config support for HDP firmware loading on LS1028A. >> >> FWIW, I really don't like this as this is just for a downstream >> kernel. > > This => what? I only see a config option. I searched the list and the > source code for CONFIG_VIDEO_LS_HDP_LOAD and I don't see any user... You are right, I didn't actually notice that. The whole loading thing [1] is missing. >> For the upstream kernel the firmware should be loaded by the kernel >> itself. > > In principle I agree. > >> But unfortunately, there is no development there. (I have some half >> baked patches though and can confirm, that firmware loading is working >> from linux). Instead of this I'd like to see some work to support the >> DP PHY in upstream linux as this is really the last missing piece to >> get graphics working. > > It is? What did I miss? I don't know? etnaviv is working [2 and more], mesa will be working soon [3]. mali-dp500 should have been working all the time. So only the output path is missing. If you are interested, this [4] is my take on the support, which is actually working. But I haven't found any time to look at it again. And I'm missing any documentation, so most information was found out by educated guesses and comparing to the downstream driver. I'd greatly appreciate any help ;) [1] https://source.codeaurora.org/external/qoriq/qoriq-components/u-boot/tree/drivers/video/nxp/layerscape?h=integration [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/etnaviv?id=12495f4eb298963565e0bdd37d8096ab1136d89f [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9255 [4] https://github.com/mwalle/linux/tree/feature-cdns-phy -michael