From: Grigori Goronzy <greg@chown.ath.cx>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations
Date: Fri, 29 Apr 2016 17:12:48 +0200 [thread overview]
Message-ID: <856a45c97aff7ce525e1bb3e1dee3f2f@chown.ath.cx> (raw)
In-Reply-To: <20160429125239.GH22229@localhost>
On 2016-04-29 14:52, Johan Hovold wrote:
>> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device
>> *dev, u8 control)
>>
>> static int ch341_get_status(struct usb_device *dev, struct
>> ch341_private *priv)
>> {
>> - char *buffer;
>> + unsigned char *buffer;
>> int r;
>> - const unsigned size = 8;
>> + const unsigned size = 2;
>
> Did you reply to Oliver's comment about this change? Are you sure this
> won't break some old device expecting to be asked for eight bytes even
> if only two are returned?
>
I'll just drop this change.
Grigori
next prev parent reply other threads:[~2016-04-29 15:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 21:14 Major improvements to the ch341 driver v4 Grigori Goronzy
2016-04-15 21:14 ` [PATCH v4 01/13] USB: ch341: fix error handling on resume Grigori Goronzy
2016-04-29 12:16 ` Johan Hovold
2016-04-29 15:11 ` Grigori Goronzy
2016-05-02 13:45 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 02/13] USB: ch341: add LCR register definitions Grigori Goronzy
2016-04-29 12:18 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 03/13] USB: ch341: add definitions for modem control Grigori Goronzy
2016-04-29 12:22 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 04/13] USB: ch341: fix USB buffer allocations Grigori Goronzy
2016-04-29 12:52 ` Johan Hovold
2016-04-29 15:12 ` Grigori Goronzy [this message]
2016-04-15 21:14 ` [PATCH v4 05/13] USB: ch341: reinitialize chip on reconfiguration Grigori Goronzy
2016-04-29 13:03 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 06/13] USB: ch341: add support for parity, frame length, stop bits Grigori Goronzy
2016-04-29 13:11 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 07/13] USB: ch341: add debug output for chip version Grigori Goronzy
2016-04-29 13:13 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 08/13] USB: ch341: add support for RTS/CTS flow control Grigori Goronzy
2016-04-29 13:23 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 09/13] USB: ch341: fix coding style Grigori Goronzy
2016-04-29 13:29 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 10/13] USB: ch341: clean up messages Grigori Goronzy
2016-04-29 13:40 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 11/13] USB: ch341: improve B0 handling Grigori Goronzy
2016-04-29 13:41 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 12/13] USB: ch341: get rid of default configuration Grigori Goronzy
2016-04-29 13:43 ` Johan Hovold
2016-04-15 21:14 ` [PATCH v4 13/13] USB: ch341: implement tx_empty callback Grigori Goronzy
2016-04-29 13:47 ` Johan Hovold
2016-04-28 23:24 ` Major improvements to the ch341 driver v4 Grigori Goronzy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856a45c97aff7ce525e1bb3e1dee3f2f@chown.ath.cx \
--to=greg@chown.ath.cx \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.