From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5857EC433E2 for ; Thu, 2 Jul 2020 12:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413CF20874 for ; Thu, 2 Jul 2020 12:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728949AbgGBMgH (ORCPT ); Thu, 2 Jul 2020 08:36:07 -0400 Received: from mail.loongson.cn ([114.242.206.163]:46530 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727847AbgGBMgH (ORCPT ); Thu, 2 Jul 2020 08:36:07 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxL2uu1P1eaIZOAA--.7585S3; Thu, 02 Jul 2020 20:35:59 +0800 (CST) Subject: Re: [v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Guo Ren , linux-csky@vger.kernel.org References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn> <564ffff9-6043-7191-2458-f425dd8d0c11@web.de> <1a0e007a-db94-501b-4ab9-0bb479ec093b@loongson.cn> <971c649e-fe07-3771-6fea-f5aaeaf090ad@web.de> <41b48aa5-e5b2-0257-8b3d-07e1b86634b4@web.de> <0726ddc2-6b01-2ac8-d5bf-74c3df36b6ef@loongson.cn> <14cacb4e-d687-dfc4-8ad8-26f9f1050a0e@web.de> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Tiezhu Yang Message-ID: <856f5c62-d731-fc3c-0e41-0c2d8b4e24a3@loongson.cn> Date: Thu, 2 Jul 2020 20:35:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <14cacb4e-d687-dfc4-8ad8-26f9f1050a0e@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9DxL2uu1P1eaIZOAA--.7585S3 X-Coremail-Antispam: 1UD129KBjvdXoWrtrW5tF1DAr4DWFW5Zr4DXFb_yoW3ArX_Cr n0yrs2934DJa13tFn3KwsFqFnYgr98W3Z2vayrCFZrZ3s3G3ZrZayfGFyfAw1xXFWrCr9I kr1Y9r9YkFZxXjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8YjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWxJVW8Jr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l c2xSY4AK67AK6ryUMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I 0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWU tVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcV CY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280 aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7IU8bTm3UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2020 08:24 PM, Markus Elfring wrote: >>>>>>> +++ b/drivers/irqchip/irq-csky-apb-intc.c > … >> Let us keep it as it is > I propose to reconsider also this view. > > >> to make the code clear and to avoid the alignment issue: >> >> ret = foo(); >> if (ret) { >> ret = -ENOMEM; > How do you think about to delete this assignment if you would like to > reuse the return value from a call of the function “irq_alloc_domain_generic_chips”? OK, looks good to me, thank you. > > >> goto ... >> } > > Please apply a known script also for the purpose to achieve consistent indentation. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=cd77006e01b3198c75fb7819b3d0ff89709539bb#n3301 OK > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiezhu Yang Date: Thu, 02 Jul 2020 12:35:58 +0000 Subject: Re: [v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks Message-Id: <856f5c62-d731-fc3c-0e41-0c2d8b4e24a3@loongson.cn> List-Id: References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn> <564ffff9-6043-7191-2458-f425dd8d0c11@web.de> <1a0e007a-db94-501b-4ab9-0bb479ec093b@loongson.cn> <971c649e-fe07-3771-6fea-f5aaeaf090ad@web.de> <41b48aa5-e5b2-0257-8b3d-07e1b86634b4@web.de> <0726ddc2-6b01-2ac8-d5bf-74c3df36b6ef@loongson.cn> <14cacb4e-d687-dfc4-8ad8-26f9f1050a0e@web.de> In-Reply-To: <14cacb4e-d687-dfc4-8ad8-26f9f1050a0e@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Guo Ren , linux-csky@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org T24gMDcvMDIvMjAyMCAwODoyNCBQTSwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4+Pj4+Pj4gKysr IGIvZHJpdmVycy9pcnFjaGlwL2lycS1jc2t5LWFwYi1pbnRjLmMKPiDigKYKPj4gTGV0IHVzIGtl ZXAgaXQgYXMgaXQgaXMKPiBJIHByb3Bvc2UgdG8gcmVjb25zaWRlciBhbHNvIHRoaXMgdmlldy4K Pgo+Cj4+IHRvIG1ha2UgdGhlIGNvZGUgY2xlYXIgYW5kIHRvIGF2b2lkIHRoZSBhbGlnbm1lbnQg aXNzdWU6Cj4+Cj4+IHJldCA9IGZvbygpOwo+PiBpZiAocmV0KSB7Cj4+ICAgICAgICAgIHJldCA9 IC1FTk9NRU07Cj4gSG93IGRvIHlvdSB0aGluayBhYm91dCB0byBkZWxldGUgdGhpcyBhc3NpZ25t ZW50IGlmIHlvdSB3b3VsZCBsaWtlIHRvCj4gcmV1c2UgdGhlIHJldHVybiB2YWx1ZSBmcm9tIGEg Y2FsbCBvZiB0aGUgZnVuY3Rpb24g4oCcaXJxX2FsbG9jX2RvbWFpbl9nZW5lcmljX2NoaXBz4oCd PwoKT0ssIGxvb2tzIGdvb2QgdG8gbWUsIHRoYW5rIHlvdS4KCj4KPgo+PiAgICAgICAgICBnb3Rv IC4uLgo+PiB9Cj4KPiBQbGVhc2UgYXBwbHkgYSBrbm93biBzY3JpcHQgYWxzbyBmb3IgdGhlIHB1 cnBvc2UgdG8gYWNoaWV2ZSBjb25zaXN0ZW50IGluZGVudGF0aW9uLgo+IGh0dHBzOi8vZ2l0Lmtl cm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVl L3NjcmlwdHMvY2hlY2twYXRjaC5wbD9pZM03NzAwNmUwMWIzMTk4Yzc1ZmI3ODE5YjNkMGZmODk3 MDk1MzliYiNuMzMwMQoKT0sKCj4KPiBSZWdhcmRzLAo+IE1hcmt1cwo=