All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Kuniyuki Iwashima <kuni1840@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next] ref_tracker: Print allocator task name.
Date: Thu, 04 Apr 2024 16:42:55 +0200	[thread overview]
Message-ID: <8576a80ac958812ac75b01299c2de3a6485f84a1.camel@redhat.com> (raw)
In-Reply-To: <20240403201715.33883-1-kuniyu@amazon.com>

On Wed, 2024-04-03 at 13:17 -0700, Kuniyuki Iwashima wrote:
> @@ -208,6 +213,8 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
>  	}
>  	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
>  	tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
> +	if (in_task())
> +		get_task_comm(tracker->comm, current);

This apparently causes a lockdep splat, hit by the CI:

https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/537021/16-vrf-route-leaking-sh/stderr

it looks like get_task_comm() is for BH-only scope.

Cheers,

Paolo


  reply	other threads:[~2024-04-04 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 20:17 [PATCH v1 net-next] ref_tracker: Print allocator task name Kuniyuki Iwashima
2024-04-04 14:42 ` Paolo Abeni [this message]
2024-04-04 16:51   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8576a80ac958812ac75b01299c2de3a6485f84a1.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.