[meta-networking][PATCH] networkmanager: goodbye libnm-glib

[meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Hongxu Jia]

Since commit [061953143 networkmanager: Update to 1.18.0] applied,
upstream disable libnm-glib by default. And in further networkmanager,
upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good

https://github.com/NetworkManager/NetworkManager/commit/df58895fb3479c4f00b9107126759d138250fef2
https://github.com/NetworkManager/NetworkManager/commit/5801f89f4d1464fc15cb1d97755b73f9f68cb2e6

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../networkmanager/networkmanager_1.18.0.bb                | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.0.bb
index 9215a8676..cc84d614d 100644
--- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.0.bb
+++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.0.bb
@@ -87,21 +87,16 @@ PACKAGECONFIG[ppp] = "--enable-ppp,--disable-ppp,ppp,ppp"
 PACKAGECONFIG[dhclient] = "--with-dhclient=${base_sbindir}/dhclient,,,dhcp-client"
 PACKAGECONFIG[dnsmasq] = "--with-dnsmasq=${bindir}/dnsmasq"
 PACKAGECONFIG[nss] = "--with-crypto=nss,,nss"
-PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"
 PACKAGECONFIG[gnutls] = "--with-crypto=gnutls,,gnutls"
 PACKAGECONFIG[wifi] = "--enable-wifi=yes,--enable-wifi=no,,wpa-supplicant"
 PACKAGECONFIG[ifupdown] = "--enable-ifupdown,--disable-ifupdown"
 PACKAGECONFIG[qt4-x11-free] = "--enable-qt,--disable-qt,qt4-x11-free"
 
-PACKAGES =+ "libnmutil libnmglib libnmglib-vpn \
+PACKAGES =+ " \
   ${PN}-nmtui ${PN}-nmtui-doc \
   ${PN}-adsl \
 "
 
-FILES_libnmutil += "${libdir}/libnm-util.so.*"
-FILES_libnmglib += "${libdir}/libnm-glib.so.*"
-FILES_libnmglib-vpn += "${libdir}/libnm-glib-vpn.so.*"
-
 FILES_${PN}-adsl = "${libdir}/NetworkManager/libnm-device-plugin-adsl.so"
 
 FILES_${PN} += " \
-- 
2.17.1

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Adrian Bunk]

On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
> Since commit [061953143 networkmanager: Update to 1.18.0] applied,
> upstream disable libnm-glib by default. And in further networkmanager,
> upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
>...

Any strong reason for removing this already now?

It's gone in 1.20 so removal then is clear, but if someone wants
to use it for legacy code with 1.18 this should stay possible as
long as <= 1.18 is shipped.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Hongxu Jia]

On 6/28/19 6:07 PM, Adrian Bunk wrote:
> On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
>> Since commit [061953143 networkmanager: Update to 1.18.0] applied,
>> upstream disable libnm-glib by default. And in further networkmanager,
>> upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
>> ...
> Any strong reason for removing this already now?

Make sure to clean up empty package, in 1.18

libnm-glib is already disabled, and left three empty

packages(no package generated acturally). I found

the issue, trace the reason and provide fix


You may note original PACKAGECONFIG[glib] does not have

without option, so clean up it rather than add missing without option

PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"


> It's gone in 1.20 so removal then is clear, but if someone wants
> to use it for legacy code with 1.18 this should stay possible as
> long as <= 1.18 is shipped.

I think it will be upgraded 1.20 soon, and if someone wants

to use legacy code, I think 1.16 in warrior is better choose

which libnm-glib is always enabled

//Hongxu


> cu
> Adrian
>

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Adrian Bunk]

On Fri, Jun 28, 2019 at 10:57:02PM +0800, Hongxu Jia wrote:
> On 6/28/19 6:07 PM, Adrian Bunk wrote:
> > On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
> > > Since commit [061953143 networkmanager: Update to 1.18.0] applied,
> > > upstream disable libnm-glib by default. And in further networkmanager,
> > > upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
> > > ...
> > Any strong reason for removing this already now?
> 
> Make sure to clean up empty package, in 1.18
> 
> libnm-glib is already disabled, and left three empty
> 
> packages(no package generated acturally). I found
> 
> the issue, trace the reason and provide fix

What problem does this issue cause?

> You may note original PACKAGECONFIG[glib] does not have
> 
> without option, so clean up it rather than add missing without option
> 
> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"

That is actually fine and doesn't need a fix - the library is only built 
if explicitely requested --with-libnm-glib.

> > It's gone in 1.20 so removal then is clear, but if someone wants
> > to use it for legacy code with 1.18 this should stay possible as
> > long as <= 1.18 is shipped.
> 
> I think it will be upgraded 1.20 soon, and if someone wants
> 
> to use legacy code, I think 1.16 in warrior is better choose
> 
> which libnm-glib is always enabled

"soon" might be after Yocto 2.8 branches.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Hongxu Jia]

On 7/1/19 8:55 PM, Adrian Bunk wrote:
> On Fri, Jun 28, 2019 at 10:57:02PM +0800, Hongxu Jia wrote:
>> On 6/28/19 6:07 PM, Adrian Bunk wrote:
>>> On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
>>>> Since commit [061953143 networkmanager: Update to 1.18.0] applied,
>>>> upstream disable libnm-glib by default. And in further networkmanager,
>>>> upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
>>>> ...
>>> Any strong reason for removing this already now?
>> Make sure to clean up empty package, in 1.18
>>
>> libnm-glib is already disabled, and left three empty
>>
>> packages(no package generated acturally). I found
>>
>> the issue, trace the reason and provide fix
> What problem does this issue cause?

This is the fix on meta-anaconda, if you do not like to remove

libnm-glib in this version, please do it in next upgrading

...

commit 270a8f01c17941f73539f22e131b9df6f3af81c3
Author: Hongxu Jia <hongxu.jia@windriver.com>
Date:   Thu Jun 27 13:37:54 2019 +0000

     python3-anaconda: do not runtime depends on libnmutil libnmglib 
libnmglib-vpn

     Since commit [061953143 networkmanager: Update to 1.18.0] applied 
in OE,
     upstream networkmanager  disable libnm-glib by default. And in 
further networkmanager,
     upstream networkmanager removes libnm-glib, libnm-glib-vpn, and 
libnm-util for good

https://github.com/NetworkManager/NetworkManager/commit/df58895fb3479c4f00b9107126759d138250fef2
https://github.com/NetworkManager/NetworkManager/commit/5801f89f4d1464fc15cb1d97755b73f9f68cb2e6

     Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>

diff --git a/recipes-installer/anaconda/python3-anaconda_28.22.11.bb 
b/recipes-installer/anaconda/python3-anaconda_28.22.11.bb
index 32770e3..96aa201 100755
--- a/recipes-installer/anaconda/python3-anaconda_28.22.11.bb
+++ b/recipes-installer/anaconda/python3-anaconda_28.22.11.bb
@@ -42,7 +42,7 @@ RDEPENDS_${PN} = "e2fsprogs e2fsprogs-e2fsck 
e2fsprogs-mke2fs \
                     python3-systemd python3-pydbus python3-simpleline \
                  "

-RDEPENDS_${PN} += "networkmanager libnmutil libnmglib libnmglib-vpn \
+RDEPENDS_${PN} += "networkmanager \
                     network-manager-applet \

...

//Hongxu


>
>> You may note original PACKAGECONFIG[glib] does not have
>>
>> without option, so clean up it rather than add missing without option
>>
>> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"
> That is actually fine and doesn't need a fix - the library is only built
> if explicitely requested --with-libnm-glib.
>
>>> It's gone in 1.20 so removal then is clear, but if someone wants
>>> to use it for legacy code with 1.18 this should stay possible as
>>> long as <= 1.18 is shipped.
>> I think it will be upgraded 1.20 soon, and if someone wants
>>
>> to use legacy code, I think 1.16 in warrior is better choose
>>
>> which libnm-glib is always enabled
> "soon" might be after Yocto 2.8 branches.
>
>> //Hongxu
> cu
> Adrian
>

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Hongxu Jia]

On 7/1/19 8:55 PM, Adrian Bunk wrote:
>> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"
> That is actually fine and doesn't need a fix - the library is only built
> if explicitely requested --with-libnm-glib.
>
I don't think so, it we want to explicitly expected --with-libnm-glib,

we should add it to EXTRA_OECONF, since 1.18.0, it is disable

by default if glib not in PACKAGECONFIG

//Hongxu

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Khem Raj]

Hi Hongxu

Lets wait until 1.20 release of network manager. Can you propose this
again after
1.20 is released and upgraded in OE?

On Fri, Jun 28, 2019 at 7:57 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> On 6/28/19 6:07 PM, Adrian Bunk wrote:
> > On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
> >> Since commit [061953143 networkmanager: Update to 1.18.0] applied,
> >> upstream disable libnm-glib by default. And in further networkmanager,
> >> upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
> >> ...
> > Any strong reason for removing this already now?
>
> Make sure to clean up empty package, in 1.18
>
> libnm-glib is already disabled, and left three empty
>
> packages(no package generated acturally). I found
>
> the issue, trace the reason and provide fix
>
>
> You may note original PACKAGECONFIG[glib] does not have
>
> without option, so clean up it rather than add missing without option
>
> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"
>
>
> > It's gone in 1.20 so removal then is clear, but if someone wants
> > to use it for legacy code with 1.18 this should stay possible as
> > long as <= 1.18 is shipped.
>
> I think it will be upgraded 1.20 soon, and if someone wants
>
> to use legacy code, I think 1.16 in warrior is better choose
>
> which libnm-glib is always enabled
>
> //Hongxu
>
>
> > cu
> > Adrian
> >
>

Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Hongxu Jia]

On 7/10/19 1:40 AM, Khem Raj wrote:
> Hi Hongxu
>
> Lets wait until 1.20 release of network manager. Can you propose this
> again after
> 1.20 is released and upgraded in OE?

No problem

//Hongxu


> On Fri, Jun 28, 2019 at 7:57 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> On 6/28/19 6:07 PM, Adrian Bunk wrote:
>>> On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
>>>> Since commit [061953143 networkmanager: Update to 1.18.0] applied,
>>>> upstream disable libnm-glib by default. And in further networkmanager,
>>>> upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
>>>> ...
>>> Any strong reason for removing this already now?
>> Make sure to clean up empty package, in 1.18
>>
>> libnm-glib is already disabled, and left three empty
>>
>> packages(no package generated acturally). I found
>>
>> the issue, trace the reason and provide fix
>>
>>
>> You may note original PACKAGECONFIG[glib] does not have
>>
>> without option, so clean up it rather than add missing without option
>>
>> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"
>>
>>
>>> It's gone in 1.20 so removal then is clear, but if someone wants
>>> to use it for legacy code with 1.18 this should stay possible as
>>> long as <= 1.18 is shipped.
>> I think it will be upgraded 1.20 soon, and if someone wants
>>
>> to use legacy code, I think 1.16 in warrior is better choose
>>
>> which libnm-glib is always enabled
>>
>> //Hongxu
>>
>>
>>> cu
>>> Adrian
>>>