All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Pilcher <arequipeno@gmail.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: pavel@ucw.cz, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	hch@infradead.org
Subject: Re: [RESEND PATCH v5 2/2] leds: trigger: Add block device LED trigger
Date: Fri, 8 Oct 2021 09:04:46 -0500	[thread overview]
Message-ID: <857be92d-1f7b-dee6-56cb-6138e07c2717@gmail.com> (raw)
In-Reply-To: <20211008120116.65aec469@thinkpad>

On 10/8/21 05:01, Marek Behún wrote:
> On Wed, 6 Oct 2021 11:07:06 -0500
> Ian Pilcher <arequipeno@gmail.com> wrote:
> 
>> I have feeling that per-LED work items are likely to cause contention
>> for the mutex, since they will probably all have the same (default)
>> interval and they will usually be set up at about the same time (i.e.
>> at system boot).  Instead, I would propose to have a single work item
>> that is simply scheduled for the next time work is "needed" and then
>> checks all LEDs that are due at that time.
> 
> What about creating one work struct for all different interval values?
> 
> That way if the user never changes the interval, there will be only one
> work struct.
> 
> I wonder if this can be done in a sensible (i.e. not overcomplicated
> code) way.

I've been working on this (along with the other changes), and it's about
ready to go.  I'll send it out later today, once I've had a chance to
write up the changelog.

Thanks!

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================

      reply	other threads:[~2021-10-08 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 15:55 [RESEND PATCH v5 0/2] Introduce block device LED trigger Ian Pilcher
2021-10-04 15:55 ` [RESEND PATCH v5 1/2] docs: Add block device (blkdev) LED trigger documentation Ian Pilcher
2021-10-04 15:55 ` [RESEND PATCH v5 2/2] leds: trigger: Add block device LED trigger Ian Pilcher
2021-10-05 21:27   ` Marek Behún
2021-10-06 16:07     ` Ian Pilcher
2021-10-08 10:01       ` Marek Behún
2021-10-08 14:04         ` Ian Pilcher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=857be92d-1f7b-dee6-56cb-6138e07c2717@gmail.com \
    --to=arequipeno@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=kabel@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.