From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE92C4338F for ; Tue, 27 Jul 2021 16:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A30E661B96 for ; Tue, 27 Jul 2021 16:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbhG0QWs (ORCPT ); Tue, 27 Jul 2021 12:22:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46668 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbhG0QWr (ORCPT ); Tue, 27 Jul 2021 12:22:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627402967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPWTUR9j0gcXGQdIAP6YbMUowgAzQ/1Mn6FbqGf6YX0=; b=KgT49YPMG/QumjyCuRVIUrWXPaq7hyakejRapIj24uSMKOwBqQWRebG2w5lvL3nt7pdwvc LcAwyLGKZe6JntZDOTWhMYP9kNIlLFOA7FozBkO022/NhhKocU4qK6LVLeez6yFYQNsRXS r8+zuaBM5Qo/FEMK8PnRpMrprzicKSQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-6Vq0CGuhPxiEnxijyP9dSw-1; Tue, 27 Jul 2021 12:22:45 -0400 X-MC-Unique: 6Vq0CGuhPxiEnxijyP9dSw-1 Received: by mail-qv1-f71.google.com with SMTP id hf7-20020a0562140e87b02902dc988b8675so11043361qvb.3 for ; Tue, 27 Jul 2021 09:22:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=EPWTUR9j0gcXGQdIAP6YbMUowgAzQ/1Mn6FbqGf6YX0=; b=qbTqIUg5EJ3UAAqtXvOkDR1scFPwLE93YQHVqQ1v2aq6AqtI/lO6/qOSuxjklxi5YO 6AiyepN42xYL2l41Mwt+qkNB//8bzzDTF9sdZVAHJxujaNDN1mlAj03hADxXmRd/g3gi zqYL276k6QnhR09LNyix0BE4O0D+FyjlU/PtYexW/jetS63KchFwE1VNUroEk7xRrGri 6hQOAe6tOpLG72pd+TCXrOB3oZxPjChPS8DDt3K0+1/OAqBDLEfftUd786HISnRcc+V1 UeHNxbngxznOoBHliUYYClAdCHg+bSL679x6Buhzvuw/BVkKctQSOF5ef2ujY2VJ2ftY w+gg== X-Gm-Message-State: AOAM531ZRvp2JHRCNlOii/s9R3G2ibT0KN98BdDzfNIwPemCguVhoIP7 gsFxLEqw0WYvwrsT+UZyGiz3bdPy/NgeqalQIouRLt9afRMOiCfK9QRc1LWzAsaHzsQgTh/TkC8 b/2GicBm/OuEdLqD5U6uUew== X-Received: by 2002:a05:620a:2fb:: with SMTP id a27mr22805097qko.279.1627402965327; Tue, 27 Jul 2021 09:22:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDQGBsQqInHoAuJlKxVDk8opt0TyFOkaYJQ1inBF7nbKNkxdtQ51PTe1k4BDT9GgV1rSVs6Q== X-Received: by 2002:a05:620a:2fb:: with SMTP id a27mr22805080qko.279.1627402965156; Tue, 27 Jul 2021 09:22:45 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id e2sm1991081qkn.69.2021.07.27.09.22.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 09:22:44 -0700 (PDT) Subject: Re: [RESEND PATCH v10 0/3] fpga: Use standard class dev_release function To: Russ Weight , mdf@kernel.org, linux-fpga@vger.kernel.org, "Wu, Hao" Cc: lgoncalv@redhat.com, yilun.xu@intel.com, matthew.gerlach@intel.com, richard.gong@intel.com References: <20210726212750.121293-1-russell.h.weight@intel.com> <39607b02-bad3-0f65-c1c8-efd6036ab4f3@intel.com> <661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com> From: Tom Rix Message-ID: <8584c933-4482-446a-761c-9a5d511a81c5@redhat.com> Date: Tue, 27 Jul 2021 09:22:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 7/27/21 9:15 AM, Russ Weight wrote: > > On 7/27/21 6:24 AM, Tom Rix wrote: >> On 7/26/21 2:33 PM, Russ Weight wrote: >>> Hi Moritz, >>> >>> I sent this version of the patchset out on July 8th. The only discussion has >>> been around the compat-id structure. I think there is agreement that this can >>> be treated separately. What are your thoughts? Do you think this patchset is >>> ready? >> While I agree the compat_id can be treated separately, i still have a problem with the 2 register functions. >> >> In this discussion, >> >> https://lore.kernel.org/linux-fpga/DM6PR11MB38194D113950FA4B75C7F2C485E49@DM6PR11MB3819.namprd11.prod.outlook.com/ >> >> *register_full(..., *info) becomes >> >> *register(..., *info) >> >> and >> >> *register_simple() is moved out of the public api and becomes private to the subsystem. > Somehow I missed that part of the email. I'm not sure I understand the part about > register_simple() "becomes private to the subsystem". Most users would call the simple > version of the API. Is the proposal to replicate the register_simple() interface > for each driver that calls it? Still use *register_simple() internally, so most of your patchset is unchanged. Move it out the public api. include/linux/fpga-mgr.h into someplace appropriate in drivers/fpga/ Tom > >> Tom >> >>> Thanks, >>> - Russ >>> >>> >>> On 7/26/21 2:27 PM, Russ Weight wrote: >>>> The FPGA framework has a convention of using managed resource functions >>>> to allow parent drivers to manage the data structures allocated by the >>>> class drivers. They use an empty *_dev_release() function to satisfy the >>>> class driver. >>>> >>>> This is inconsistent with linux driver model. >>>> >>>> These changes remove the managed resource functions and populate the class >>>> dev_release callback functions. They also merge the create() and register() >>>> functions into a single register() or register_full() function for each of >>>> the fpga-mgr, fpga-region, and fpga-bridge class drivers. >>>> >>>> The new *register_full() functions accept an info data structure to provide >>>> flexibility in passing optional parameters. The *register() functions >>>> support the legacy parameter list for users that don't require the use of >>>> optional parameters. >>>> >>>> For more context, refer to this email thread: >>>> >>>> https://marc.info/?l=linux-fpga&m=162127412218557&w=2 >>>> >>>> I turned on the configs assocated with each of the modified files, but I >>>> must have been missing some dependencies, because not all of them compiled. >>>> I did a run-time test specifically with the dfl-fme infrastructure. This >>>> would have exercised the region, bridge, and fpga-mgr frameworks. >>>> >>>> Changelog v9 -> v10: >>>>    - Fixed commit messages to reference register_full() instead of >>>>      register_simple(). >>>>    - Removed the fpga_bridge_register_full() function, because there is >>>>      not need for it yet. Updated the documentation and commit message >>>>      accordingly. >>>>    - Updated documentation to reference the fpga_manager_info and >>>>      fpga_region_info structures. >>>> >>>> Changelog v8 -> v9: >>>>    - Cleaned up documentation for the FPGA Manager, Bridge, and Region >>>>      register functions >>>>    - Renamed fpga_*_register() to fpga_*_register_full() >>>>    - Renamed fpga_*_register_simple() to fpga_*_register() >>>>    - Renamed devm_fpga_mgr_register() to devm_fpga_mgr_register_full() >>>>    - Renamed devm_fpga_mgr_register_simple() to devm_fpga_mgr_register() >>>> >>>> Changelog v7 -> v8: >>>>    - Added reviewed-by tags. >>>>    - Updated Documentation/driver-api/fpga/ files: fpga-mgr.rst, >>>>      fpga-bridge.rst, and fpga-region.rst. >>>> >>>> Changelog v6 -> v7: >>>>    - Update the commit messages to describe the new parameters for the >>>>      *register() functions and to mention the *register_simple() functions. >>>>    - Fix function prototypes in header file to rename dev to parent. >>>>    - Make use of the PTR_ERR_OR_ZERO() macro when possible. >>>>    - Some cleanup of comments. >>>>    - Update function definitions/prototypes to apply const to the new info >>>>      parameter. >>>>    - Verify that info->br_ops is non-null in the fpga_bridge_register() >>>>      function. >>>>    - Verify a non-null info pointer in the fpga_region_register() function. >>>> >>>> Changelog v5 -> v6: >>>>    - Moved FPGA manager/bridge/region optional parameters out of the ops >>>>      structure and back into the FPGA class driver structure. >>>>    - Changed fpga_*_register() function parameters to accept an info data >>>>      structure to provide flexibility in passing optional parameters. >>>>    - Added fpga_*_register_simple() functions to support current parameters >>>>      for users that don't require use of optional parameters. >>>> >>>> Changelog v4 -> v5: >>>>    - Rebased on top of recently accepted patches. >>>>    - Removed compat_id from the fpga_mgr_register() parameter list >>>>      and added it to the fpga_manager_ops structure. This also required >>>>      dynamically allocating the dfl-fme-ops structure in order to add >>>>      the appropriate compat_id. >>>>    - Created the fpga_region_ops data structure which is optionally passed >>>>      to fpga_region_register(). compat_id, the get_bridges() pointer, and >>>>      the priv pointer are included in the fpga_region_ops structure. >>>> >>>> Changelog v3 -> v4: >>>>    - Added the compat_id parameter to fpga_mgr_register() and >>>>      devm_fpga_mgr_register() to ensure that the compat_id is set before >>>>      the device_register() call. >>>>    - Added the compat_id parameter to fpga_region_register() to ensure >>>>      that the compat_id is set before the device_register() call. >>>>    - Modified the dfl_fpga_feature_devs_enumerate() function to restore >>>>      the fpga_region_register() call to the correct location. >>>> >>>> Changelog v2 -> v3: >>>>    - Cleaned up comment headers for fpga_mgr_register(), fpga_bridge_register(), >>>>      and fpga_region_register(). >>>>    - Fixed error return on ida_simple_get() failure for fpga_mgr_register(), >>>>      fpga_bridge_register(), and fpga_region_register(). >>>>    - Fixed error return value for fpga_bridge_register(): ERR_PTR(ret) instead >>>>      of NULL. >>>> >>>> Changelog v1 -> v2: >>>>    - Restored devm_fpga_mgr_register() functionality to the fpga-mgr >>>>      class driver, adapted for the combined create/register functionality. >>>>    - All previous callers of devm_fpga_mgr_register() will continue to call >>>>      devm_fpga_mgr_register(). >>>>    - replaced unnecessary ternary operators in return statements with >>>>      standard if conditions. >>>> >>>> Russ Weight (3): >>>>    fpga: mgr: Use standard dev_release for class driver >>>>    fpga: bridge: Use standard dev_release for class driver >>>>    fpga: region: Use standard dev_release for class driver >>>> >>>>   Documentation/driver-api/fpga/fpga-bridge.rst |   6 +- >>>>   Documentation/driver-api/fpga/fpga-mgr.rst    |  38 +++- >>>>   Documentation/driver-api/fpga/fpga-region.rst |  12 +- >>>>   drivers/fpga/altera-cvp.c                     |  12 +- >>>>   drivers/fpga/altera-fpga2sdram.c              |  12 +- >>>>   drivers/fpga/altera-freeze-bridge.c           |  10 +- >>>>   drivers/fpga/altera-hps2fpga.c                |  12 +- >>>>   drivers/fpga/altera-pr-ip-core.c              |   7 +- >>>>   drivers/fpga/altera-ps-spi.c                  |   9 +- >>>>   drivers/fpga/dfl-fme-br.c                     |  10 +- >>>>   drivers/fpga/dfl-fme-mgr.c                    |  22 +- >>>>   drivers/fpga/dfl-fme-region.c                 |  17 +- >>>>   drivers/fpga/dfl.c                            |  12 +- >>>>   drivers/fpga/fpga-bridge.c                    | 122 +++------- >>>>   drivers/fpga/fpga-mgr.c                       | 215 ++++++++---------- >>>>   drivers/fpga/fpga-region.c                    | 119 ++++------ >>>>   drivers/fpga/ice40-spi.c                      |   9 +- >>>>   drivers/fpga/machxo2-spi.c                    |   9 +- >>>>   drivers/fpga/of-fpga-region.c                 |  10 +- >>>>   drivers/fpga/socfpga-a10.c                    |  16 +- >>>>   drivers/fpga/socfpga.c                        |   9 +- >>>>   drivers/fpga/stratix10-soc.c                  |  16 +- >>>>   drivers/fpga/ts73xx-fpga.c                    |   9 +- >>>>   drivers/fpga/xilinx-pr-decoupler.c            |  17 +- >>>>   drivers/fpga/xilinx-spi.c                     |  11 +- >>>>   drivers/fpga/zynq-fpga.c                      |  16 +- >>>>   drivers/fpga/zynqmp-fpga.c                    |   9 +- >>>>   include/linux/fpga/fpga-bridge.h              |  30 ++- >>>>   include/linux/fpga/fpga-mgr.h                 |  62 +++-- >>>>   include/linux/fpga/fpga-region.h              |  36 ++- >>>>   30 files changed, 383 insertions(+), 511 deletions(-) >>>>