From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Yan <andy.yan@rock-chips.com>
Date: Tue, 16 May 2017 08:47:35 +0800
Subject: [U-Boot] [PATCH v2 6/7] rockchip: rk3368: Add initial support
 for RK3368 based GeekBox
In-Reply-To: <0b52c4fa-d372-0e97-21eb-c2d7fb450aaf@suse.de>
References: <1494841762-6340-1-git-send-email-andy.yan@rock-chips.com>
 <1494842066-6707-1-git-send-email-andy.yan@rock-chips.com>
 <0b52c4fa-d372-0e97-21eb-c2d7fb450aaf@suse.de>
Message-ID: <85872eb3-58a0-8c91-22d4-3e49b3e777a5@rock-chips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Hi:


On 2017年05月15日 21:23, Andreas Färber wrote:
> Am 15.05.2017 um 11:54 schrieb Andy Yan:
>> From: Andreas Färber <afaerber@suse.de>
>>
>> The GeekBox is a TV box from GeekBuying, based on an MXM3 module.
>> The module can be used with base boards such as the GeekBox Landingship.
>> This adds basic support to chain-load U-Boot from Rockchip's miniloader.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> Changes in v2: None
> Still no README?

     I already added a README in this patch, but forgot to mention it in
   the changes log.
> I just confirmed that my original patchset had a separate commit for the
> .dts import, and then a big commit that added one line to it. You've
> squashed that into this single commit, and you fail to mention where the
> .dts comes from (e.g., v4.11?). It would be nice to have some "[...]"
> comment before your Signed-off-by that details which changes you made in
> my name here.
>
> Also, if my clock-frequency(?) line is still hidden in there, I believe
> that should be handled via some external -uboot.dtsi file by now?

     I keep all your dts file unmodified here.
>
> Regards,
> Andreas
>