From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78673C4320A for ; Sat, 28 Aug 2021 21:52:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AB6160462 for ; Sat, 28 Aug 2021 21:52:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232633AbhH1Vx0 (ORCPT ); Sat, 28 Aug 2021 17:53:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhH1VxY (ORCPT ); Sat, 28 Aug 2021 17:53:24 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA1C0C061756; Sat, 28 Aug 2021 14:52:33 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id z4so16234161wrr.6; Sat, 28 Aug 2021 14:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=JJCwgQFjCSJNhbTyoyaxjPlruVTGCzjmC4R3DiQ5BA0=; b=RRYevVMMofQgeIqhjO427n9IVgzgU6jB5x0ymhNUBsjC3MqI9F25aT6v6f6wYPxMwn UONG/GQ/LEX8xMkWmgUYQnnJNPz6RGll0l5BBqYFAy4rH8z706Sdr8RC2SvJ6RD+QIoY R+g4lNxxVIGvDLA2akTAB7wHhJGA3JOj+eN1luc3xY9bEXbBwz4Rk1FMqtptx1K77wXK 9y7PE4WGAJhiAuWCHg32eAlsHhn9Vv5mt6IyGXwUFnv4li0odNHkIJTHXmezSfRzm8n9 JR59dlhXEg28e3pkdTTb+Mw3T6dcqpy+beDxkwhQi0eZBcSyM7cgO16qhuUr+KaT0q7K MGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=JJCwgQFjCSJNhbTyoyaxjPlruVTGCzjmC4R3DiQ5BA0=; b=eW9Co5f+GzkyncJYk0oxDfK9/bWpBwW+TmG9J/P2nifBGRev9kGEnvopB9sRHNRhpE /YgTfETG3XJgz+wO2ZTjTetOIzgbDSUXGps71S2A2wTj+Hs3AZEMrz4hDNqbJzPLPIVN NUgb2wLrxMCMNPrdlvSrpf4cZlfJ2Rxfiim7OYtjeRngdGnbxvmcG+BU5WgbK13CNMyn cXjalTn1RyGXQSbm3ZdOYByWdp3iOBN8ThsHnLyEmjHimbtr2MGzI72kJGk81GmDLaBv B/2fi/rec1tcFXmKvfKGIjjFwwRDtS5obWK/qGyeM70inJpPlWSAnB+LGQBbRJYZjyvg DS6g== X-Gm-Message-State: AOAM533ow6i+w03d1qI8EVn1gtDJfbUEVVjnscaNuJsxGxX0GWTTBHfk p0AzSxoDt+SNv2ANNYzHntJIUUQB15oW2g== X-Google-Smtp-Source: ABdhPJxS2krldZzW91UNrktjT9dt9csrMj7vrwJj9ZG2j2ImbKBwRAi+pO0391xB7Gxb3Yzp7V76zQ== X-Received: by 2002:adf:9f47:: with SMTP id f7mr10292147wrg.401.1630187551980; Sat, 28 Aug 2021 14:52:31 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id n3sm10046215wmi.0.2021.08.28.14.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Aug 2021 14:52:31 -0700 (PDT) Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names To: Andrew Lunn Cc: Florian Fainelli , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210828112704.2283805-1-mnhagan88@gmail.com> <20210828112704.2283805-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> Date: Sat, 28 Aug 2021 22:52:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2021 18:07, Andrew Lunn wrote: > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote: >> This patch fixes the following message by adding "mdio-mux" compatible: >> compatible: ['mdio-mux-mmioreg'] is too short > > Err, what? This sounds like a workaround for a tool problem, not a > real fix. > > What is actually wrong with: > > compatible = "mdio-mux-mmioreg"; Yes this does work fine either with or without "mdio-mux". The changes have been made to correspond with those submitted by Rafal Milecki for the BCM5301X platform[1] and to conform with Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml which does state both as required items (and hence not a tool problem). [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ > > Andrew > Matthew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FBCC432BE for ; Sat, 28 Aug 2021 21:55:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6082D60E77 for ; Sat, 28 Aug 2021 21:55:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6082D60E77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QmhcIbQfhMxfRyFbGwNHdb20W7x931Cv+Ezg85P1wAI=; b=bfjl2iwR+k7JmrBqZmc19IEeiG O7rEzAucb9WAc9zvh5Ie8qMIq2E24MdmkT34D+EOReSWYtVzppkgpAbXzARUeASG/RzlL/RzmSACn YhESdJArhh6jXkrrSkXPLWKx0QBGrO6HvkBz0iOcEzDkMZIxfz+xB2bsOcIZw2/p8NaVuuwPx+5yh 9cHe6TuGMC6TKdfyoz48bNbprMjmowYnlB5mnTDZthF++YkRfM2WPZeZ5yPfhWK/VN6jOAUXNtwdE HA71/nNdbHZJ1DynLS+y+m666j4KXFJHtWWRuM4Fb/ukTkJS+WK2SjlPIzC3/UFExCH1ePu5izfqx OQvPKnew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK6Fj-00EjRh-JC; Sat, 28 Aug 2021 21:52:39 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK6Fg-00EjQt-82 for linux-arm-kernel@lists.infradead.org; Sat, 28 Aug 2021 21:52:37 +0000 Received: by mail-wr1-x435.google.com with SMTP id x6so8013974wrv.13 for ; Sat, 28 Aug 2021 14:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=JJCwgQFjCSJNhbTyoyaxjPlruVTGCzjmC4R3DiQ5BA0=; b=RRYevVMMofQgeIqhjO427n9IVgzgU6jB5x0ymhNUBsjC3MqI9F25aT6v6f6wYPxMwn UONG/GQ/LEX8xMkWmgUYQnnJNPz6RGll0l5BBqYFAy4rH8z706Sdr8RC2SvJ6RD+QIoY R+g4lNxxVIGvDLA2akTAB7wHhJGA3JOj+eN1luc3xY9bEXbBwz4Rk1FMqtptx1K77wXK 9y7PE4WGAJhiAuWCHg32eAlsHhn9Vv5mt6IyGXwUFnv4li0odNHkIJTHXmezSfRzm8n9 JR59dlhXEg28e3pkdTTb+Mw3T6dcqpy+beDxkwhQi0eZBcSyM7cgO16qhuUr+KaT0q7K MGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=JJCwgQFjCSJNhbTyoyaxjPlruVTGCzjmC4R3DiQ5BA0=; b=Z8K8fGi0xqPtIyAoYPpfhvj+7/uhI0HBljWJuNTY8E7kWy4KzHBjrJ6lMBWX1j/quP dbf80+RJzcC3XfHSyTvwOl8BZeQcdRA/qzA5/M18neei0qVGm7y7NXPEIVJQvkuK8Gba fCAVmV6gMkLrQJHla5nV43IMqZ1Rg0GVhL+WjGa1FtvcuV+8L6Vm6r8j0BrLPEjbCVzc XuArK5Dt2sSWR9+Yxkktza5JjV/Zqm5jBZrWpjRfgTaPN2Samwkq7U3ugIuEUSEZ6Glr SHSisuA65HxGiRNoTwngAs05fCOgScnk4wftaoCU1z+7X3KEx2KmGTUzfpw3IY4LRfPd 77Zg== X-Gm-Message-State: AOAM532A75ZYQy2eh0LLJXlbNawUOPo5WeXhBWNLAq0Ivq3oqs4Xu1sp HOeOSb74FScHPm34eglEAAQ= X-Google-Smtp-Source: ABdhPJxS2krldZzW91UNrktjT9dt9csrMj7vrwJj9ZG2j2ImbKBwRAi+pO0391xB7Gxb3Yzp7V76zQ== X-Received: by 2002:adf:9f47:: with SMTP id f7mr10292147wrg.401.1630187551980; Sat, 28 Aug 2021 14:52:31 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id n3sm10046215wmi.0.2021.08.28.14.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Aug 2021 14:52:31 -0700 (PDT) Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names To: Andrew Lunn Cc: Florian Fainelli , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210828112704.2283805-1-mnhagan88@gmail.com> <20210828112704.2283805-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> Date: Sat, 28 Aug 2021 22:52:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210828_145236_347358_AD60F1C7 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/08/2021 18:07, Andrew Lunn wrote: > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote: >> This patch fixes the following message by adding "mdio-mux" compatible: >> compatible: ['mdio-mux-mmioreg'] is too short > > Err, what? This sounds like a workaround for a tool problem, not a > real fix. > > What is actually wrong with: > > compatible = "mdio-mux-mmioreg"; Yes this does work fine either with or without "mdio-mux". The changes have been made to correspond with those submitted by Rafal Milecki for the BCM5301X platform[1] and to conform with Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml which does state both as required items (and hence not a tool problem). [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ > > Andrew > Matthew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel