From: Jon Hunter <jonathanh@nvidia.com>
To: Tom Rix <trix@redhat.com>,
ldewangan@nvidia.com, vkoul@kernel.org, thierry.reding@gmail.com,
nathan@kernel.org, ndesaulniers@google.com
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] dmaengine: tegra-apb: remove unused tdma_read function
Date: Wed, 22 Mar 2023 13:46:02 +0000 [thread overview]
Message-ID: <85946aff-0cf7-62ca-60f6-e95c65b67e51@nvidia.com> (raw)
In-Reply-To: <20230322121001.2569909-1-trix@redhat.com>
On 22/03/2023 12:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
> 'tdma_read' [-Werror,-Wunused-function]
> static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index eaafcbe4ca94..cc6b91f48979 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
> writel(val, tdma->base_addr + reg);
> }
>
> -static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> -{
> - return readl(tdma->base_addr + reg);
> -}
> -
> static inline void tdc_write(struct tegra_dma_channel *tdc,
> u32 reg, u32 val)
> {
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
next prev parent reply other threads:[~2023-03-22 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 12:10 [PATCH] dmaengine: tegra-apb: remove unused tdma_read function Tom Rix
2023-03-22 13:46 ` Jon Hunter [this message]
2023-03-31 12:21 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85946aff-0cf7-62ca-60f6-e95c65b67e51@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.