From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:26754 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726809AbgBJNkY (ORCPT ); Mon, 10 Feb 2020 08:40:24 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01ADe8OS093309 for ; Mon, 10 Feb 2020 08:40:23 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2y1u8072r7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Feb 2020 08:40:23 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Feb 2020 13:40:21 -0000 Subject: Re: [PATCH 31/35] KVM: s390: protvirt: Add UV debug trace References: <20200207113958.7320-1-borntraeger@de.ibm.com> <20200207113958.7320-32-borntraeger@de.ibm.com> <20200210142229.41da20dd.cohuck@redhat.com> From: Christian Borntraeger Date: Mon, 10 Feb 2020 14:40:16 +0100 MIME-Version: 1.0 In-Reply-To: <20200210142229.41da20dd.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <85947d75-2907-a985-2aa2-14478ecec227@de.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Cornelia Huck Cc: Janosch Frank , KVM , David Hildenbrand , Thomas Huth , Ulrich Weigand , Claudio Imbrenda , Andrea Arcangeli , linux-s390 , Michael Mueller , Vasily Gorbik , Janosch Frank On 10.02.20 14:22, Cornelia Huck wrote: > On Fri, 7 Feb 2020 06:39:54 -0500 > Christian Borntraeger wrote: > >> From: Janosch Frank >> >> Let's have some debug traces which stay around for longer than the >> guest. >> >> Signed-off-by: Janosch Frank >> [borntraeger@de.ibm.com: patch merging, splitting, fixing] >> Signed-off-by: Christian Borntraeger >> --- >> arch/s390/kvm/kvm-s390.c | 9 ++++++++- >> arch/s390/kvm/kvm-s390.h | 9 +++++++++ >> arch/s390/kvm/pv.c | 20 +++++++++++++++++++- >> 3 files changed, 36 insertions(+), 2 deletions(-) > (...) >> diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c >> index a58f5106ba5f..da281d8dcc92 100644 >> --- a/arch/s390/kvm/pv.c >> +++ b/arch/s390/kvm/pv.c >> @@ -74,6 +74,8 @@ int kvm_s390_pv_destroy_vm(struct kvm *kvm) >> atomic_set(&kvm->mm->context.is_protected, 0); >> VM_EVENT(kvm, 3, "PROTVIRT DESTROY VM: rc %x rrc %x", >> ret >> 16, ret & 0x0000ffff); >> + KVM_UV_EVENT(kvm, 3, "PROTVIRT DESTROY VM: rc %x rrc %x", >> + ret >> 16, ret & 0x0000ffff); >> return rc; >> } >> >> @@ -89,6 +91,8 @@ int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu) >> >> VCPU_EVENT(vcpu, 3, "PROTVIRT DESTROY VCPU: cpu %d rc %x rrc %x", >> vcpu->vcpu_id, ret >> 16, ret & 0x0000ffff); > > I think these should drop the vcpu_id, as VCPU_EVENT already includes > it (in the patch introducing them). ack, this is patch 8. > >> + KVM_UV_EVENT(vcpu->kvm, 3, "PROTVIRT DESTROY VCPU: cpu %d rc %x rrc %x", >> + vcpu->vcpu_id, ret >> 16, ret & 0x0000ffff); >> } >> >> free_pages(vcpu->arch.pv.stor_base, > > Otherwise, looks good. > > Reviewed-by: Cornelia Huck >