From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB4AC64E8A for ; Wed, 2 Dec 2020 12:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC29F221FE for ; Wed, 2 Dec 2020 12:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729887AbgLBMRz (ORCPT ); Wed, 2 Dec 2020 07:17:55 -0500 Received: from foss.arm.com ([217.140.110.172]:37870 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgLBMRz (ORCPT ); Wed, 2 Dec 2020 07:17:55 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6641101E; Wed, 2 Dec 2020 04:17:09 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1D823F718; Wed, 2 Dec 2020 04:17:06 -0800 (PST) Subject: Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() To: David Hildenbrand , linux-mm@kvack.org, akpm@linux-foundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Ard Biesheuvel , Mark Rutland References: <1606706992-26656-1-git-send-email-anshuman.khandual@arm.com> <1606706992-26656-3-git-send-email-anshuman.khandual@arm.com> <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> From: Anshuman Khandual Message-ID: <85975346-d5ae-d971-e50f-9c0b77649910@arm.com> Date: Wed, 2 Dec 2020 17:47:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/2/20 2:56 PM, David Hildenbrand wrote: > On 30.11.20 04:29, Anshuman Khandual wrote: >> This overrides arch_get_mappable_range() on arm64 platform which will be >> used with recently added generic framework. It drops inside_linear_region() >> and subsequent check in arch_add_memory() which are no longer required. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Ard Biesheuvel >> Cc: Mark Rutland >> Cc: David Hildenbrand >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> arch/arm64/mm/mmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index ca692a815731..49ec8f2838f2 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1444,16 +1444,19 @@ static void __remove_pgd_mapping(pgd_t *pgdir, unsigned long start, u64 size) >> free_empty_tables(start, end, PAGE_OFFSET, PAGE_END); >> } >> >> -static bool inside_linear_region(u64 start, u64 size) >> +struct range arch_get_mappable_range(void) >> { >> + struct range memhp_range; >> + >> /* >> * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)] >> * accommodating both its ends but excluding PAGE_END. Max physical >> * range which can be mapped inside this linear mapping range, must >> * also be derived from its end points. >> */ >> - return start >= __pa(_PAGE_OFFSET(vabits_actual)) && >> - (start + size - 1) <= __pa(PAGE_END - 1); >> + memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual)); >> + memhp_range.end = __pa(PAGE_END - 1); >> + return memhp_range; >> } >> >> int arch_add_memory(int nid, u64 start, u64 size, >> @@ -1461,11 +1464,6 @@ int arch_add_memory(int nid, u64 start, u64 size, >> { >> int ret, flags = 0; >> >> - if (!inside_linear_region(start, size)) { >> - pr_err("[%llx %llx] is outside linear mapping region\n", start, start + size); >> - return -EINVAL; >> - } > As discussed, I think something like a VM_BUG_ON() here might makes > sense, indicating that we require the caller to validate upfront. Same > applies to the s390x variant. Sure, will do. > > Thanks! > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E6C2C64E8A for ; Wed, 2 Dec 2020 12:18:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AE1D221FE for ; Wed, 2 Dec 2020 12:18:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AE1D221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m+b/Ywh3WuqKp+ensZ62Ok1o4Ze4M0qDxwwFaPIxAFE=; b=wALrwWvIWMhQVP6nYkgnfsy8Y uVBkd2RW8MGJ8KxIiUKnpIL2fPaqifvkEOVGw32gDQ0kbvJinLO+W3jNZCiUdkmUS1+r5zDzmOBZe kkxioBiXj0p2DFRq9DeRH4l4maY9sZ59Y55akh7OOxZvKllWcOOR4f7yfv47UMQNqC71y+RkcZ2cd zlR26B1FD1EcQVuSkGr65XBbo5PNW/1EWyQTUquRelor07CvmqcDaLSxr72niwaqvRtNJ9AOP8/IM XGQiRxJhlRQzaRdT2HAuIn1HTnkjBa1rVQuCGnTBkYxTINF01xnaWrfRZyZ7VMjeNAqYLI3iV3HyL 8i7ru4Bkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkR4Q-0004Of-KA; Wed, 02 Dec 2020 12:17:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkR4I-0004L4-SX for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:17:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6641101E; Wed, 2 Dec 2020 04:17:09 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1D823F718; Wed, 2 Dec 2020 04:17:06 -0800 (PST) Subject: Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() To: David Hildenbrand , linux-mm@kvack.org, akpm@linux-foundation.org References: <1606706992-26656-1-git-send-email-anshuman.khandual@arm.com> <1606706992-26656-3-git-send-email-anshuman.khandual@arm.com> <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> From: Anshuman Khandual Message-ID: <85975346-d5ae-d971-e50f-9c0b77649910@arm.com> Date: Wed, 2 Dec 2020 17:47:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_071711_101611_15FF8083 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-s390@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/2/20 2:56 PM, David Hildenbrand wrote: > On 30.11.20 04:29, Anshuman Khandual wrote: >> This overrides arch_get_mappable_range() on arm64 platform which will be >> used with recently added generic framework. It drops inside_linear_region() >> and subsequent check in arch_add_memory() which are no longer required. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Ard Biesheuvel >> Cc: Mark Rutland >> Cc: David Hildenbrand >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> arch/arm64/mm/mmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index ca692a815731..49ec8f2838f2 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1444,16 +1444,19 @@ static void __remove_pgd_mapping(pgd_t *pgdir, unsigned long start, u64 size) >> free_empty_tables(start, end, PAGE_OFFSET, PAGE_END); >> } >> >> -static bool inside_linear_region(u64 start, u64 size) >> +struct range arch_get_mappable_range(void) >> { >> + struct range memhp_range; >> + >> /* >> * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)] >> * accommodating both its ends but excluding PAGE_END. Max physical >> * range which can be mapped inside this linear mapping range, must >> * also be derived from its end points. >> */ >> - return start >= __pa(_PAGE_OFFSET(vabits_actual)) && >> - (start + size - 1) <= __pa(PAGE_END - 1); >> + memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual)); >> + memhp_range.end = __pa(PAGE_END - 1); >> + return memhp_range; >> } >> >> int arch_add_memory(int nid, u64 start, u64 size, >> @@ -1461,11 +1464,6 @@ int arch_add_memory(int nid, u64 start, u64 size, >> { >> int ret, flags = 0; >> >> - if (!inside_linear_region(start, size)) { >> - pr_err("[%llx %llx] is outside linear mapping region\n", start, start + size); >> - return -EINVAL; >> - } > As discussed, I think something like a VM_BUG_ON() here might makes > sense, indicating that we require the caller to validate upfront. Same > applies to the s390x variant. Sure, will do. > > Thanks! > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel