From: Lars-Peter Clausen <lars@metafoo.de>
To: Mike Looijmans <mike.looijmans@topic.nl>, linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jic23@kernel.org, linux@roeck-us.net
Subject: Re: [PATCH] iio: Add LTC2471/LTC2473 driver
Date: Fri, 30 Jun 2017 16:11:14 +0200 [thread overview]
Message-ID: <859a730d-1970-8b03-06ee-64ec6da876a6@metafoo.de> (raw)
In-Reply-To: <1498807267-946-1-git-send-email-mike.looijmans@topic.nl>
On 06/30/2017 09:21 AM, Mike Looijmans wrote:
> The LTC2741 and LTC2473 are single voltage ADC chips. The LTC2473
> is similar to the LTC2471 but outputs a signed differential value.
>
> Datasheet:
> http://cds.linear.com/docs/en/datasheet/24713fb.pdf
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Looks good, thanks!
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Just two tiny nitpicks inline.
> +static const struct iio_chan_spec ltc2471_channel[] = {
> + {
> + .type = IIO_VOLTAGE,
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),
> + .differential = 0,
> + },
> +};
There should be a newline here.
> +static const struct iio_chan_spec ltc2473_channel[] = {
> + {
> + .type = IIO_VOLTAGE,
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
> + BIT(IIO_CHAN_INFO_OFFSET),
> + .differential = 1,
> + },
> +};
> [...]
> +static int ltc2471_i2c_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
> [...]
> + data = iio_priv(indio_dev);
> + i2c_set_clientdata(client, indio_dev);
You don't need this since i2c_get_clientdata() is never used.
> + data->client = client;
> +
next prev parent reply other threads:[~2017-06-30 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 7:21 [PATCH] iio: Add LTC2471/LTC2473 driver Mike Looijmans
2017-06-30 14:11 ` Lars-Peter Clausen [this message]
2017-07-01 9:30 ` Jonathan Cameron
2017-07-02 8:29 ` Peter Meerwald-Stadler
2017-07-02 9:25 ` Jonathan Cameron
2017-07-02 11:24 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=859a730d-1970-8b03-06ee-64ec6da876a6@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.