From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org, Tom Barbette <barbette@kth.se>,
Yongseok Koh <yskoh@mellanox.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] mk: fix scope of disabling AVX512F support
Date: Wed, 19 Dec 2018 20:53:34 +0000 [thread overview]
Message-ID: <859da395-a0fd-2231-6d07-b20a0146ff15@intel.com> (raw)
In-Reply-To: <1618982.fK5yx7iQXf@xps>
On 12/19/2018 8:28 PM, Thomas Monjalon wrote:
> 19/12/2018 21:20, Ferruh Yigit:
>> On 12/19/2018 7:58 PM, Thomas Monjalon wrote:
>>> 19/12/2018 20:29, Ferruh Yigit:
>>>> AVX512 was disabled for GCC because of Bugzilla issue 97 [1],
>>>> the GCC defect submitted for the issue [2] highlighted that this is
>>>> a known binutils version 2.30 issue.
>>>>
>>>> Narrowed the scope of no-avx512 to the this specific binutils version.
>>> [...]
>>>> # disable AVX512F support of gcc as a workaround for Bug 97
>>>> ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
>>>> +ifneq ($(filter 2.30%,$(LD_VERSION)),)
>>>> MACHINE_CFLAGS += -mno-avx512f
>>>
>>> I think we should print a warning here.
>>> There is a function $(warning) or $(info) for such case.
>>
>> I can add but it prints warning per component, so it prints a lot.
>
> I think we can choose to print only when compiling EAL
> by checking $(findstring eal,$(lastword $(MAKEFILE_LIST)))
Thanks for hint, I will use it.
>
> One more comment: it would be good to have this fix with meson too.
Agreed, only I am not quite sure how to fix it in meson.
next prev parent reply other threads:[~2018-12-19 20:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 19:29 [PATCH] mk: fix scope of disabling AVX512F support Ferruh Yigit
2018-12-19 19:58 ` Thomas Monjalon
2018-12-19 20:20 ` Ferruh Yigit
2018-12-19 20:28 ` Thomas Monjalon
2018-12-19 20:53 ` Ferruh Yigit [this message]
2018-12-20 11:29 ` Bruce Richardson
2018-12-19 21:00 ` [PATCH v2] " Ferruh Yigit
2018-12-22 23:02 ` Thomas Monjalon
2019-01-03 16:23 ` [PATCH v3] " Ferruh Yigit
2019-01-03 22:46 ` Yongseok Koh
2019-01-04 2:40 ` Varghese, Vipin
2019-01-04 10:27 ` Ferruh Yigit
2019-01-04 10:28 ` Varghese, Vipin
2019-01-07 16:49 ` [PATCH v4] " Ferruh Yigit
2019-01-08 3:50 ` Varghese, Vipin
2019-01-14 11:55 ` Thomas Monjalon
2019-01-14 15:49 ` [PATCH v5] " Ferruh Yigit
2019-01-14 16:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=859da395-a0fd-2231-6d07-b20a0146ff15@intel.com \
--to=ferruh.yigit@intel.com \
--cc=barbette@kth.se \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.