Re: [RFC 01/10] ASoC: Intel: Boards: Machine driver for Intel platforms

["Ughreja, Rakesh A" <rakesh.a.ughreja@intel.com>]

>-----Original Message-----
>From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com]
>Sent: Thursday, December 7, 2017 6:36 PM
>To: Ughreja, Rakesh A <rakesh.a.ughreja@intel.com>; Koul, Vinod
><vinod.koul@intel.com>
>Cc: alsa-devel@alsa-project.org; broonie@kernel.org; tiwai@suse.de;
>liam.r.girdwood@linux.intel.com; Patches Audio <patches.audio@intel.com>
>Subject: Re: [alsa-devel] [RFC 01/10] ASoC: Intel: Boards: Machine driver for Intel
>platforms
>
>On 12/7/17 6:27 AM, Ughreja, Rakesh A wrote:
>>
>>
>>> -----Original Message-----
>>> From: Koul, Vinod
>>> Sent: Wednesday, December 6, 2017 9:48 PM
>>> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>> Cc: Ughreja, Rakesh A <rakesh.a.ughreja@intel.com>; alsa-devel@alsa-
>project.org;
>>> broonie@kernel.org; tiwai@suse.de; liam.r.girdwood@linux.intel.com; Patches
>>> Audio <patches.audio@intel.com>
>>> Subject: Re: [alsa-devel] [RFC 01/10] ASoC: Intel: Boards: Machine driver for
>Intel
>>> platforms
>>>
>>> On Mon, Dec 04, 2017 at 09:37:37AM -0600, Pierre-Louis Bossart wrote:
>>>> On 12/4/17 9:10 AM, Ughreja, Rakesh A wrote:
>>>
>>>>>>>>>     sound/soc/intel/boards/Kconfig           |  10 ++
>>>>>>>>>     sound/soc/intel/boards/Makefile          |   2 +
>>>>>>>>>     sound/soc/intel/boards/skl_hda_generic.c | 276
>>>>>>>> +++++++++++++++++++++++++++++++
>>>>>>>>
>>>>>>>> can we drop the Skylake reference? It's become a catch-all term to
>mean
>>>>>>>> both the platform, the IP and the driver.
>>>>>>>
>>>>>>> Suggest some name. I have no problem.
>>>>>>
>>>>>> HiFi3 ?
>>>>>> iDisp ?
>>>>>> HDAudio-DSP ?
>>>>>
>>>>> hda_dsp_generic.c -- For the main file
>>>>> hda_dsp_common.c -- for common functions
>>>>>
>>>>> Does it look fine ?
>>>>
>>>> works for me.
>>>
>>> Sorry not for me. hda_dsp_xxx doesnt tie it to anything. HDA and DSP are too
>>> generic terms. But yes I don't have a better alternate than skl_generic.
>>> Here this solution is tied to a very specfic IP which is present in SKL
>>> onwards platforms..
>>>
>>> Yes SKL is become an IP as well as platform. Maybe we should have a
>codename
>>> for this like azx :)
>>
>> We do have a code name "sst".
>>
>> So does this sound okay for you ?
>>
>> sst_hda_dsp_generic.c -- For main file
>> sst_hda_dsp_common.c -- for common functions
>
>SST is also aliased to platform drivers with closed-source firmware, not
>a good idea for machine drivers.

Then I have to go back to skl_hda_dsp_generic.c and 
skl_hda_dsp_common.c as Vinod suggested.

Regards,
Rakesh