From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
Roger Pau Monne <roger.pau@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>
Subject: Re: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests
Date: Mon, 18 Jul 2022 05:42:22 +0000 [thread overview]
Message-ID: <85FA3236-5BDA-4387-AEE1-A97D139353EE@citrix.com> (raw)
In-Reply-To: <64ff8cc6-6c15-7255-e908-36d7bbbd6348@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]
> On 27 Jun 2022, at 16:33, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 24.06.2022 21:27, George Dunlap wrote:
>>
>>
>>> On 9 Dec 2021, at 11:27, Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> For guests in shadow mode the P2M table gets used only by software. The
>>> only place where it matters whether superpages in the P2M can be dealt
>>> with is sh_unshadow_for_p2m_change().
>>
>> It’s easy to verify that this patch is doing what it claims to do; but whether it’s correct or not depends on the veracity of this claim here. Rather than me having to duplicate whatever work you did to come to this conclusion, can you briefly explain why it’s true in a way that I can easily verify?
>
> Would
>
> "The table is never made accessible by hardware for address translation,
> and the only checks of _PAGE_PSE in P2M entries in shadow code are in
> this function (all others are against guest page table entries)."
>
> look sufficient to you?
Sorry for the delay responding to this — yes, I think this would do, thanks.
-George
[-- Attachment #1.2: Type: text/html, Size: 7640 bytes --]
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-18 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 11:25 [PATCH 0/2] x86/P2M: allow 2M superpage use for shadowed guests Jan Beulich
2021-12-09 11:26 ` [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() Jan Beulich
2022-06-24 19:16 ` George Dunlap
2022-06-27 6:26 ` Jan Beulich
2021-12-09 11:27 ` [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests Jan Beulich
2022-06-24 19:27 ` George Dunlap
2022-06-27 6:33 ` Jan Beulich
2022-07-18 5:42 ` George Dunlap [this message]
2022-06-23 12:00 ` Ping: [PATCH 0/2] " Jan Beulich
2022-06-23 12:28 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85FA3236-5BDA-4387-AEE1-A97D139353EE@citrix.com \
--to=george.dunlap@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.