From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v2] bpf: fix check of allowed specifiers in bpf_trace_printk Date: Fri, 23 Nov 2018 21:57:48 +0100 Message-ID: <85a08645-453b-78ad-e401-55d2894fa64a@iogearbox.net> References: <20181123164326.28127-1-m@lambda.lt> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: ast@kernel.org To: Martynas Pumputis , netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:33550 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbeKXHnm (ORCPT ); Sat, 24 Nov 2018 02:43:42 -0500 In-Reply-To: <20181123164326.28127-1-m@lambda.lt> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/23/2018 05:43 PM, Martynas Pumputis wrote: > A format string consisting of "%p" or "%s" followed by an invalid > specifier (e.g. "%p%\n" or "%s%") could pass the check which > would make format_decode (lib/vsprintf.c) to warn. > > Reported-by: syzbot+1ec5c5ec949c4adaa0c4@syzkaller.appspotmail.com > Signed-off-by: Martynas Pumputis Applied to bpf, thanks!