All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gcov: support GCC 7.1
Date: Wed, 9 Nov 2016 10:21:29 +0100	[thread overview]
Message-ID: <85a7ed9a-4915-49d9-f17b-888b838107c6@linux.vnet.ibm.com> (raw)
In-Reply-To: <8c4084fa-3885-29fe-5fc4-0d4ca199c785@suse.cz>

On 31.10.2016 10:35, Martin Liška wrote:
> Starting from GCC 7.1, __gcov_exit is a new symbol expected
> to be implemented in a profiling runtime.

I tested your patch with kernel 4.9-rc4 compiled with GCC 7.0.0 20161107
(experimental) and validated that it fixes the build error due to a
missing __gcov_exit symbol.

An attempt to read from one of the .gcda files generated by a kernel
compiled this way resulted in a crash though. It appears that the number
of GCOV_COUNTERS has changed again for GCC 7.x and must be adjusted in
the kernel as well. Could you add that to your patch as well?

Given that GCC 7.1 has not yet been released, I'm wondering if it is
safe to program against interfaces that have not yet been fully
finalized. Can you provide an indication on whether these gcov-related
aspects of GCC might still be changed until release?

As a side note, please post your patches inline instead of as attachment
as that helps quoting them in replies. See also
linux/Documentation/SubmittingPatches.

-- 
Peter Oberparleiter
Linux on z Systems Development - IBM Germany

  reply	other threads:[~2016-11-09  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31  9:35 [PATCH] gcov: support GCC 7.1 Martin Liška
2016-11-09  9:21 ` Peter Oberparleiter [this message]
2016-11-24 12:46   ` Martin Liška
2016-12-08 12:52     ` Peter Oberparleiter
2017-05-08 10:54       ` Peter Oberparleiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85a7ed9a-4915-49d9-f17b-888b838107c6@linux.vnet.ibm.com \
    --to=oberpar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.