From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbeAZQ07 (ORCPT ); Fri, 26 Jan 2018 11:26:59 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36972 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752931AbeAZQ0Z (ORCPT ); Fri, 26 Jan 2018 11:26:25 -0500 Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , linux-s390 , Linux Fbdev development list , Martin Schwidefsky , Christian Borntraeger , Stefan Kristiansson , Tomi Valkeinen References: <19306e74-7c9b-5644-6f08-bbaef226afd8@linux.vnet.ibm.com> From: Farhan Ali Date: Fri, 26 Jan 2018 11:26:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18012616-0036-0000-0000-000002B4104B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008432; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000248; SDB=6.00980694; UDB=6.00497169; IPR=6.00759995; BA=6.00005797; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019227; XFM=3.00000015; UTC=2018-01-26 16:26:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012616-0037-0000-0000-00004320F84A Message-Id: <85ab024b-6af2-8b58-f9e8-7920d132cefb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-26_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801260215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2018 10:06 AM, Geert Uytterhoeven wrote: >> Hi Geert, >> >> I wasn't sure what would be the best ordering since we would never hit the >> issue if patch 1 didn't exist. But if the preference is to invert the >> ordering of patches, then I will change the ordering. > Alternatively, you can combine two patches into a single patch, which > moves the dependency from the whole subsystem to the driver that needs > it (are there more?). > > Gr{oetje,eeting}s, > > Geert I like the idea of combining both patches into one. There are other fbdev drivers that use iomem (found by grepping for "devm_ioremap_resource"): CONFIG_FB_S3C (s3c-fb.c) CONFIG_FB_CLPS711X (clps711x-fb.c) CONFIG_FB_JZ4740 (jz4740_fb.c) CONFIG_FB_DA8XX (da8xx-fb.c) CONFIG_FB_WM8505 (wm8505fb.c) CONFIG_OMAP2_VRFB (omap2/omapfb/vrfb.c) CONFIG_FB_OMAP2 (omap2/omapfb/dss/* CONFIG_FB_MXS (mxsfb.c) CONFIG_PXA3XX_GCU (pxa3xx-gcu.c) CONFIG_FB_XILINX (xilinxfb.c) All of these are already fenced off by architecture dependencies (which I am assuming enables CONFIG_HAS_IOMEM by default). If we want to be cautious I can add HAS_IOMEM dependency for all of them. Thanks Farhan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Farhan Ali Date: Fri, 26 Jan 2018 16:26:19 +0000 Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 Message-Id: <85ab024b-6af2-8b58-f9e8-7920d132cefb@linux.vnet.ibm.com> References: <19306e74-7c9b-5644-6f08-bbaef226afd8@linux.vnet.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Archive: List-Post: To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , linux-s390 , Linux Fbdev development list , Martin Schwidefsky , Christian Borntraeger , Stefan Kristiansson , Tomi Valkeinen List-ID: On 01/26/2018 10:06 AM, Geert Uytterhoeven wrote: >> Hi Geert, >> >> I wasn't sure what would be the best ordering since we would never hit the >> issue if patch 1 didn't exist. But if the preference is to invert the >> ordering of patches, then I will change the ordering. > Alternatively, you can combine two patches into a single patch, which > moves the dependency from the whole subsystem to the driver that needs > it (are there more?). > > Gr{oetje,eeting}s, > > Geert I like the idea of combining both patches into one. There are other fbdev drivers that use iomem (found by grepping for "devm_ioremap_resource"): CONFIG_FB_S3C (s3c-fb.c) CONFIG_FB_CLPS711X (clps711x-fb.c) CONFIG_FB_JZ4740 (jz4740_fb.c) CONFIG_FB_DA8XX (da8xx-fb.c) CONFIG_FB_WM8505 (wm8505fb.c) CONFIG_OMAP2_VRFB (omap2/omapfb/vrfb.c) CONFIG_FB_OMAP2 (omap2/omapfb/dss/* CONFIG_FB_MXS (mxsfb.c) CONFIG_PXA3XX_GCU (pxa3xx-gcu.c) CONFIG_FB_XILINX (xilinxfb.c) All of these are already fenced off by architecture dependencies (which I am assuming enables CONFIG_HAS_IOMEM by default). If we want to be cautious I can add HAS_IOMEM dependency for all of them. Thanks Farhan