From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D696FC43387 for ; Wed, 2 Jan 2019 17:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2F8921900 for ; Wed, 2 Jan 2019 17:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726778AbfABRtC (ORCPT ); Wed, 2 Jan 2019 12:49:02 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:48252 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfABRtC (ORCPT ); Wed, 2 Jan 2019 12:49:02 -0500 Received: from office.codethink.co.uk ([148.252.241.226] helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gekdY-0006hf-4S; Wed, 02 Jan 2019 17:49:00 +0000 Received: from ben by deadeye with local (Exim 4.91) (envelope-from ) id 1gekdX-0003rK-MQ; Wed, 02 Jan 2019 17:48:59 +0000 Message-ID: <85abc221b4990ca5590e57e46ef941df0db06502.camel@decadent.org.uk> Subject: Re: [PATCH stable 3.9 to 3.16] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write() From: Ben Hutchings To: Ian Abbott , stable@vger.kernel.org Cc: Greg Kroah-Hartman , Dan Carpenter , H Hartley Sweeten Date: Wed, 02 Jan 2019 17:48:59 +0000 In-Reply-To: <7f067209-86a6-e063-390e-f2d2ff0b1fca@mev.co.uk> References: <20180710170226.23969-1-abbotti@mev.co.uk> <7f067209-86a6-e063-390e-f2d2ff0b1fca@mev.co.uk> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-28UNy4Yk5eym8WkhSLgl" User-Agent: Evolution 3.30.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 148.252.241.226 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --=-28UNy4Yk5eym8WkhSLgl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2018-11-12 at 11:56 +0000, Ian Abbott wrote: > On 09/11/18 23:44, Ben Hutchings wrote: > > On Tue, 2018-07-10 at 18:02 +0100, Ian Abbott wrote: > > > From: Dan Carpenter > > >=20 > > > [ Upstream commit 1376b0a2160319125c3a2822e8c09bd283cd8141 ] > > >=20 > > > There is a '>' vs '<' typo so this loop is a no-op. > >=20 > > Thanks, but this driver seems to have lots of other bugs in 3.16, like > > it only ever accesses data[0] in this loop. I don't think there's much > > point in applying just this one. But if you think it's worth fixing > > then I can apply all the necessary fixes. > >=20 > > Ben. >=20 > It restores some basic functionality for daqp_ao_insn_write() that was= =20 > broken. The most common case to be handled is insn->n =3D=3D 1, as that = is=20 > what the comedi_data_write() function in the user-space Comedilib=20 > library sets. >=20 > However, it may be worth applying e024181b02ed ("staging: comedi:=20 > quatech_daqp_cs: fix bug in daqp_ao_insn_write()") and (with a small=20 > amount of backporting) e031642eccc0 ("staging: comedi: quatech_daqp_cs:= =20 > use comedi_timeout() in ao (*insn_write)") before this one. I'll append= =20 > a patch series as replies to this email. I've queued these up for the next update, thanks. Ben. --=20 Ben Hutchings Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer --=-28UNy4Yk5eym8WkhSLgl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlws+YsACgkQ57/I7JWG EQk9MQ//YZbxS227uaxBoViL3cLmSMh+um6H2zf/XceM9dwQpNtYaFFewbo+GgCU 2HypHEtEfrH7Lp93QkdK6bBD45H+fLH2Tr6fAgcfuhBoPhYajcmVHzGgG+ljDYGZ BuUWO4lS04ctP3cwKUbwbe7AClwbYa8LW0IOmIyvGHy3ad2+HXEixqoobnvVAqnx aAGDijKGkngDAjB/8iKxa0+zNyOpD8MGfkA4ILV2UWYa1ZkW+6qsIlMDBXojh20I POEI5OLPzH0bZhvzPTH97aY+Hh+8yLjifzQpngpubsSsmJ2fxWMia/7F0UgI+wZR qeZOzTSgD6L74xvrZtjHNM3WFaXknyK7IbuNqksF68Jpd8lGXKGL8O3zEkyPVrYh ceiTw6K50tMTsofRTbgSIGGqxUDKa2zRJyzYa0OJTNoYZtYXy/UHQ8jAemJWOfvO D7xtgEEQ0Wh3mZ2Pbzd9aY8EzRMRHApL4c/8aPUjtHEsNLOm1zzXukXLEc65AfNu 5uMDvNCKHQOAl/NeqKfM1QIUTVSlfSkkABC011eqkA+KQSXEo+7YQrWigIXTXfCu 3YJlC8XEkZQ/cvYPjclbficCNTstsmECNlJFjOcvuQBL3S8dv9EKLvx2zE2pn5ou 6efUIdLk19TN7LxXFT/3LP5/RUxEvDHK/wE++5DztYs+4oX36EY= =BwMU -----END PGP SIGNATURE----- --=-28UNy4Yk5eym8WkhSLgl--