Re: [Buildroot] [PATCH 3/3] package/gstreamer1/gst1-imx2: new package

["Sébastien Szymanski" <sebastien.szymanski@armadeus.com>]

Hi Arnout,

On 7/28/22 21:51, Arnout Vandecappelle wrote:
> 
> 
> On 12/01/2022 10:42, Sébastien Szymanski wrote:
>> This is version 2 of gst1-imx.
> 
>   Please add the following.
> 
>   Although this replaces the gst1-imx package, we want to keep both 
> because version 2 removes some elements that are relevant on i.MX6 
> without X11 or wayland: imxg2dvideosink, imxipuvideosink, imxeglvivsink.
> 
> 
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>> ---
>>   package/gstreamer1/Config.in                |  1 +
>>   package/gstreamer1/gst1-imx2/Config.in      | 75 +++++++++++++++++++++
>>   package/gstreamer1/gst1-imx2/gst1-imx2.hash |  3 +
>>   package/gstreamer1/gst1-imx2/gst1-imx2.mk   | 75 +++++++++++++++++++++
>>   4 files changed, 154 insertions(+)
>>   create mode 100644 package/gstreamer1/gst1-imx2/Config.in
>>   create mode 100644 package/gstreamer1/gst1-imx2/gst1-imx2.hash
>>   create mode 100644 package/gstreamer1/gst1-imx2/gst1-imx2.mk
>>
>> diff --git a/package/gstreamer1/Config.in b/package/gstreamer1/Config.in
>> index 8fe8a34395..436c76379d 100644
>> --- a/package/gstreamer1/Config.in
>> +++ b/package/gstreamer1/Config.in
>> @@ -9,6 +9,7 @@ source "package/gstreamer1/gst1-plugins-bad/Config.in"
>>   source "package/gstreamer1/gst1-plugins-ugly/Config.in"
>>   source "package/gstreamer1/gst1-devtools/Config.in"
>>   source "package/gstreamer1/gst1-imx/Config.in"
>> +source "package/gstreamer1/gst1-imx2/Config.in"
> 
>   Note that this one should *not* move to package/freescale-imx, it's 
> correct to put it here in gstreamer1.
> 
>>   source "package/gstreamer1/gst1-interpipe/Config.in"
>>   source "package/gstreamer1/gst1-libav/Config.in"
>>   source "package/gstreamer1/gst1-python/Config.in"
>> diff --git a/package/gstreamer1/gst1-imx2/Config.in 
>> b/package/gstreamer1/gst1-imx2/Config.in
>> new file mode 100644
>> index 0000000000..b95e6bdb21
>> --- /dev/null
>> +++ b/package/gstreamer1/gst1-imx2/Config.in
>> @@ -0,0 +1,75 @@
>> +menuconfig BR2_PACKAGE_GST1_IMX2
>> +    bool "gst1-imx2"
>> +    depends on BR2_arm || BR2_aarch64 # Only relevant for i.MX
>> +    depends on BR2_PACKAGE_LIBIMXDMABUFFER
> 
>   This should be a select.
> 
>   On the other hand, it should also have
> 
>      depends on BR2_PACKAGE_FREESCALE_IMX
> 
>> +    select BR2_PACKAGE_GST1_PLUGINS_BASE
>> +    help
>> +      This is a set of GStreamer 1.0 plugins for plugins for
>> +      Freescale's i.MX platforms, which make use of the i.MX
>> +      multimedia capabilities.
>> +
>> +      https://github.com/Freescale/gstreamer-imx
>> +
>> +if BR2_PACKAGE_GST1_IMX2
>> +
>> +config BR2_PACKAGE_GST1_IMX2_G2D
>> +    bool "imxg2d"
>> +    depends on BR2_PACKAGE_IMX_GPU_G2D
> 
>   All these depends on should also be turned in select, and propagate 
> their dependencies. Since the dependencies are all architecture 
> dependencies, I think, there's no need for a comment. You only need a 
> comment for the linux dependency.

I have copied the gst1-imx package which uses depends on. When using 
select the following issue appears:

package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency 
detected!
package/gstreamer1/gstreamer1/Config.in:5:      symbol 
BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
package/webkitgtk/Config.in:94: symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDIA 
depends on BR2_PACKAGE_WEBKITGTK
package/webkitgtk/Config.in:28: symbol BR2_PACKAGE_WEBKITGTK is selected 
by BR2_PACKAGE_MIDORI
package/midori/Config.in:24:    symbol BR2_PACKAGE_MIDORI depends on 
BR2_PACKAGE_LIBGTK3
package/libgtk3/Config.in:15:   symbol BR2_PACKAGE_LIBGTK3 is selected 
by BR2_PACKAGE_VTE
package/vte/Config.in:1:        symbol BR2_PACKAGE_VTE depends on 
BR2_PACKAGE_HAS_LIBEGL_WAYLAND
package/opengl/libegl/Config.in:4:      symbol 
BR2_PACKAGE_HAS_LIBEGL_WAYLAND is selected by 
BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL
package/freescale-imx/imx-gpu-viv/Config.in:64: symbol 
BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL is part of choice <choice>
package/freescale-imx/imx-gpu-viv/Config.in:39: choice <choice> contains 
symbol <choice>
package/freescale-imx/imx-gpu-viv/Config.in:39: choice <choice> contains 
symbol BR2_PACKAGE_IMX_GPU_VIV
package/freescale-imx/imx-gpu-viv/Config.in:9:  symbol 
BR2_PACKAGE_IMX_GPU_VIV is selected by BR2_PACKAGE_IMX_GPU_G2D
package/freescale-imx/imx-gpu-g2d/Config.in:9:  symbol 
BR2_PACKAGE_IMX_GPU_G2D is selected by BR2_PACKAGE_GST1_IMX2_G2D
package/gstreamer1/gst1-imx2/Config.in:21:      symbol 
BR2_PACKAGE_GST1_IMX2_G2D depends on BR2_PACKAGE_GSTREAMER1
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"

There was a similar issue for gst1-imx:

https://lore.kernel.org/all/20160920224355.l76a3kggupuiugok@t450s.lan/

So, I will keep depends on here.

Regards,


-- 
Sébastien Szymanski, Armadeus Systems
Software engineer
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot