All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: wujek dev <dev_public@wujek.eu>
Cc: Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) add missing definitions of pmbus registers
Date: Thu, 28 Apr 2022 22:38:17 -0700	[thread overview]
Message-ID: <85bb3cde-2b62-c15a-46f6-251eb06daeb1@roeck-us.net> (raw)
In-Reply-To: <hGgSY5dLHFlYeXpEkcTTRThFR76Eevb391giqk_CiNorL3WfRpH44if4pfaOu1jMc2GuB0T51wfbHj0Aiawd28p6HvuWN9t1bzY2S_D1_fM=@wujek.eu>

On 4/28/22 18:04, wujek dev wrote:
> 
>>
>>
>> On 4/28/22 06:46, Adam Wujek wrote:
>>
>>> Definitions are taken from the table 31 of the PMBUS specification
>>> revision 1.3.1, 13 March 2015.
>>
>>
>> Do you plan to do anything with those registers, or a subset of it ?
> yes, some of PMBUS_MFR_SPECIFIC_*, but in a driver that will not be published in the near future.
> 

Adding defines just to add defines without using them only increases
source code size and compile time. Let's not do that. We can add
missing defines as they are needed.

Guenter

      reply	other threads:[~2022-04-29  5:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 13:46 [PATCH] hwmon: (pmbus) add missing definitions of pmbus registers Adam Wujek
2022-04-28 15:21 ` Guenter Roeck
2022-04-29  1:04   ` wujek dev
2022-04-29  5:38     ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85bb3cde-2b62-c15a-46f6-251eb06daeb1@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=dev_public@wujek.eu \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.