From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A5CC433E0 for ; Mon, 22 Jun 2020 21:27:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 875F62073E for ; Mon, 22 Jun 2020 21:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730460AbgFVV1F (ORCPT ); Mon, 22 Jun 2020 17:27:05 -0400 Received: from www62.your-server.de ([213.133.104.62]:42142 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730430AbgFVV1F (ORCPT ); Mon, 22 Jun 2020 17:27:05 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jnTy2-0005QG-Nh; Mon, 22 Jun 2020 23:27:02 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnTy2-000PVx-FX; Mon, 22 Jun 2020 23:27:02 +0200 Subject: Re: [PATCH bpf] libbpf: forward-declare bpf_stats_type for systems with outdated UAPI headers To: Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com References: <20200621031159.2279101-1-andriin@fb.com> From: Daniel Borkmann Message-ID: <85bd6a92-5230-6b7b-a3de-d166e80913f4@iogearbox.net> Date: Mon, 22 Jun 2020 23:27:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200621031159.2279101-1-andriin@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25851/Mon Jun 22 15:09:36 2020) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 6/21/20 5:11 AM, Andrii Nakryiko wrote: > Systems that doesn't yet have the very latest linux/bpf.h header, enum > bpf_stats_type will be undefined, causing compilation warnings. Prevents this > by forward-declaring enum. > > Fixes: 0bee106716cf ("libbpf: Add support for command BPF_ENABLE_STATS") > Signed-off-by: Andrii Nakryiko Applied, thanks!