From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbcCLSJS (ORCPT ); Sat, 12 Mar 2016 13:09:18 -0500 Received: from mail.kernel.org ([198.145.29.136]:37632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753171AbcCLSJD (ORCPT ); Sat, 12 Mar 2016 13:09:03 -0500 From: Andy Lutomirski To: X86 ML Cc: Paolo Bonzini , Peter Zijlstra , KVM list , Arjan van de Ven , xen-devel , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Borislav Petkov , Andy Lutomirski Subject: [PATCH v4 5/5] x86/msr: Set the return value to zero when native_rdmsr_safe fails Date: Sat, 12 Mar 2016 10:08:52 -0800 Message-Id: <85c0bf533f7845697ee3c0f8833fc249fd221f31.1457805972.git.luto@kernel.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This will cause unchecked native_rdmsr_safe failures to return deterministic results. Signed-off-by: Andy Lutomirski --- arch/x86/include/asm/msr.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h index 13da359881d7..e97e79f8a22b 100644 --- a/arch/x86/include/asm/msr.h +++ b/arch/x86/include/asm/msr.h @@ -109,7 +109,10 @@ static inline unsigned long long native_read_msr_safe(unsigned int msr, asm volatile("2: rdmsr ; xor %[err],%[err]\n" "1:\n\t" ".section .fixup,\"ax\"\n\t" - "3: mov %[fault],%[err] ; jmp 1b\n\t" + "3: mov %[fault],%[err]\n\t" + "xorl %%eax, %%eax\n\t" + "xorl %%edx, %%edx\n\t" + "jmp 1b\n\t" ".previous\n\t" _ASM_EXTABLE(2b, 3b) : [err] "=r" (*err), EAX_EDX_RET(val, low, high) -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: [PATCH v4 5/5] x86/msr: Set the return value to zero when native_rdmsr_safe fails Date: Sat, 12 Mar 2016 10:08:52 -0800 Message-ID: <85c0bf533f7845697ee3c0f8833fc249fd221f31.1457805972.git.luto@kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: KVM list , Peter Zijlstra , Linus Torvalds , "linux-kernel@vger.kernel.org" , xen-devel , Borislav Petkov , Andy Lutomirski , Paolo Bonzini , Andrew Morton , Arjan van de Ven To: X86 ML Return-path: In-Reply-To: In-Reply-To: References: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org VGhpcyB3aWxsIGNhdXNlIHVuY2hlY2tlZCBuYXRpdmVfcmRtc3Jfc2FmZSBmYWlsdXJlcyB0byBy ZXR1cm4KZGV0ZXJtaW5pc3RpYyByZXN1bHRzLgoKU2lnbmVkLW9mZi1ieTogQW5keSBMdXRvbWly c2tpIDxsdXRvQGtlcm5lbC5vcmc+Ci0tLQogYXJjaC94ODYvaW5jbHVkZS9hc20vbXNyLmggfCA1 ICsrKystCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpk aWZmIC0tZ2l0IGEvYXJjaC94ODYvaW5jbHVkZS9hc20vbXNyLmggYi9hcmNoL3g4Ni9pbmNsdWRl L2FzbS9tc3IuaAppbmRleCAxM2RhMzU5ODgxZDcuLmU5N2U3OWY4YTIyYiAxMDA2NDQKLS0tIGEv YXJjaC94ODYvaW5jbHVkZS9hc20vbXNyLmgKKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vbXNy LmgKQEAgLTEwOSw3ICsxMDksMTAgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIGxvbmcg bmF0aXZlX3JlYWRfbXNyX3NhZmUodW5zaWduZWQgaW50IG1zciwKIAlhc20gdm9sYXRpbGUoIjI6 IHJkbXNyIDsgeG9yICVbZXJyXSwlW2Vycl1cbiIKIAkJICAgICAiMTpcblx0IgogCQkgICAgICIu c2VjdGlvbiAuZml4dXAsXCJheFwiXG5cdCIKLQkJICAgICAiMzogIG1vdiAlW2ZhdWx0XSwlW2Vy cl0gOyBqbXAgMWJcblx0IgorCQkgICAgICIzOiBtb3YgJVtmYXVsdF0sJVtlcnJdXG5cdCIKKwkJ ICAgICAieG9ybCAlJWVheCwgJSVlYXhcblx0IgorCQkgICAgICJ4b3JsICUlZWR4LCAlJWVkeFxu XHQiCisJCSAgICAgImptcCAxYlxuXHQiCiAJCSAgICAgIi5wcmV2aW91c1xuXHQiCiAJCSAgICAg X0FTTV9FWFRBQkxFKDJiLCAzYikKIAkJICAgICA6IFtlcnJdICI9ciIgKCplcnIpLCBFQVhfRURY X1JFVCh2YWwsIGxvdywgaGlnaCkKLS0gCjIuNS4wCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK