From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Raspl Subject: Re: [PATCH v1 14/19] tools/kvm_stat: add new interactive command 'h' Date: Tue, 20 Jun 2017 11:10:45 +0200 Message-ID: <85c9f64b-8eba-7708-8887-4bf11b0abc38@linux.vnet.ibm.com> References: <20170607190843.76869-1-raspl@linux.vnet.ibm.com> <20170607190843.76869-15-raspl@linux.vnet.ibm.com> Reply-To: raspl@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com, frankja@linux.vnet.ibm.com To: Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54167 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdFTJK4 (ORCPT ); Tue, 20 Jun 2017 05:10:56 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5K98cAw008149 for ; Tue, 20 Jun 2017 05:10:51 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2b6u1swj5h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 20 Jun 2017 05:10:50 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Jun 2017 10:10:48 +0100 In-Reply-To: Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 08.06.2017 18:19, Paolo Bonzini wrote: > > > On 07/06/2017 21:08, Stefan Raspl wrote: >> + """Display help with list of interactive commands""" >> + msg = (' c clear filter', >> + ' f filter by regular expression', >> + ' g filter by guest name', >> + ' h display interactive commands reference', >> + ' p filter by PID', >> + ' q quit', >> + ' r reset stats', >> + ' x toggle reporting of stats for individual child trace' >> + ' events', >> + 'Any other key refreshes statistics immediately') > >> @@ -1237,10 +1263,11 @@ description_text = """ >> c clear filter >> f filter by regular expression >> g filter by guest name >> + h display interactive commands reference >> p filter by PID >> q quit >> - x toggle reporting of stats for individual child trace events >> r reset stats >> + x toggle reporting of stats for individual child trace events >> Press any other key to refresh statistics immediately. >> """ > > Some duplication here... want to eliminate it as a follow-up patch, by > creating a global string or array for this part of description_text? I was annoyed by this, too. Couldn't figure an obvious way immediately to re-use the string, will give it some more thought. Ciao, Stefan