From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E772C433E0 for ; Mon, 1 Mar 2021 10:41:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F4B164E13 for ; Mon, 1 Mar 2021 10:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234206AbhCAKlT (ORCPT ); Mon, 1 Mar 2021 05:41:19 -0500 Received: from mga01.intel.com ([192.55.52.88]:30058 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbhCAKib (ORCPT ); Mon, 1 Mar 2021 05:38:31 -0500 IronPort-SDR: fk5kOmRKRTwaBC8fX2U9bnclwt99r/R6N4t4xtSg0vzdA8CMfPhEWHiiZ0xpOEFI6caU2HXe/8 gIRXtCXetDYg== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="206026612" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="206026612" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 02:36:45 -0800 IronPort-SDR: 4Ic0AvbGoMFVDN83zbyg91KXTaFhUAvBKkobvKwwrg7oQiljIpGcNd6CJEfKGDbrFwIzwODY76 oEWe3tq34KOw== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="383003039" Received: from gna-dev.igk.intel.com (HELO localhost) ([10.102.80.34]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 02:36:43 -0800 References: <20210216160525.5028-1-maciej.kwapulinski@linux.intel.com> <20210216160525.5028-2-maciej.kwapulinski@linux.intel.com> <85ft1fjhws.fsf@linux.intel.com> User-agent: mu4e 1.4.13; emacs 26.3 From: Maciej Kwapulinski To: Greg Kroah-Hartman Cc: Andy Shevchenko , Arnd Bergmann , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Linux Kernel Mailing List , Linux Documentation List , Tomasz Jankowski , Savo Novakovic , Jianxun Zhang Subject: Re: [PATCH v1 01/12] gna: add driver module In-reply-to: Date: Mon, 01 Mar 2021 11:36:40 +0100 Message-ID: <85czwjjh3b.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >> >> Andy Shevchenko writes: >> >> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >> > wrote: >> >> >> .... >> >> +static int __init gna_drv_init(void) >> >> +{ >> >> + int ret; >> >> + >> >> + mutex_init(&gna_drv_priv.lock); >> >> + >> >> + gna_class = class_create(THIS_MODULE, "gna"); >> >> + if (IS_ERR(gna_class)) { >> >> + pr_err("class device create failed\n"); >> >> + return PTR_ERR(gna_class); >> >> + } >> >> + gna_class->devnode = gna_devnode; >> >> + >> >> + ret = pci_register_driver(&gna_driver); >> > >> > Is it possible to decouple a PCI glue driver from the class as many >> > other existing examples are doing? >> > >> >> I see many pci drivers (including staging) that do have it glued though. >> >> Examples are: >> 1. "static int __init kp2000_pcie_init(void)" (commit on May 20 09:34:11 >> 2019) >> 2. "static int __init hl_init(void)" (commit on Mon Feb 18 09:46:43 2019) >> >> Please give me more details. > > Never use a staging driver for any type of example, _EXECPT_ for a bad > one. There's a reason the code is in staging and not in the "real" part > of the kernel. ok. another one (1) is not staging..