From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CBFC433FE for ; Wed, 9 Nov 2022 09:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbiKIJbN (ORCPT ); Wed, 9 Nov 2022 04:31:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230387AbiKIJbA (ORCPT ); Wed, 9 Nov 2022 04:31:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C990A14086 for ; Wed, 9 Nov 2022 01:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667986203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q81R0xjwZq+Uqwnnq1xIVaWYwdB8y5Gee+dkpFHuQEI=; b=gsDfjVF4RmUQEb45hXAxQcPXmJ/7EMld1sBgGeX+8YpBlTJX1ae50Nk8U3BpK3q0tMyH/5 4FhpeLEvlu/SCulXEa2Shi32OqgoaHQj0na1VN/PlEGUn8VI0e2PWzA9kDBz+U08cHBa8K 3qTWOuzyaYYFwCDw5G37shb3SIlsMeU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-674-WGF4U5bUMYyhnlyuzxwEdg-1; Wed, 09 Nov 2022 04:30:01 -0500 X-MC-Unique: WGF4U5bUMYyhnlyuzxwEdg-1 Received: by mail-wm1-f71.google.com with SMTP id ay40-20020a05600c1e2800b003cf8aa16377so7819014wmb.7 for ; Wed, 09 Nov 2022 01:30:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q81R0xjwZq+Uqwnnq1xIVaWYwdB8y5Gee+dkpFHuQEI=; b=5H2HcCXnXhmr9d9payFkuvQ7rkVNNOGy+iUAktra8xg4nmij10u0yeqwS3FqK+bPxX 7qiFOCW4asmkvgsYEGgvztq7rAHWs7sUcU/BaHqm5Py48vh+kD5DrOkg3fvbTNblOcp2 REaf5i6zIRs3J7PcAh803lFNyRjb0TcdbZKe7qdrFWX6T5KP8/uVddPLziB0LBv8RHrz rB/6TRkrqc5ejfjeTFCnm3go3XHsCRCnyd7ABaD47gcc3Z3DV9v4jo74LZsuP0sL3+RB kyd37kNMXQApDXkJzCdGuXWkDLNPus32U1GmRsCADG/MS2owVEgDg6oTFwM1hsc9nq5u x8Sw== X-Gm-Message-State: ACrzQf1NX26LMPNdFB69Pj8Ae1Ay5y1grdBOsToRqDmfqZFx+Un/Ubvj kL8Jp9SNuEMPXL+SU2aH6WVQ3FvIUgGERPSKg4r4wWlr7+85nPNfAr5Qrowuq3HENKAvOhQB2LK jtMSgL3H+uRowhMX9TIPMreLw X-Received: by 2002:a05:600c:48a7:b0:3cf:8025:c899 with SMTP id j39-20020a05600c48a700b003cf8025c899mr29896508wmp.26.1667986200745; Wed, 09 Nov 2022 01:30:00 -0800 (PST) X-Google-Smtp-Source: AMsMyM65t7+LWnDL71R+3AhoHt5oj9qYOtk7HdQRv2DlwJcYLMkAaWkALyOAg1gZGKJPkzQQ4ug7qg== X-Received: by 2002:a05:600c:48a7:b0:3cf:8025:c899 with SMTP id j39-20020a05600c48a700b003cf8025c899mr29896496wmp.26.1667986200542; Wed, 09 Nov 2022 01:30:00 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id q189-20020a1c43c6000000b003cf483ee8e0sm975366wma.24.2022.11.09.01.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 01:30:00 -0800 (PST) Message-ID: <85d7b64a-cdb0-d63b-ec4a-8d6920071fef@redhat.com> Date: Wed, 9 Nov 2022 10:29:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 7/8] KVM: SVM: move MSR_IA32_SPEC_CTRL save/restore to assembly Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, nathan@kernel.org, thomas.lendacky@amd.com, andrew.cooper3@citrix.com, peterz@infradead.org, jmattson@google.com, stable@vger.kernel.org References: <20221108151532.1377783-1-pbonzini@redhat.com> <20221108151532.1377783-8-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/22 02:14, Sean Christopherson wrote: >> >> +.macro RESTORE_SPEC_CTRL_BODY > > Can we split these into separate macros? It's a bit more typing, but it's not > immediately obvious that these are two independent chunks (I was expecting a JMP > from the 800 section into the 900 section). > > E.g. RESTORE_GUEST_SPEC_CTRL_BODY and RESTORE_HOST_SPEC_CTRL_BODY Sure, I had it like that in an earlier version. I didn't see much benefit but it is indeed a bit more readable if you order the macros like .macro RESTORE_GUEST_SPEC_CTRL .macro RESTORE_GUEST_SPEC_CTRL_BODY .macro RESTORE_HOST_SPEC_CTRL .macro RESTORE_HOST_SPEC_CTRL_BODY >> +800: > > Ugh, the multiple users makes it somewhat ugly, but rather than arbitrary numbers, > what about using named labels to make it easier to understand the branches? I think it's okay if we separate the macros. Paolo