From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2734C0044D for ; Tue, 19 Jan 2021 18:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80CAD20706 for ; Tue, 19 Jan 2021 18:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389409AbhASQro (ORCPT ); Tue, 19 Jan 2021 11:47:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731236AbhASQk0 (ORCPT ); Tue, 19 Jan 2021 11:40:26 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C003C0613D6 for ; Tue, 19 Jan 2021 08:39:09 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1u26-0005FZ-E2; Tue, 19 Jan 2021 17:39:06 +0100 Received: from [IPv6:2a03:f580:87bc:d400:8975:b8c4:b326:621a] (unknown [IPv6:2a03:f580:87bc:d400:8975:b8c4:b326:621a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (not verified)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id EA1515C8001; Tue, 19 Jan 2021 16:39:04 +0000 (UTC) Subject: Re: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library To: rpalethorpe@suse.de Cc: Cyril Hrubis , ltp@lists.linux.it, Oliver Hartkopp , linux-can@vger.kernel.org References: <20210119093143.17222-1-rpalethorpe@suse.com> <20210119093143.17222-5-rpalethorpe@suse.com> <322f1056-0a73-65e6-531a-3275029df256@pengutronix.de> <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> <87bldkq41l.fsf@suse.de> From: Marc Kleine-Budde Autocrypt: addr=mkl@pengutronix.de; prefer-encrypt=mutual; keydata= mQINBFFVq30BEACtnSvtXHoeHJxG6nRULcvlkW6RuNwHKmrqoksispp43X8+nwqIFYgb8UaX zu8T6kZP2wEIpM9RjEL3jdBjZNCsjSS6x1qzpc2+2ivjdiJsqeaagIgvy2JWy7vUa4/PyGfx QyUeXOxdj59DvLwAx8I6hOgeHx2X/ntKAMUxwawYfPZpP3gwTNKc27dJWSomOLgp+gbmOmgc 6U5KwhAxPTEb3CsT5RicsC+uQQFumdl5I6XS+pbeXZndXwnj5t84M+HEj7RN6bUfV2WZO/AB Xt5+qFkC/AVUcj/dcHvZwQJlGeZxoi4veCoOT2MYqfR0ax1MmN+LVRvKm29oSyD4Ts/97cbs XsZDRxnEG3z/7Winiv0ZanclA7v7CQwrzsbpCv+oj+zokGuKasofzKdpywkjAfSE1zTyF+8K nxBAmzwEqeQ3iKqBc3AcCseqSPX53mPqmwvNVS2GqBpnOfY7Mxr1AEmxdEcRYbhG6Xdn+ACq Dq0Db3A++3PhMSaOu125uIAIwMXRJIzCXYSqXo8NIeo9tobk0C/9w3fUfMTrBDtSviLHqlp8 eQEP8+TDSmRP/CwmFHv36jd+XGmBHzW5I7qw0OORRwNFYBeEuiOIgxAfjjbLGHh9SRwEqXAL kw+WVTwh0MN1k7I9/CDVlGvc3yIKS0sA+wudYiselXzgLuP5cQARAQABtCZNYXJjIEtsZWlu ZS1CdWRkZSA8bWtsQHBlbmd1dHJvbml4LmRlPokCVAQTAQoAPgIbAwIeAQIXgAULCQgHAwUV CgkICwUWAgMBABYhBMFAC6CzmJ5vvH1bXCte4hHFiupUBQJfEWX4BQkQo2czAAoJECte4hHF iupUvfMP/iNtiysSr5yU4tbMBzRkGov1/FjurfH1kPweLVHDwiQJOGBz9HgM5+n8boduRv36 0lU32g3PehN0UHZdHWhygUd6J09YUi2mJo1l2Fz1fQ8elUGUOXpT/xoxNQjslZjJGItCjza8 +D1DO+0cNFgElcNPa7DFBnglatOCZRiMjo4Wx0i8njEVRU+4ySRU7rCI36KPts+uVmZAMD7V 3qiR1buYklJaPCJsnXURXYsilBIE9mZRmQjTDVqjLWAit++flqUVmDjaD/pj2AQe2Jcmd2gm sYW5P1moz7ACA1GzMjLDmeFtpJOIB7lnDX0F/vvsG3V713/701aOzrXqBcEZ0E4aWeZJzaXw n1zVIrl/F3RKrWDhMKTkjYy7HA8hQ9SJApFXsgP334Vo0ea82H3dOU755P89+Eoj0y44MbQX 7xUy4UTRAFydPl4pJskveHfg4dO6Yf0PGIvVWOY1K04T1C5dpnHAEMvVNBrfTA8qcahRN82V /iIGB+KSC2xR79q1kv1oYn0GOnWkvZmMhqGLhxIqHYitwH4Jn5uRfanKYWBk12LicsjRiTyW Z9cJf2RgAtQgvMPvmaOL8vB3U4ava48qsRdgxhXMagU618EszVdYRNxGLCqsKVYIDySTrVzu ZGs2ibcRhN4TiSZjztWBAe1MaaGk05Ce4h5IdDLbOOxhuQENBF8SDLABCADohJLQ5yffd8Sq 8Lo9ymzgaLcWboyZ46pY4CCCcAFDRh++QNOJ8l4mEJMNdEa/yrW4lDQDhBWV75VdBuapYoal LFrSzDzrqlHGG4Rt4/XOqMo6eSeSLipYBu4Xhg59S9wZOWbHVT/6vZNmiTa3d40+gBg68dQ8 iqWSU5NhBJCJeLYdG6xxeUEtsq/25N1erxmhs/9TD0sIeX36rFgWldMwKmZPe8pgZEv39Sdd B+ykOlRuHag+ySJxwovfdVoWT0o0LrGlHzAYo6/ZSi/Iraa9R/7A1isWOBhw087BMNkRYx36 B77E4KbyBPx9h3wVyD/R6T0Q3ZNPu6SQLnsWojMzABEBAAGJAjwEGAEKACYWIQTBQAugs5ie b7x9W1wrXuIRxYrqVAUCXxIMsAIbDAUJAucGAAAKCRArXuIRxYrqVOu0D/48xSLyVZ5NN2Bb yqo3zxdv/PMGJSzM3JqSv7hnMZPQGy9XJaTc5Iz/hyXaNRwpH5X0UNKqhQhlztChuAKZ7iu+ 2VKzq4JJe9qmydRUwylluc4HmGwlIrDNvE0N66pRvC3h8tOVIsippAQlt5ciH74bJYXr0PYw Aksw1jugRxMbNRzgGECg4O6EBNaHwDzsVPX1tDj0d9t/7ClzJUy20gg8r9Wm/I/0rcNkQOpV RJLDtSbGSusKxor2XYmVtHGauag4YO6Vdq+2RjArB3oNLgSOGlYVpeqlut+YYHjWpaX/cTf8 /BHtIQuSAEu/WnycpM3Z9aaLocYhbp5lQKL6/bcWQ3udd0RfFR/Gv7eR7rn3evfqNTtQdo4/ YNmd7P8TS7ALQV/5bNRe+ROLquoAZvhaaa6SOvArcmFccnPeyluX8+o9K3BCdXPwONhsrxGO wrPI+7XKMlwWI3O076NqNshh6mm8NIC0mDUr7zBUITa67P3Q2VoPoiPkCL9RtsXdQx5BI9iI h/6QlzDxcBdw2TVWyGkVTCdeCBpuRndOMVmfjSWdCXXJCLXO6sYeculJyPkuNvumxgwUiK/H AqqdUfy1HqtzP2FVhG5Ce0TeMJepagR2CHPXNg88Xw3PDjzdo+zNpqPHOZVKpLUkCvRv1p1q m1qwQVWtAwMML/cuPga78rkBDQRfEXGWAQgAt0Cq8SRiLhWyTqkf16Zv/GLkUgN95RO5ntYM fnc2Tr3UlRq2Cqt+TAvB928lN3WHBZx6DkuxRM/Y/iSyMuhzL5FfhsICuyiBs5f3QG70eZx+ Bdj4I7LpnIAzmBdNWxMHpt0m7UnkNVofA0yH6rcpCsPrdPRJNOLFI6ZqXDQk9VF+AB4HVAJY BDU3NAHoyVGdMlcxev0+gEXfBQswEcysAyvzcPVTAqmrDsupnIB2f0SDMROQCLO6F+/cLG4L Stbz+S6YFjESyXblhLckTiPURvDLTywyTOxJ7Mafz6ZCene9uEOqyd/h81nZOvRd1HrXjiTE 1CBw+Dbvbch1ZwGOTQARAQABiQNyBBgBCgAmFiEEwUALoLOYnm+8fVtcK17iEcWK6lQFAl8R cZYCGwIFCQLnoRoBQAkQK17iEcWK6lTAdCAEGQEKAB0WIQQreQhYm33JNgw/d6GpyVqK+u3v qQUCXxFxlgAKCRCpyVqK+u3vqatQCAC3QIk2Y0g/07xNLJwhWcD7JhIqfe7Qc5Vz9kf8ZpWr +6w4xwRfjUSmrXz3s6e/vrQsfdxjVMDFOkyG8c6DWJo0TVm6Ucrf9G06fsjjE/6cbE/gpBkk /hOVz/a7UIELT+HUf0zxhhu+C9hTSl8Nb0bwtm6JuoY5AW0LP2KoQ6LHXF9KNeiJZrSzG6WE h7nf3KRFS8cPKe+trbujXZRb36iIYUfXKiUqv5xamhohy1hw+7Sy8nLmw8rZPa40bDxX0/Gi 98eVyT4/vi+nUy1gF1jXgNBSkbTpbVwNuldBsGJsMEa8lXnYuLzn9frLdtufUjjCymdcV/iT sFKziU9AX7TLZ5AP/i1QMP9OlShRqERH34ufA8zTukNSBPIBfmSGUe6G2KEWjzzNPPgcPSZx Do4jfQ/m/CiiibM6YCa51Io72oq43vMeBwG9/vLdyev47bhSfMLTpxdlDJ7oXU9e8J61iAF7 vBwerBZL94I3QuPLAHptgG8zPGVzNKoAzxjlaxI1MfqAD9XUM80MYBVjunIQlkU/AubdvmMY X7hY1oMkTkC5hZNHLgIsDvWUG0g3sACfqF6gtMHY2lhQ0RxgxAEx+ULrk/svF6XGDe6iveyc z5Mg5SUggw3rMotqgjMHHRtB3nct6XqgPXVDGYR7nAkXitG+nyG5zWhbhRDglVZ0mLlW9hij z3Emwa94FaDhN2+1VqLFNZXhLwrNC5mlA6LUjCwOL+zb9a07HyjekLyVAdA6bZJ5BkSXJ1CO 5YeYolFjr4YU7GXcSVfUR6fpxrb8N+yH+kJhY3LmS9vb2IXxneE/ESkXM6a2YAZWfW8sgwTm 0yCEJ41rW/p3UpTV9wwE2VbGD1XjzVKl8SuAUfjjcGGys3yk5XQ5cccWTCwsVdo2uAcY1MVM HhN6YJjnMqbFoHQq0H+2YenTlTBn2Wsp8TIytE1GL6EbaPWbMh3VLRcihlMj28OUWGSERxat xlygDG5cBiY3snN3xJyBroh5xk/sHRgOdHpmujnFyu77y4RTZ2W8 Message-ID: <85d808dd-c8c3-1216-ee6e-94d63ddf0f2b@pengutronix.de> Date: Tue, 19 Jan 2021 17:39:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87bldkq41l.fsf@suse.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aFCDigC6GRxfsdQ20QzgZRLQj3UFN9VyR" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aFCDigC6GRxfsdQ20QzgZRLQj3UFN9VyR Content-Type: multipart/mixed; boundary="H5HQFSVpZaggOTmSDFDWDTJonQcLAqcJC"; protected-headers="v1" From: Marc Kleine-Budde To: rpalethorpe@suse.de Cc: Cyril Hrubis , ltp@lists.linux.it, Oliver Hartkopp , linux-can@vger.kernel.org Message-ID: <85d808dd-c8c3-1216-ee6e-94d63ddf0f2b@pengutronix.de> Subject: Re: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library References: <20210119093143.17222-1-rpalethorpe@suse.com> <20210119093143.17222-5-rpalethorpe@suse.com> <322f1056-0a73-65e6-531a-3275029df256@pengutronix.de> <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> <87bldkq41l.fsf@suse.de> In-Reply-To: <87bldkq41l.fsf@suse.de> --H5HQFSVpZaggOTmSDFDWDTJonQcLAqcJC Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 1/19/21 5:34 PM, Richard Palethorpe wrote: > Hello All, >=20 > Marc Kleine-Budde writes: >=20 >> On 1/19/21 4:06 PM, Cyril Hrubis wrote: >>> Hi! >>>>> /* >>>>> - * tst-rcv-own-msgs.c >>>>> - * >>>>> - * Copyright (c) 2010 Volkswagen Group Electronic Research >>>>> - * All rights reserved. >>>>> - * >>>>> - * Redistribution and use in source and binary forms, with or with= out >>>>> - * modification, are permitted provided that the following conditi= ons >>>>> - * are met: >>>>> - * 1. Redistributions of source code must retain the above copyrig= ht >>>>> - * notice, this list of conditions and the following disclaimer= =2E >>>>> - * 2. Redistributions in binary form must reproduce the above copy= right >>>>> - * notice, this list of conditions and the following disclaimer= in the >>>>> - * documentation and/or other materials provided with the distr= ibution. >>>>> - * 3. Neither the name of Volkswagen nor the names of its contribu= tors >>>>> - * may be used to endorse or promote products derived from this= software >>>>> - * without specific prior written permission. >>>> >>>> IANAL, I think you're missing this license. Is looks like some sort >>>> of BSD to me. >=20 > Ufff, thanks, I should pay more attention when it is a test imported > from elsewhere. >=20 >>>> >>>>> - * >>>>> - * Alternatively, provided that this notice is retained in full, t= his >>>>> - * software may be distributed under the terms of the GNU General >>>>> - * Public License ("GPL") version 2, in which case the provisions = of the >>>>> - * GPL apply INSTEAD OF those given above. >>>> >>>> It doesn't say "or later". >>> >>> Looks like we cannot just remove this license. So what about moving t= his >>> text into a separate COPYING file and changing the SPDX to GPL-v2.0? >> >> This file is dual licensed, better keep it dual licensed. >> >> regards, >> Marc >=20 > HHmm, this appears to be the BSD-3-Clause license with the following > text inserted in the middle: >=20 > * Alternatively, provided that this notice is retained in full, this > * software may be distributed under the terms of the GNU General > * Public License ("GPL") version 2, in which case the provisions of th= e > * GPL apply INSTEAD OF those given above. > * > * The provided data structures and external interfaces from this code > * are not restricted to be used by modules with a GPL compatible licen= se. >=20 > I don't see any corresponding SPDX identifier or exception for this. It= > is probably easiest and safest just to keep it as-is. I think the Linux kernel uses: /* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */ e.g.: https://elixir.bootlin.com/linux/v5.10/source/include/uapi/linux/can/gw.h= Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --H5HQFSVpZaggOTmSDFDWDTJonQcLAqcJC-- --aFCDigC6GRxfsdQ20QzgZRLQj3UFN9VyR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmAHCyUACgkQqclaivrt 76m9swgAsyUB3OfLOyqzG9WMmppBWFojQryke+cO9YE8HBR60bJwSyi2Vpr+zxup qOoH7jWnC8VrsI1qvBaue9M4z58AeE9npb16Jz00u8Z4LkMWhowy/snay2scv+4K QAgdOW02toakAQ2PtjDUoTf4YCljgUF3A4no6J6kvDsjmiMDX8lmaRijm89sweC8 P0rmoG2Joj7D9WdwxJDIHQXxEK+aSDD1WCK81GW7Zhz5IhTp508ywO4loG/rNhj0 c6svD+h35BVvd+R4lIXYMiiTziA6l4KPpG0lcoEUsv6Q374xikl0T/kz9j6efub/ jNmoWJBK5krYwOoAqxYWlc1G0dJ5Tg== =kcZZ -----END PGP SIGNATURE----- --aFCDigC6GRxfsdQ20QzgZRLQj3UFN9VyR-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Date: Tue, 19 Jan 2021 17:39:01 +0100 Subject: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library In-Reply-To: <87bldkq41l.fsf@suse.de> References: <20210119093143.17222-1-rpalethorpe@suse.com> <20210119093143.17222-5-rpalethorpe@suse.com> <322f1056-0a73-65e6-531a-3275029df256@pengutronix.de> <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> <87bldkq41l.fsf@suse.de> Message-ID: <85d808dd-c8c3-1216-ee6e-94d63ddf0f2b@pengutronix.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On 1/19/21 5:34 PM, Richard Palethorpe wrote: > Hello All, > > Marc Kleine-Budde writes: > >> On 1/19/21 4:06 PM, Cyril Hrubis wrote: >>> Hi! >>>>> /* >>>>> - * tst-rcv-own-msgs.c >>>>> - * >>>>> - * Copyright (c) 2010 Volkswagen Group Electronic Research >>>>> - * All rights reserved. >>>>> - * >>>>> - * Redistribution and use in source and binary forms, with or without >>>>> - * modification, are permitted provided that the following conditions >>>>> - * are met: >>>>> - * 1. Redistributions of source code must retain the above copyright >>>>> - * notice, this list of conditions and the following disclaimer. >>>>> - * 2. Redistributions in binary form must reproduce the above copyright >>>>> - * notice, this list of conditions and the following disclaimer in the >>>>> - * documentation and/or other materials provided with the distribution. >>>>> - * 3. Neither the name of Volkswagen nor the names of its contributors >>>>> - * may be used to endorse or promote products derived from this software >>>>> - * without specific prior written permission. >>>> >>>> IANAL, I think you're missing this license. Is looks like some sort >>>> of BSD to me. > > Ufff, thanks, I should pay more attention when it is a test imported > from elsewhere. > >>>> >>>>> - * >>>>> - * Alternatively, provided that this notice is retained in full, this >>>>> - * software may be distributed under the terms of the GNU General >>>>> - * Public License ("GPL") version 2, in which case the provisions of the >>>>> - * GPL apply INSTEAD OF those given above. >>>> >>>> It doesn't say "or later". >>> >>> Looks like we cannot just remove this license. So what about moving this >>> text into a separate COPYING file and changing the SPDX to GPL-v2.0? >> >> This file is dual licensed, better keep it dual licensed. >> >> regards, >> Marc > > HHmm, this appears to be the BSD-3-Clause license with the following > text inserted in the middle: > > * Alternatively, provided that this notice is retained in full, this > * software may be distributed under the terms of the GNU General > * Public License ("GPL") version 2, in which case the provisions of the > * GPL apply INSTEAD OF those given above. > * > * The provided data structures and external interfaces from this code > * are not restricted to be used by modules with a GPL compatible license. > > I don't see any corresponding SPDX identifier or exception for this. It > is probably easiest and safest just to keep it as-is. I think the Linux kernel uses: /* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */ e.g.: https://elixir.bootlin.com/linux/v5.10/source/include/uapi/linux/can/gw.h Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: