All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen <stephenackerman16@gmail.com>
To: seanjc@google.com
Cc: djwong@kernel.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, stephenackerman16@gmail.com
Subject: Re: kvm crash in 5.14.1?
Date: Sat, 2 Oct 2021 22:47:48 -0700	[thread overview]
Message-ID: <85e40141-3c17-1dff-1ed0-b016c5d778b6@gmail.com> (raw)
In-Reply-To: <YVSEZTCbFZ+HD/f0@google.com>

> I think this should fix the problems?
>
> diff --git a/include/linux/secretmem.h b/include/linux/secretmem.h
> index 21c3771e6a56..988528b5da43 100644
> --- a/include/linux/secretmem.h
> +++ b/include/linux/secretmem.h
> @@ -23,7 +23,7 @@ static inline bool page_is_secretmem(struct page *page)
>         mapping = (struct address_space *)
>                 ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS);
>
> -       if (mapping != page->mapping)
> +       if (!mapping || mapping != page->mapping)
>                 return false;
>
>         return mapping->a_ops == &secretmem_aops;

I have validated that my system was stable after several days on
v5.13.19. I'm now booted into a v5.14.8 kernel with this patch, and I'll
try to report back if I see a crash; or in roughly a week if the system
seems to have stabilized.

Thanks,
    Stephen


  parent reply	other threads:[~2021-10-03  5:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  2:58 kvm crash in 5.14.1? Darrick J. Wong
2021-09-23 17:50 ` Stephen
2021-09-29  4:44   ` Stephen
2021-09-29 15:21     ` Sean Christopherson
2021-09-30 17:59       ` Darrick J. Wong
2021-10-04 16:54         ` Darrick J. Wong
2021-10-06 16:34           ` Darrick J. Wong
2021-10-03  5:47       ` Stephen [this message]
2021-10-09 19:00         ` Stephen
2021-10-13 19:00           ` Salvatore Bonaccorso
2021-10-13 19:05             ` Paolo Bonzini
2021-10-13 19:29               ` Sean Christopherson
2021-10-13 19:33                 ` Salvatore Bonaccorso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85e40141-3c17-1dff-1ed0-b016c5d778b6@gmail.com \
    --to=stephenackerman16@gmail.com \
    --cc=djwong@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.