From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED81C43381 for ; Thu, 14 Feb 2019 14:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B3DB2229F for ; Thu, 14 Feb 2019 14:31:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5tDvRLh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439223AbfBNObX (ORCPT ); Thu, 14 Feb 2019 09:31:23 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44269 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439209AbfBNObW (ORCPT ); Thu, 14 Feb 2019 09:31:22 -0500 Received: by mail-pf1-f195.google.com with SMTP id u6so3177868pfh.11; Thu, 14 Feb 2019 06:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I8Ik0YH4DDrW+a6thIGf2C23HRpkqbBiYZr2uZywPpY=; b=Y5tDvRLhZ6rQkbiRs7d3HKRyS24zoQClPpfWDl+Spr3VuYuamhZ3mVJ6qy/QAy/1jT DpSKz6D6ewQNhVTJnsD0jJRXPLUW+DiaQKH5FF0aMSTR+7oDEZvV6CcNNdrbGlIHEMSm iT/BBp8995nTs48DszxC7diELMR1+KiVJ7HVOwmv6/zNPi/Nid/C3eOxAwyHS9kRxhn2 2tZKpK0q5TBOF/Op21RumrnG9Oqr0iVeIRH/K5pNlkqQ5mD8gwLmWANa+OFqrlmGFO10 ozqyUOpjqt6zgoVCMktaK1jOBuVZQsVRGbjoTGNuDFkEyb4skbP6OHqr7IvlXx0tSguZ apCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I8Ik0YH4DDrW+a6thIGf2C23HRpkqbBiYZr2uZywPpY=; b=Hd3dXcilaj1r8FZqLlqQaODTVS3B0eM4Gy/7QVU/6dXNVhC5KOjWNBSNv1ITKvw4km NNFN51+FIxoO+XX+/9vQe8tuj8BrMFhB906/7jV/JJOHHZqhKsAg9A/IVu194MBEN6pS 8gIWE7Ec9jHsN6K6lpon7kM4BDX1OJqkixyrfe7q7CmpiPV/3txKQLQl1ZLeFGCpUvqB cBRAzYE8q3lIF/Tfp4hkh1N3Pdlp8GRaBv8sHGxp0///AQBIBQEHFqHWgu27POE+aL9L P3togMG2kvR79jZ0/YowN56hy6M8x7UXn43/yje0t2q6bpUH6gfuk77a6qnolZnAZDRA Buyw== X-Gm-Message-State: AHQUAuZ5FnkHJQv6AMUfvUDzxujE0CZZrpPOwlKB3Q6CaEuB1tVKwIt+ yqZTStQ9rXV9aAFT6Mj7eZD0ns+X X-Google-Smtp-Source: AHgI3IaqEHkOh/inM9tGVYcR4/uvDKSgpswPQ8S0MekutQ7ow7Rkt+0wK6ZOPw17pOzdytZLaTlYsw== X-Received: by 2002:a63:2bc6:: with SMTP id r189mr177603pgr.201.1550154680939; Thu, 14 Feb 2019 06:31:20 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id e24sm3618055pfi.153.2019.02.14.06.31.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 06:31:19 -0800 (PST) Subject: Re: [PATCH] usb: typec: tcpm: Export partner Source Capabilities To: Adam Thomson , Greg KH , Kyle Tso Cc: Heikki Krogerus , Badhri Jagan Sridharan , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190131035411.53576-1-kyletso@google.com> <20190131070238.GA4500@kroah.com> <20190212105421.GA23271@kroah.com> From: Guenter Roeck Message-ID: <85ea1e87-eaaa-1540-f693-5601bcafddf6@roeck-us.net> Date: Thu, 14 Feb 2019 06:31:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/19 6:17 AM, Adam Thomson wrote: > On 12 February 2019 16:20, Guenter Roeck wrote: > >> On 2/12/19 2:54 AM, Greg KH wrote: >>> On Tue, Feb 12, 2019 at 06:29:39PM +0800, Kyle Tso wrote: >>>> On Thu, Jan 31, 2019 at 3:02 PM Greg KH >> wrote: >>>> >>>>> On Thu, Jan 31, 2019 at 11:54:11AM +0800, Kyle Tso wrote: >>>>>> Provide a function to get the partner Source Capabilities. >>>>>> >>>>>> Signed-off-by: Kyle Tso >>>>>> --- >>>>>> drivers/usb/typec/tcpm/tcpm.c | 23 +++++++++++++++++++++++ >>>>>> include/linux/usb/tcpm.h | 1 + >>>>>> 2 files changed, 24 insertions(+) >>>>>> >>>>>> diff --git a/drivers/usb/typec/tcpm/tcpm.c >>>>> b/drivers/usb/typec/tcpm/tcpm.c >>>>>> index f1d3e54210df..29cd84ba9960 100644 >>>>>> --- a/drivers/usb/typec/tcpm/tcpm.c >>>>>> +++ b/drivers/usb/typec/tcpm/tcpm.c >>>>>> @@ -4494,6 +4494,29 @@ int tcpm_update_sink_capabilities(struct >>>>> tcpm_port *port, const u32 *pdo, >>>>>> } >>>>>> EXPORT_SYMBOL_GPL(tcpm_update_sink_capabilities); >>>>>> >>>>>> +/* >>>>>> + * Don't call this function in interrupt context. Caller needs to >>>>>> +free >>>>> the >>>>>> + * memory itself. >>>>>> + */ >>>>>> +int tcpm_get_partner_src_caps(struct tcpm_port *port, u32 >>>>>> +**src_pdo) { >>>>>> + unsigned int nr_pdo; >>>>>> + >>>>>> + if (port->nr_source_caps == 0) >>>>>> + return -ENODATA; >>>>>> + >>>>>> + *src_pdo = kcalloc(port->nr_source_caps, sizeof(u32), GFP_KERNEL); >>>>>> + if (!src_pdo) >>>>>> + return -ENOMEM; >>>>>> + >>>>>> + mutex_lock(&port->lock); >>>>>> + nr_pdo = tcpm_copy_pdos(*src_pdo, port->source_caps, >>>>>> + port->nr_source_caps); >>>>>> + mutex_unlock(&port->lock); >>>>>> + return nr_pdo; >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(tcpm_get_partner_src_caps); >>>>> >>>>> We don't add new functions that no one uses :( >>>>> >>>>> >>>> This function is useful if the PD Device Policy Manager is >>>> implemented outside of TCPM. >>>> In this situation, Device Policy Manager needs to know the partner >>>> capabilities to optimize the charging process. >>> >>> And where is that code? >>> >> >> Agreed - that code should be sent upstream as well to let us see the entire >> context. >> >>>> Take existing functions in TCPM for example: >>>> Function "tcpm_update_sink_capabilities" and >>>> "tcpm_update_source_capabilities" are exposed as well. And no one >>>> uses them now. >>> >>> Great, let's go delete them now, we should not have apis that no one >>> uses. This isn't a new thing... >>> >> >> I sent a patch to do just that. Quite frankly I don't recal why I thought those >> functions might be needed. > > As a mind jog - https://lkml.org/lkml/2017/11/27/1256 :) > Nice find. However, since the code using it was never implemented, I think it is prudent at this point to remove the code. It can be reintroduced if/when needed, and at that point be tested properly. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: typec: tcpm: Export partner Source Capabilities From: Guenter Roeck Message-Id: <85ea1e87-eaaa-1540-f693-5601bcafddf6@roeck-us.net> Date: Thu, 14 Feb 2019 06:31:18 -0800 To: Adam Thomson , Greg KH , Kyle Tso Cc: Heikki Krogerus , Badhri Jagan Sridharan , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gMi8xNC8xOSA2OjE3IEFNLCBBZGFtIFRob21zb24gd3JvdGU6Cj4gT24gMTIgRmVicnVhcnkg MjAxOSAxNjoyMCwgR3VlbnRlciBSb2VjayB3cm90ZToKPiAKPj4gT24gMi8xMi8xOSAyOjU0IEFN LCBHcmVnIEtIIHdyb3RlOgo+Pj4gT24gVHVlLCBGZWIgMTIsIDIwMTkgYXQgMDY6Mjk6MzlQTSAr MDgwMCwgS3lsZSBUc28gd3JvdGU6Cj4+Pj4gT24gVGh1LCBKYW4gMzEsIDIwMTkgYXQgMzowMiBQ TSBHcmVnIEtIIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPj4gd3JvdGU6Cj4+Pj4KPj4+ Pj4gT24gVGh1LCBKYW4gMzEsIDIwMTkgYXQgMTE6NTQ6MTFBTSArMDgwMCwgS3lsZSBUc28gd3Jv dGU6Cj4+Pj4+PiBQcm92aWRlIGEgZnVuY3Rpb24gdG8gZ2V0IHRoZSBwYXJ0bmVyIFNvdXJjZSBD YXBhYmlsaXRpZXMuCj4+Pj4+Pgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogS3lsZSBUc28gPGt5bGV0 c29AZ29vZ2xlLmNvbT4KPj4+Pj4+IC0tLQo+Pj4+Pj4gICAgZHJpdmVycy91c2IvdHlwZWMvdGNw bS90Y3BtLmMgfCAyMyArKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+Pj4gICAgaW5jbHVkZS9s aW51eC91c2IvdGNwbS5oICAgICAgfCAgMSArCj4+Pj4+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDI0 IGluc2VydGlvbnMoKykKPj4+Pj4+Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvdHlw ZWMvdGNwbS90Y3BtLmMKPj4+Pj4gYi9kcml2ZXJzL3VzYi90eXBlYy90Y3BtL3RjcG0uYwo+Pj4+ Pj4gaW5kZXggZjFkM2U1NDIxMGRmLi4yOWNkODRiYTk5NjAgMTAwNjQ0Cj4+Pj4+PiAtLS0gYS9k cml2ZXJzL3VzYi90eXBlYy90Y3BtL3RjcG0uYwo+Pj4+Pj4gKysrIGIvZHJpdmVycy91c2IvdHlw ZWMvdGNwbS90Y3BtLmMKPj4+Pj4+IEBAIC00NDk0LDYgKzQ0OTQsMjkgQEAgaW50IHRjcG1fdXBk YXRlX3NpbmtfY2FwYWJpbGl0aWVzKHN0cnVjdAo+Pj4+PiB0Y3BtX3BvcnQgKnBvcnQsIGNvbnN0 IHUzMiAqcGRvLAo+Pj4+Pj4gICAgfQo+Pj4+Pj4gICAgRVhQT1JUX1NZTUJPTF9HUEwodGNwbV91 cGRhdGVfc2lua19jYXBhYmlsaXRpZXMpOwo+Pj4+Pj4KPj4+Pj4+ICsvKgo+Pj4+Pj4gKyAqIERv bid0IGNhbGwgdGhpcyBmdW5jdGlvbiBpbiBpbnRlcnJ1cHQgY29udGV4dC4gQ2FsbGVyIG5lZWRz IHRvCj4+Pj4+PiArZnJlZQo+Pj4+PiB0aGUKPj4+Pj4+ICsgKiBtZW1vcnkgaXRzZWxmLgo+Pj4+ Pj4gKyAqLwo+Pj4+Pj4gK2ludCB0Y3BtX2dldF9wYXJ0bmVyX3NyY19jYXBzKHN0cnVjdCB0Y3Bt X3BvcnQgKnBvcnQsIHUzMgo+Pj4+Pj4gKyoqc3JjX3Bkbykgewo+Pj4+Pj4gKyAgICAgdW5zaWdu ZWQgaW50IG5yX3BkbzsKPj4+Pj4+ICsKPj4+Pj4+ICsgICAgIGlmIChwb3J0LT5ucl9zb3VyY2Vf Y2FwcyA9PSAwKQo+Pj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gLUVOT0RBVEE7Cj4+Pj4+PiAr Cj4+Pj4+PiArICAgICAqc3JjX3BkbyA9IGtjYWxsb2MocG9ydC0+bnJfc291cmNlX2NhcHMsIHNp emVvZih1MzIpLCBHRlBfS0VSTkVMKTsKPj4+Pj4+ICsgICAgIGlmICghc3JjX3BkbykKPj4+Pj4+ ICsgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4+Pj4+PiArCj4+Pj4+PiArICAgICBtdXRl eF9sb2NrKCZwb3J0LT5sb2NrKTsKPj4+Pj4+ICsgICAgIG5yX3BkbyA9IHRjcG1fY29weV9wZG9z KCpzcmNfcGRvLCBwb3J0LT5zb3VyY2VfY2FwcywKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHBvcnQtPm5yX3NvdXJjZV9jYXBzKTsKPj4+Pj4+ICsgICAgIG11dGV4X3VubG9j aygmcG9ydC0+bG9jayk7Cj4+Pj4+PiArICAgICByZXR1cm4gbnJfcGRvOwo+Pj4+Pj4gK30KPj4+ Pj4+ICtFWFBPUlRfU1lNQk9MX0dQTCh0Y3BtX2dldF9wYXJ0bmVyX3NyY19jYXBzKTsKPj4+Pj4K Pj4+Pj4gV2UgZG9uJ3QgYWRkIG5ldyBmdW5jdGlvbnMgdGhhdCBubyBvbmUgdXNlcyA6KAo+Pj4+ Pgo+Pj4+Pgo+Pj4+IFRoaXMgZnVuY3Rpb24gaXMgdXNlZnVsIGlmIHRoZSBQRCBEZXZpY2UgUG9s aWN5IE1hbmFnZXIgaXMKPj4+PiBpbXBsZW1lbnRlZCBvdXRzaWRlIG9mIFRDUE0uCj4+Pj4gSW4g dGhpcyBzaXR1YXRpb24sIERldmljZSBQb2xpY3kgTWFuYWdlciBuZWVkcyB0byBrbm93IHRoZSBw YXJ0bmVyCj4+Pj4gY2FwYWJpbGl0aWVzIHRvIG9wdGltaXplIHRoZSBjaGFyZ2luZyBwcm9jZXNz Lgo+Pj4KPj4+IEFuZCB3aGVyZSBpcyB0aGF0IGNvZGU/Cj4+Pgo+Pgo+PiBBZ3JlZWQgLSB0aGF0 IGNvZGUgc2hvdWxkIGJlIHNlbnQgdXBzdHJlYW0gYXMgd2VsbCB0byBsZXQgdXMgc2VlIHRoZSBl bnRpcmUKPj4gY29udGV4dC4KPj4KPj4+PiBUYWtlIGV4aXN0aW5nIGZ1bmN0aW9ucyBpbiBUQ1BN IGZvciBleGFtcGxlOgo+Pj4+IEZ1bmN0aW9uICJ0Y3BtX3VwZGF0ZV9zaW5rX2NhcGFiaWxpdGll cyIgYW5kCj4+Pj4gInRjcG1fdXBkYXRlX3NvdXJjZV9jYXBhYmlsaXRpZXMiIGFyZSBleHBvc2Vk IGFzIHdlbGwuIEFuZCBubyBvbmUKPj4+PiB1c2VzIHRoZW0gbm93Lgo+Pj4KPj4+IEdyZWF0LCBs ZXQncyBnbyBkZWxldGUgdGhlbSBub3csIHdlIHNob3VsZCBub3QgaGF2ZSBhcGlzIHRoYXQgbm8g b25lCj4+PiB1c2VzLiAgVGhpcyBpc24ndCBhIG5ldyB0aGluZy4uLgo+Pj4KPj4KPj4gSSBzZW50 IGEgcGF0Y2ggdG8gZG8ganVzdCB0aGF0LiBRdWl0ZSBmcmFua2x5IEkgZG9uJ3QgcmVjYWwgd2h5 IEkgdGhvdWdodCB0aG9zZQo+PiBmdW5jdGlvbnMgbWlnaHQgYmUgbmVlZGVkLgo+IAo+IEFzIGEg bWluZCBqb2cgLSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNy8xMS8yNy8xMjU2IDopCj4gCgpO aWNlIGZpbmQuIEhvd2V2ZXIsIHNpbmNlIHRoZSBjb2RlIHVzaW5nIGl0IHdhcyBuZXZlciBpbXBs ZW1lbnRlZCwgSSB0aGluayBpdAppcyBwcnVkZW50IGF0IHRoaXMgcG9pbnQgdG8gcmVtb3ZlIHRo ZSBjb2RlLiBJdCBjYW4gYmUgcmVpbnRyb2R1Y2VkIGlmL3doZW4gbmVlZGVkLAphbmQgYXQgdGhh dCBwb2ludCBiZSB0ZXN0ZWQgcHJvcGVybHkuCgpUaGFua3MsCkd1ZW50ZXIK