From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Mashak <mrv@mojatatu.com>
Subject: Re: [PATCH 00/14] Modify action API for implementing lockless actions
Date: Wed, 16 May 2018 13:36:36 -0400
Message-ID: <85efib33kr.fsf@mojatatu.com>
References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com>
        <23f37e5a-dd30-0ad3-a5ab-df22bf0ad7f9@mojatatu.com>
        <vbfo9him0d7.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
        <97ccb118-a3dc-6eb0-b127-9c04adf9e2fd@mojatatu.com>
        <vbfh8n81uoc.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
        <2ee4066e-643a-f901-8926-7001f8699163@mojatatu.com>
        <vbffu2s14os.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
        <CAHvchG=Kj9HNfzWfbqGA1rmmTh=C5PDPKJfDO6mUyXtA052hog@mail.gmail.com>
        <vbfsh6rk42w.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, pablo@netfilter.org,
        kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org,
        Daniel Borkmann <daniel@iogearbox.net>,
        Eric Dumazet <edumazet@google.com>, kliteyn@mellanox.com
To: Vlad Buslov <vladbu@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f68.google.com ([209.85.214.68]:54125 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750775AbeEPRgi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 16 May 2018 13:36:38 -0400
Received: by mail-it0-f68.google.com with SMTP id n64-v6so3959833itb.3
        for <netdev@vger.kernel.org>; Wed, 16 May 2018 10:36:38 -0700 (PDT)
In-Reply-To: <vbfsh6rk42w.fsf@reg-r-vrt-018-180.mtr.labs.mlnx> (Vlad Buslov's
        message of "Wed, 16 May 2018 18:33:43 +0300")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Vlad Buslov <vladbu@mellanox.com> writes:

> On Wed 16 May 2018 at 14:38, Roman Mashak <mrv@mojatatu.com> wrote:
>> On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov <vladbu@mellanox.com> wrote:
>>>>>>> I'm trying to run tdc, but keep getting following error even on clean
>>>>>>> branch without my patches:
>>>>>>
>>>>>> Vlad, not sure if you saw my email:
>>>>>> Apply Roman's patch and try again
>>>>>>
>>>>>> https://marc.info/?l=linux-netdev&m=152639369112020&w=2
>>>>>>
>>>>>> cheers,
>>>>>> jamal
>>>>>
>>>>> With patch applied I get following error:
>>>>>
>>>>> Test 7d50: Add skbmod action to set destination mac
>>>>> exit: 255 0
>>>>> dst MAC address <11:22:33:44:55:66>
>>>>> RTNETLINK answers: No such file or directory
>>>>> We have an error talking to the kernel
>>>>>
>>>>
>>>> You may actually have broken something with your patches in this case.
>>>
>>> Results is for net-next without my patches.
>>
>> Do you have skbmod compiled in kernel or as a module?
>
> Thanks, already figured out that default config has some actions
> disabled.
> Have more errors now. Everything related to ife:
>
> Test 7682: Create valid ife encode action with mark and pass control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No such file or directory
> We have an error talking to the kernel
>
> Test ef47: Create valid ife encode action with mark and pipe control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No space left on device
> We have an error talking to the kernel
>
> Test df43: Create valid ife encode action with mark and continue control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No space left on device
> We have an error talking to the kernel
>
> Test e4cf: Create valid ife encode action with mark and drop control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No space left on device
> We have an error talking to the kernel
>
> Test ccba: Create valid ife encode action with mark and reclassify control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No space left on device
> We have an error talking to the kernel
>
> Test a1cf: Create valid ife encode action with mark and jump control
> exit: 255 0
> IFE type 0xED3E
> RTNETLINK answers: No space left on device
> We have an error talking to the kernel
>
> ...
>
>

Please make sure you have these in your kernel config:

CONFIG_NET_ACT_IFE=y
CONFIG_NET_IFE_SKBMARK=m
CONFIG_NET_IFE_SKBPRIO=m
CONFIG_NET_IFE_SKBTCINDEX=m

For tdc to run all the tests, it is assumed that all the supported tc
actions/filters are enabled and compiled.