All of lore.kernel.org
 help / color / mirror / Atom feed
From: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
	gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Cc: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Subject: [PATCH 3/4] [Outreachy kernel] staging: qlge: qlge_dbg.c: remove an unneeded variable
Date: Wed, 11 Mar 2020 14:58:14 +0530	[thread overview]
Message-ID: <85f123c8977735a8422bd27d9ca57e12b1833ca2.1583918265.git.payalskshirsagar1234@gmail.com> (raw)
In-Reply-To: <cover.1583918265.git.payalskshirsagar1234@gmail.com>
In-Reply-To: <cover.1583918265.git.payalskshirsagar1234@gmail.com>

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
 drivers/staging/qlge/qlge_dbg.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..f1a6157fb7e1 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -29,15 +29,12 @@ static int ql_write_other_func_reg(struct ql_adapter *qdev,
 				   u32 reg, u32 reg_val)
 {
 	u32 register_to_read;
-	int status = 0;
 
 	register_to_read = MPI_NIC_REG_BLOCK
 				| MPI_NIC_READ
 				| (qdev->alt_func << MPI_NIC_FUNCTION_SHIFT)
 				| reg;
-	status = ql_write_mpi_reg(qdev, register_to_read, reg_val);
-
-	return status;
+	return ql_write_mpi_reg(qdev, register_to_read, reg_val);
 }
 
 static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg,
-- 
2.17.1



  parent reply	other threads:[~2020-03-11  9:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  9:28 [PATCH 0/4] [Outreachy kernel] staging: qlge: remove unneeded variables Payal Kshirsagar
2020-03-11  9:28 ` [PATCH 1/4] [Outreachy kernel] staging: qlge: qlge_main.c: remove an unneeded variable Payal Kshirsagar
2020-03-11  9:28 ` [PATCH 2/4] [Outreachy kernel] staging: qlge: qlge_mpi.c: " Payal Kshirsagar
2020-03-11  9:28 ` Payal Kshirsagar [this message]
2020-03-11  9:28 ` [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: " Payal Kshirsagar
2020-03-11 12:08   ` Stefano Brivio
2020-03-11 12:20     ` Payal Kshirsagar
2020-03-11 12:44       ` Stefano Brivio
2020-03-11 13:46         ` Payal Kshirsagar
2020-03-11 14:31           ` Stefano Brivio
2020-03-11 14:44             ` Payal Kshirsagar
2020-03-11 15:07               ` Julia Lawall
2020-03-11 15:52                 ` Payal Kshirsagar
2020-03-11 16:48                   ` Stefano Brivio
2020-03-11 17:19                   ` Payal Kshirsagar
2020-03-11 20:31                     ` Julia Lawall
2020-03-11 23:12                       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85f123c8977735a8422bd27d9ca57e12b1833ca2.1583918265.git.payalskshirsagar1234@gmail.com \
    --to=payalskshirsagar1234@gmail.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=manishc@marvell.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.