From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B07C433F5 for ; Wed, 22 Sep 2021 10:29:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F2CE60F44 for ; Wed, 22 Sep 2021 10:29:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F2CE60F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSzVa-0007Vm-Sy for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 06:29:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSzUb-0006P1-3M for qemu-devel@nongnu.org; Wed, 22 Sep 2021 06:28:45 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:47086 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSzUZ-0002Ak-Jw for qemu-devel@nongnu.org; Wed, 22 Sep 2021 06:28:44 -0400 Received: from [2a00:23c4:8b9d:4100:5d98:71b5:90ca:dad1] by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mSzUP-0009Zy-AK; Wed, 22 Sep 2021 11:28:37 +0100 To: Laurent Vivier , qemu-devel@nongnu.org References: <20210917075057.20924-1-mark.cave-ayland@ilande.co.uk> <20210917075057.20924-10-mark.cave-ayland@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <85fd0aef-31cb-cc34-250a-ca7f1e74d1e9@ilande.co.uk> Date: Wed, 22 Sep 2021 11:28:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a00:23c4:8b9d:4100:5d98:71b5:90ca:dad1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH v4 09/20] macfb: don't register declaration ROM X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20/09/2021 21:01, Laurent Vivier wrote: > Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : >> The macfb device is an on-board framebuffer and so is initialised by the >> system declaration ROM included within the MacOS toolbox ROM. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/display/macfb.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/hw/display/macfb.c b/hw/display/macfb.c >> index d8183b9bbd..76808b69cc 100644 >> --- a/hw/display/macfb.c >> +++ b/hw/display/macfb.c >> @@ -383,10 +383,6 @@ static void macfb_sysbus_realize(DeviceState *dev, Error **errp) >> sysbus_init_mmio(SYS_BUS_DEVICE(s), &ms->mem_vram); >> } >> >> -const uint8_t macfb_rom[] = { >> - 255, 0, 0, 0, >> -}; >> - >> static void macfb_nubus_realize(DeviceState *dev, Error **errp) >> { >> NubusDevice *nd = NUBUS_DEVICE(dev); >> @@ -399,8 +395,6 @@ static void macfb_nubus_realize(DeviceState *dev, Error **errp) >> macfb_common_realize(dev, ms, errp); >> memory_region_add_subregion(&nd->slot_mem, DAFB_BASE, &ms->mem_ctrl); >> memory_region_add_subregion(&nd->slot_mem, VIDEO_BASE, &ms->mem_vram); >> - >> - nubus_register_rom(nd, macfb_rom, sizeof(macfb_rom), 1, 9, 0xf); >> } >> >> static void macfb_sysbus_reset(DeviceState *d) >> > > Will macfb continue to work with "-kernel" and without providing any MacOS ROM? Yes indeed, since on the Quadra 800 the declaration ROM for the framebuffer is embedded within the MacOS toolbox ROM. ATB, Mark.