From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40643C3F68F for ; Mon, 3 Feb 2020 01:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17439205F4 for ; Mon, 3 Feb 2020 01:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbgBCBqI (ORCPT ); Sun, 2 Feb 2020 20:46:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46746 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726971AbgBCBqI (ORCPT ); Sun, 2 Feb 2020 20:46:08 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 085A328BEFA From: Gabriel Krisman Bertazi To: Daniel Rosenberg Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> Date: Sun, 02 Feb 2020 20:45:59 -0500 In-Reply-To: <20200128230328.183524-2-drosen@google.com> (Daniel Rosenberg's message of "Tue, 28 Jan 2020 15:03:24 -0800") Message-ID: <85sgjsxx2g.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org Daniel Rosenberg writes: > diff --git a/include/linux/unicode.h b/include/linux/unicode.h > index 990aa97d80496..5de313abeaf98 100644 > --- a/include/linux/unicode.h > +++ b/include/linux/unicode.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > struct unicode_map { > const char *charset; > @@ -30,4 +32,19 @@ int utf8_casefold(const struct unicode_map *um, const struct qstr *str, > struct unicode_map *utf8_load(const char *version); > void utf8_unload(struct unicode_map *um); > > +int utf8_ci_d_hash(const struct dentry *dentry, struct qstr *str); > +int utf8_ci_d_compare(const struct dentry *dentry, unsigned int len, > + const char *str, const struct qstr *name); I don't think fs/unicode is the right place for these very specific filesystem functions, just because they happen to use unicode. It is an encoding library, it doesn't care about dentries, nor should know how to handle them. It exposes a simple api to manipulate and convert utf8 strings. I saw change was after the desire to not have these functions polluting the VFS hot path, but that has nothing to do with placing them here. Would libfs be better? or a casefolding library in fs/casefold.c? -- Gabriel Krisman Bertazi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0337BC35249 for ; Mon, 3 Feb 2020 02:03:03 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B66BB20679 for ; Mon, 3 Feb 2020 02:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Uo2fUt8y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="i5Uveyo+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B66BB20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iyR4n-0000sb-Cw; Mon, 03 Feb 2020 02:03:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iyR4m-0000sJ-P7 for linux-f2fs-devel@lists.sourceforge.net; Mon, 03 Feb 2020 02:03:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nUYYIl4IRRlyjjI0vHcmCONz8SS2vgF0ouje8+gD7Tw=; b=Uo2fUt8yfSWbmbev46s764rArA QaAmIKxH2sE2nWcUGOIJqKjQ37u6y0MACFi9LWH/r59pN567/l8R1fWcW4KEJY8r8lWcqX0Ie6oXN K33ZpK8ExbAkaM1+S3/9pR+h1CZgJUD9dWtiNrmR9ZChMj6p0VRQ7u7U1HJCtTA/eH7M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nUYYIl4IRRlyjjI0vHcmCONz8SS2vgF0ouje8+gD7Tw=; b=i5Uveyo+IkZNn66RMO5RLEm/my ysy7sJY4WH+JTa+Sy+Lu/C9XhVSzH2Rs5uQVQK7NlrKigRayBL+WRsHKZ9csBsKgavyDQpfXSL+rI OqFj1xDtE0yUkupR/bvpGmyXqGo8xipp9KRfPTU8SPpAWlvTzBg1UWrThDFyyxEYderA=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iyR4i-008gWo-KP for linux-f2fs-devel@lists.sourceforge.net; Mon, 03 Feb 2020 02:03:00 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 085A328BEFA From: Gabriel Krisman Bertazi To: Daniel Rosenberg Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> Date: Sun, 02 Feb 2020 20:45:59 -0500 In-Reply-To: <20200128230328.183524-2-drosen@google.com> (Daniel Rosenberg's message of "Tue, 28 Jan 2020 15:03:24 -0800") Message-ID: <85sgjsxx2g.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1iyR4i-008gWo-KP Subject: Re: [f2fs-dev] [PATCH v6 1/5] unicode: Add standard casefolded d_ops X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Daniel Rosenberg writes: > diff --git a/include/linux/unicode.h b/include/linux/unicode.h > index 990aa97d80496..5de313abeaf98 100644 > --- a/include/linux/unicode.h > +++ b/include/linux/unicode.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > struct unicode_map { > const char *charset; > @@ -30,4 +32,19 @@ int utf8_casefold(const struct unicode_map *um, const struct qstr *str, > struct unicode_map *utf8_load(const char *version); > void utf8_unload(struct unicode_map *um); > > +int utf8_ci_d_hash(const struct dentry *dentry, struct qstr *str); > +int utf8_ci_d_compare(const struct dentry *dentry, unsigned int len, > + const char *str, const struct qstr *name); I don't think fs/unicode is the right place for these very specific filesystem functions, just because they happen to use unicode. It is an encoding library, it doesn't care about dentries, nor should know how to handle them. It exposes a simple api to manipulate and convert utf8 strings. I saw change was after the desire to not have these functions polluting the VFS hot path, but that has nothing to do with placing them here. Would libfs be better? or a casefolding library in fs/casefold.c? -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7F9C35249 for ; Mon, 3 Feb 2020 01:46:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41B38205F4 for ; Mon, 3 Feb 2020 01:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ANX1fQei" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41B38205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EYxrjom9coG+qhk+bI27KFDQY6QPA+Q+Pf5LjD0qlDE=; b=ANX1fQeiQT64Ap pS1+uHaOYO/Y56IqYyPZF0S2mnDQ22NG0i+V4p67C+MzZ+QYwQ9cxQNIqFfwzHhW2WaCF4IvpSK5n EFEa9SSh+Dk8l84CrPFxQmuS/oJBvvKjP8XGP7llp1f4RHx+0MRAsELjHXP2dU+Q8IndrQwWI707E oNHAmWzrUzei+cRjsj6c7TshK0T4FTUrdu8Nv39M3l6Z/rcPy9AWhZtCUACM4tsntaTqKvE9/rJLb 1lJ+bXxRInt6JQn7w7ppAjBjoSITIhy2Mhg+WK7IxHqNMyeV05+x87FRu23R0Vr3Y/LxcJmXclY8K LeNnfwCm74ZnBWxqIhkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iyQoY-00063x-2w; Mon, 03 Feb 2020 01:46:14 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iyQoU-00063V-JX for linux-mtd@lists.infradead.org; Mon, 03 Feb 2020 01:46:12 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 085A328BEFA From: Gabriel Krisman Bertazi To: Daniel Rosenberg Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> Date: Sun, 02 Feb 2020 20:45:59 -0500 In-Reply-To: <20200128230328.183524-2-drosen@google.com> (Daniel Rosenberg's message of "Tue, 28 Jan 2020 15:03:24 -0800") Message-ID: <85sgjsxx2g.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200202_174610_773716_D3997F43 X-CRM114-Status: GOOD ( 11.12 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , Chao Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Daniel Rosenberg writes: > diff --git a/include/linux/unicode.h b/include/linux/unicode.h > index 990aa97d80496..5de313abeaf98 100644 > --- a/include/linux/unicode.h > +++ b/include/linux/unicode.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > struct unicode_map { > const char *charset; > @@ -30,4 +32,19 @@ int utf8_casefold(const struct unicode_map *um, const struct qstr *str, > struct unicode_map *utf8_load(const char *version); > void utf8_unload(struct unicode_map *um); > > +int utf8_ci_d_hash(const struct dentry *dentry, struct qstr *str); > +int utf8_ci_d_compare(const struct dentry *dentry, unsigned int len, > + const char *str, const struct qstr *name); I don't think fs/unicode is the right place for these very specific filesystem functions, just because they happen to use unicode. It is an encoding library, it doesn't care about dentries, nor should know how to handle them. It exposes a simple api to manipulate and convert utf8 strings. I saw change was after the desire to not have these functions polluting the VFS hot path, but that has nothing to do with placing them here. Would libfs be better? or a casefolding library in fs/casefold.c? -- Gabriel Krisman Bertazi ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/