From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A702C433EF for ; Mon, 22 Nov 2021 01:41:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E50FC83012; Mon, 22 Nov 2021 02:41:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 53F0283515; Mon, 22 Nov 2021 02:41:55 +0100 (CET) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08C5C82F6A for ; Mon, 22 Nov 2021 02:41:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=jon.lin@rock-chips.com Received: from localhost (unknown [192.168.167.172]) by regular1.263xmail.com (Postfix) with ESMTP id 092E69BE for ; Mon, 22 Nov 2021 09:41:47 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [172.16.12.40] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P31753T140657070954240S1637545305243289_; Mon, 22 Nov 2021 09:41:46 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: jon.lin@rock-chips.com X-SENDER: jon.lin@rock-chips.com X-LOGIN-NAME: jon.lin@rock-chips.com X-FST-TO: kever.yang@rock-chips.com X-RCPT-COUNT: 7 X-LOCAL-RCPT-COUNT: 4 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: X-System-Flag: 0 Subject: Re: [PATCH v3 1/2] nvme: Enable FUA To: Tom Rini , Bin Meng Cc: U-Boot Mailing List , xxm@rock-chips.com, Lin Shawn , zyf@rock-chips.com, Kever Yang References: <20211019104049.v3.1.Ic581ec99f46b6dfa2e0b1922e670a333ac859e82@changeid> <20211118191449.GI24579@bill-the-cat> <20211119011424.GG24579@bill-the-cat> From: Jon Lin Message-ID: <860dd4ac-4027-c8de-b6b6-5e90150dbecf@rock-chips.com> Date: Mon, 22 Nov 2021 09:41:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211119011424.GG24579@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/11/19 9:14, Tom Rini wrote: > On Fri, Nov 19, 2021 at 08:56:08AM +0800, Bin Meng wrote: >> Hi Tom, >> >> On Fri, Nov 19, 2021 at 3:14 AM Tom Rini wrote: >>> On Tue, Oct 19, 2021 at 10:40:53AM +0800, Jon Lin wrote: >>> >>>> Most NVME devcies maintain data in internal cache for an uncertain >>>> times, and u-boot has no method to force NVME to flush cache. >>>> So this patch adds FUA to avoid data loss caused by power off after data >>>> programming. >>>> >>>> Signed-off-by: Jon Lin >>>> Reviewed-by: Stefan Agner >>> Applied to u-boot/next, thanks! >> I don't see my review comment being addressed. Please drop the patch >> until all things are clear. > Missed your comments, sorry. Thanks to bin Meng and Tom. I'm not familiar with nvme protocol. I expect people with nvme experience to take over the patch and do the most reasonable treatment. Of course, I'll take some time to seriously ponder the nvme process to see if it can meet your requirements