From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdDACPK (ORCPT ); Fri, 31 Mar 2017 22:15:10 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:39774 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdDACPI (ORCPT ); Fri, 31 Mar 2017 22:15:08 -0400 Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning To: Chewie Lin , greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170401015919.9181-1-linsh@oregonstate.edu> <20170401015919.9181-2-linsh@oregonstate.edu> From: Randy Dunlap Message-ID: <861e5179-270f-ce93-4d9c-9732945bf8c1@infradead.org> Date: Fri, 31 Mar 2017 19:15:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170401015919.9181-2-linsh@oregonstate.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/17 18:59, Chewie Lin wrote: > Replace string with formatted arguments in the dev_warn() call. It removes > the checkpatch warning: > > WARNING: Prefer using "%s", __func__ to embedded function names > #417: FILE: main_usb.c:417: > + "usb_device_reset fail status=%d\n", status); > > total: 0 errors, 1 warnings, 1058 lines checked > > And after fix: > > main_usb.c has no obvious style problems and is ready for submission. > > Signed-off-by: Chewie Lin > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > index 9e074e9..2d9e7af 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > status = usb_reset_device(priv->usb); > if (status) > dev_warn(&priv->usb->dev, > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); > } > > static void vnt_free_int_bufs(struct vnt_private *priv) > As other people have said: This function is usb_device_reset(). If that function name string is to be used in the message, it should be done so by using __func__. See http://marc.info/?l=linux-driver-devel&m=149095639202492&w=2 Or is the called (failing) function name is to be kept in the message (as it is currently), then the message should contain "usb_reset_device" instead of "usb_device_reset". See http://marc.info/?l=linux-driver-devel&m=149098680312723&w=2 -- ~Randy