From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D4AC2D0A8 for ; Wed, 23 Sep 2020 08:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9D49235FC for ; Wed, 23 Sep 2020 08:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="dGD/kF+p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbgIWIe2 (ORCPT ); Wed, 23 Sep 2020 04:34:28 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:4049 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbgIWIe2 (ORCPT ); Wed, 23 Sep 2020 04:34:28 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 23 Sep 2020 01:33:41 -0700 Received: from [10.26.74.254] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 23 Sep 2020 08:34:20 +0000 Subject: Re: [Patch 1/2] cpufreq: tegra194: get consistent cpuinfo_cur_freq From: Jon Hunter To: Sumit Gupta , , , , , , , , CC: , References: <1600276277-7290-1-git-send-email-sumitg@nvidia.com> <1600276277-7290-2-git-send-email-sumitg@nvidia.com> <81d2517d-6581-b491-c509-832fd1c0321e@nvidia.com> <6dcc664e-e4d2-6334-f0f5-4ead5935cbc7@nvidia.com> Message-ID: <86356902-5488-bb34-70a4-b6a916ccca7d@nvidia.com> Date: Wed, 23 Sep 2020 09:34:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6dcc664e-e4d2-6334-f0f5-4ead5935cbc7@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600850021; bh=2pX9LlyppSFkcWLjsdQA46jR7c0N+/P/KPu5e9cVUhM=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=dGD/kF+pgPYMk/1CEZkcw2a9lw7N8AO3y3kPAuqAL24H7ca3RJJ86STmfXc5a/o/e iKJqVcjnei95TFbVognObhEza+h+9snfgLX+9i4gpFqMenjxRM2/FYILSDy7U79OoR YxOSUP6VQwxu6uIXsfsJ0a3tCUsVmB7mR2U7hWLZnykVY2cA1Jt4bwiaZYxn7oRPUd j0KKI2IZfsINA7FvHIgGn8Mjy3hWrZMbSBT1399IZi2tJhrs7C0fFpwrv2BSRdZ7AQ cfnHpiaZMzjYpOHTWcJmEjGRPKZvve8IMOo7FbU3cmQL7Ztgldd65Igj7a5VpK03hv Usasw0dtKaDiA== Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Rafael, Sudeep, On 17/09/2020 09:44, Jon Hunter wrote: > Adding Sudeep ... > > On 17/09/2020 09:36, Jon Hunter wrote: >> >> >> On 16/09/2020 18:11, Sumit Gupta wrote: >>> Frequency returned by 'cpuinfo_cur_freq' using counters is not fixed >>> and keeps changing slightly. This change returns a consistent value >>> from freq_table. If the reconstructed frequency has acceptable delta >>> from the last written value, then return the frequency corresponding >>> to the last written ndiv value from freq_table. Otherwise, print a >>> warning and return the reconstructed freq. >> >> We should include the Fixes tag here ... >> >> Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") >> >>> >>> Signed-off-by: Sumit Gupta >> >> Otherwise ... >> >> Reviewed-by: Jon Hunter >> Tested-by: Jon Hunter >> >> Viresh, ideally we need to include this fix for v5.9. Do you need Sumit >> to resend with the Fixes tag or are you happy to add? > > > Sudeep, Rafael, looks like Viresh is out of office until next month. > Please let me know if we can pick up both this patch and following patch > for v5.9. Any chance we can get these patches into v5.9? Thanks! Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28943C4727D for ; Wed, 23 Sep 2020 08:36:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B08EB20773 for ; Wed, 23 Sep 2020 08:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qnTz2rgq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="dGD/kF+p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B08EB20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7zNCwN2HBQhRbNSXfQGxwLOmD08DYIUyKONtDiOtGNY=; b=qnTz2rgqWo98vWBTC8LijkufN S1W/xVf3YfESYHvQiCnhxZvc4+lmq3A77ELbOB2EoGGNR/GAIESXSvGQoBOApTzCR3aEWN0pBZ9ze 4lpxOeM15BnoUTCaRmrkYBdTOkCISYHSROXZv+6bNqU0PCtgVm9dXkqmEW0lfIy7b8s1daVysoNiT qwNYgdilAV9SsWjwxUXuMoe2/LH+/sbOggC0yUraNHH6fyX4fTvJ+rHJFaF7iydRxkSZtdZJhysob wOHPCXFtywDfJb3RyhkbV4R3d9HsB1dLDOZ1jmscNIqLXzPczlr0nkyvB3T4vUpl/5nFAupO++R/s kxzBvDbBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0Ec-0006Di-N9; Wed, 23 Sep 2020 08:34:42 +0000 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0Ea-0006C4-1s for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 08:34:40 +0000 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 23 Sep 2020 01:33:41 -0700 Received: from [10.26.74.254] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 23 Sep 2020 08:34:20 +0000 Subject: Re: [Patch 1/2] cpufreq: tegra194: get consistent cpuinfo_cur_freq From: Jon Hunter To: Sumit Gupta , , , , , , , , References: <1600276277-7290-1-git-send-email-sumitg@nvidia.com> <1600276277-7290-2-git-send-email-sumitg@nvidia.com> <81d2517d-6581-b491-c509-832fd1c0321e@nvidia.com> <6dcc664e-e4d2-6334-f0f5-4ead5935cbc7@nvidia.com> Message-ID: <86356902-5488-bb34-70a4-b6a916ccca7d@nvidia.com> Date: Wed, 23 Sep 2020 09:34:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6dcc664e-e4d2-6334-f0f5-4ead5935cbc7@nvidia.com> Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600850021; bh=2pX9LlyppSFkcWLjsdQA46jR7c0N+/P/KPu5e9cVUhM=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=dGD/kF+pgPYMk/1CEZkcw2a9lw7N8AO3y3kPAuqAL24H7ca3RJJ86STmfXc5a/o/e iKJqVcjnei95TFbVognObhEza+h+9snfgLX+9i4gpFqMenjxRM2/FYILSDy7U79OoR YxOSUP6VQwxu6uIXsfsJ0a3tCUsVmB7mR2U7hWLZnykVY2cA1Jt4bwiaZYxn7oRPUd j0KKI2IZfsINA7FvHIgGn8Mjy3hWrZMbSBT1399IZi2tJhrs7C0fFpwrv2BSRdZ7AQ cfnHpiaZMzjYpOHTWcJmEjGRPKZvve8IMOo7FbU3cmQL7Ztgldd65Igj7a5VpK03hv Usasw0dtKaDiA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_043440_171420_FA900D58 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ksitaraman@nvidia.com, bbasu@nvidia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rafael, Sudeep, On 17/09/2020 09:44, Jon Hunter wrote: > Adding Sudeep ... > > On 17/09/2020 09:36, Jon Hunter wrote: >> >> >> On 16/09/2020 18:11, Sumit Gupta wrote: >>> Frequency returned by 'cpuinfo_cur_freq' using counters is not fixed >>> and keeps changing slightly. This change returns a consistent value >>> from freq_table. If the reconstructed frequency has acceptable delta >>> from the last written value, then return the frequency corresponding >>> to the last written ndiv value from freq_table. Otherwise, print a >>> warning and return the reconstructed freq. >> >> We should include the Fixes tag here ... >> >> Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") >> >>> >>> Signed-off-by: Sumit Gupta >> >> Otherwise ... >> >> Reviewed-by: Jon Hunter >> Tested-by: Jon Hunter >> >> Viresh, ideally we need to include this fix for v5.9. Do you need Sumit >> to resend with the Fixes tag or are you happy to add? > > > Sudeep, Rafael, looks like Viresh is out of office until next month. > Please let me know if we can pick up both this patch and following patch > for v5.9. Any chance we can get these patches into v5.9? Thanks! Jon -- nvpublic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel