From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936071AbdEVVoe (ORCPT ); Mon, 22 May 2017 17:44:34 -0400 Received: from terminus.zytor.com ([65.50.211.136]:33227 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934285AbdEVVoc (ORCPT ); Mon, 22 May 2017 17:44:32 -0400 Subject: Re: [PATCH 7/7] DWARF: add the config option From: "H. Peter Anvin" To: "H.J. Lu" , Josh Poimboeuf Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , Jiri Slaby , Andrew Morton , live-patching@vger.kernel.org, Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Jiri Kosina , Linus Torvalds References: <20170505122200.31436-1-jslaby@suse.cz> <20170505122200.31436-7-jslaby@suse.cz> <20170507165524.cdxfuwbd5alr7v6k@treble> <20170519205354.caeyqri2k6gvso3w@treble> <8dbbb971-fc41-fba2-f356-931a7eabe6ef@zytor.com> <20170519212913.otir6mlujoxoy3ha@treble> <20170519213556.pv5kxocfprfkloay@treble> <20170520162034.fcciinh3nw5mvad5@treble> Message-ID: <863bff71-0574-5093-ff45-2d68aedba906@zytor.com> Date: Mon, 22 May 2017 14:37:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/17 14:07, H. Peter Anvin wrote: > On 05/20/17 13:01, H.J. Lu wrote: >> On Sat, May 20, 2017 at 9:20 AM, Josh Poimboeuf wrote: >> >>>> >>>> (H.J., could we get a binutils feature that allows is to do: >>>> >>>> pushq %whatever >>>> .cfi_adjust_sp -8 >>>> ... >>>> popq %whatever >>>> .cfi_adjust_sp 8 >>>> >> >> Np. Compiler needs to generate this. >> > > For actual assembly we have such a feature, it is called macros. > > push/pop is the easy stuff; macros take care of that, but the real pain > is dealing with the flow of control. > My biggest beef with the CFI directives that gas uses is that there is that .cfi_remember_state/.cfi_restore_state doesn't have a way to specify more than one state. That makes it really hard to get sanity around control flow changes, especially with code that is intentionally out of line. That, and some of the CFI directives seem to be a bit ill-defined in their definition (are they even applicable to anything other than DWARF?) They almost seem to be referencing some external specification, but the only thing I'm finding is the DWARF documentation which is written in very different terms. The best description of what a personality routine is I found in an article by Ian Lance Taylor. It doesn't seem to be applicable to C as far as I can tell. -hpa