From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B48C47094 for ; Thu, 10 Jun 2021 05:13:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A350613D9 for ; Thu, 10 Jun 2021 05:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A350613D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 240E782CBE; Thu, 10 Jun 2021 07:13:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1623301981; bh=fBvaVWumKtwK02TbkqL01AD54xygE8tXPx87jxAE83c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=xdz7Jo7nNR2pYhLGTN0m3V5a2xjKWxI8+HaDpkS3zYfNxlrtX2cHbygqAbTfKWIVW VHfVW88DceJZ3SY2lWDrCKffusXM6UDdAdk11TVytvBk93M8q6x1oz7PEr+4Szw1Fl z8udjOtxhCAwovlQ/WNJjioKw47qhmpEs52YVUOYBACuJ74OOU8+G8GvXi2+0KQtAd 8X7L7PuJMuKo+kYU1+SyD6O664e6xtvz/kWBtiWZtPBqbkWWs/DP2JsqZZbcIwdZol 4VdotRAWophPrYcwP/SULqDaX2ffj4l17ssOX7yskum7bFX+aTowSbz7XZvIc6/GpH aZrtRF8UU6vTw== Received: by phobos.denx.de (Postfix, from userid 109) id 7DF5B82D6E; Thu, 10 Jun 2021 07:12:59 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F34F80377 for ; Thu, 10 Jun 2021 07:12:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4G0sYj0CkJzQjYX; Thu, 10 Jun 2021 07:12:57 +0200 (CEST) Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id VGGhNBsXZjIq; Thu, 10 Jun 2021 07:12:54 +0200 (CEST) Subject: Re: [PATCH u-boot-marvell v2 5/6] arm: mvebu: dts: turris_mox: add nodes for SPI NOR partitions To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de References: <20210607143451.5343-1-marek.behun@nic.cz> <20210607143451.5343-6-marek.behun@nic.cz> <20210608095131.bczcdi632j6fhvds@pali> From: Stefan Roese Message-ID: <86412efd-1d6b-3c54-e83b-aab5ed4355ba@denx.de> Date: Thu, 10 Jun 2021 07:12:53 +0200 MIME-Version: 1.0 In-Reply-To: <20210608095131.bczcdi632j6fhvds@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -8.87 / 15.00 / 15.00 X-Rspamd-Queue-Id: 2285C1857 X-Rspamd-UID: 1deba9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On 08.06.21 11:51, Pali Rohár wrote: > On Monday 07 June 2021 16:34:50 Marek Behún wrote: >> Add nodes for SPI NOR partitions to the device tree of Turris MOX, as >> are in Linux' device tree. > > This patch is not needed (for now) as U-Boot cannot parse SPI NOR > partitions from DT yet. U-Boot for SPI NOR currently supports specifying > partitions only via CONFIG_MTDPARTS_DEFAULT compile option. But do you agree that this patch "does not hurt"? I'm asking to check, if I should include this patch in a potential pull request. Thanks, Stefan >> Signed-off-by: Marek Behún >> --- >> arch/arm/dts/armada-3720-turris-mox.dts | 31 +++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts >> index 741b0eeeee..f47ced05c5 100644 >> --- a/arch/arm/dts/armada-3720-turris-mox.dts >> +++ b/arch/arm/dts/armada-3720-turris-mox.dts >> @@ -164,6 +164,37 @@ >> reg = <0>; >> spi-max-frequency = <20000000>; >> m25p,fast-read; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + partition@0 { >> + label = "secure-firmware"; >> + reg = <0x0 0x20000>; >> + }; >> + >> + partition@20000 { >> + label = "a53-firmware"; >> + reg = <0x20000 0x160000>; >> + }; >> + >> + partition@180000 { >> + label = "u-boot-env"; >> + reg = <0x180000 0x10000>; >> + }; >> + >> + partition@190000 { >> + label = "Rescue system"; >> + reg = <0x190000 0x660000>; >> + }; >> + >> + partition@7f0000 { >> + label = "dtb"; >> + reg = <0x7f0000 0x10000>; >> + }; >> + }; >> }; >> >> moxtet@1 { >> -- >> 2.31.1 >> Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de