From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Marek Behun <marek.behun@nic.cz>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem
Date: Thu, 19 Aug 2021 18:48:53 +0800 [thread overview]
Message-ID: <86433c79-cf7f-6575-4405-6941625266d1@gmx.com> (raw)
In-Reply-To: <20210818214022.4.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid>
On 2021/8/19 上午11:40, Simon Glass wrote:
> This message comes up a lot when scanning filesystems. It suggests to the
> user that there is some sort of error, but in fact there is no reason to
> expect that a particular partition has a btrfs filesystem. Other
> filesystems don't print this error.
>
> Turn it into a debug message.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
>
> fs/btrfs/disk-io.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 349411c3ccd..1b69346e231 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -886,7 +886,11 @@ static int btrfs_scan_fs_devices(struct blk_desc *desc,
>
> ret = btrfs_scan_one_device(desc, part, fs_devices, &total_devs);
> if (ret) {
> - fprintf(stderr, "No valid Btrfs found\n");
> + /*
> + * Avoid showing this when probing for a possible Btrfs
> + *
> + * fprintf(stderr, "No valid Btrfs found\n");
> + */
> return ret;
> }
> return 0;
> @@ -975,7 +979,7 @@ struct btrfs_fs_info *open_ctree_fs_info(struct blk_desc *desc,
> disk_super = fs_info->super_copy;
> ret = btrfs_read_dev_super(desc, part, disk_super);
> if (ret) {
> - printk("No valid btrfs found\n");
> + debug("No valid btrfs found\n");
> goto out_devices;
> }
>
>
next prev parent reply other threads:[~2021-08-19 10:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 3:40 [PATCH 00/11] sandbox: Minor fixes and improvements Simon Glass
2021-08-19 3:40 ` [PATCH 01/11] dtoc: Further improve documentation about warnings Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 02/11] sandbox: Correct handling of --rm_memory Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 03/11] sandbox: Add license headers to the dts files Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 04/11] btrfs: Suppress the message about missing filesystem Simon Glass
2021-08-19 10:31 ` Marek Behún
2021-08-19 10:48 ` Qu Wenruo [this message]
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 05/11] sqfs: " Simon Glass
2021-08-19 7:03 ` Miquel Raynal
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 06/11] test: Tidy a comment in the bloblist test Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 07/11] dm: core: Fix a few incorrect comments on first/next functions Simon Glass
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 08/11] sandbox: Add a way to find the size of a file Simon Glass
2021-08-19 10:27 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 09/11] sandbox: Add a way to map a file into memory Simon Glass
2021-08-19 10:28 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-09-24 2:48 ` Simon Glass
2021-08-19 3:40 ` [PATCH 10/11] sandbox: mmc: Support a backing file Simon Glass
2021-08-28 5:15 ` Jaehoon Chung
2021-08-28 6:39 ` Sean Anderson
2021-09-18 9:34 ` Simon Glass
2021-09-16 18:40 ` Tom Rini
2021-09-18 9:34 ` Simon Glass
2021-09-18 13:16 ` Tom Rini
2021-09-18 16:31 ` Simon Glass
2021-09-20 3:18 ` Simon Glass
2021-10-21 20:17 ` Simon Glass
2021-08-19 3:40 ` [PATCH 11/11] test: Add a way to skip console checking until a string matches Simon Glass
2021-09-23 2:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86433c79-cf7f-6575-4405-6941625266d1@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.