From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DA5C433E1 for ; Wed, 27 May 2020 15:54:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2846620899 for ; Wed, 27 May 2020 15:54:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B0wz/dHH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2846620899 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdyNU-0003ux-DI for qemu-devel@archiver.kernel.org; Wed, 27 May 2020 11:54:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdyMw-0003Q8-1V for qemu-devel@nongnu.org; Wed, 27 May 2020 11:53:26 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:21735 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdyMu-0006bC-AV for qemu-devel@nongnu.org; Wed, 27 May 2020 11:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590594802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O2Zk9sYuEw46IaqyvVK2r3MBhzi7/nhAUb/0KJV7qBE=; b=B0wz/dHHkyGKDxvWroaPmHpeSnZbt+mkqvfModFGLaTNNAUIycJRqhukCNSGeG4dj60tgV /9ZG6ZgCW/MQMr0WTRqJRDxOgkye10/kplQugAeZHZc3c44tA4ggSFkpKUDJyywmOQ6r4R Lqy99XUlN6w8pUX/bnxxRjhmz5rCgIw= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-5z_4ttklNJKdSjrKZiZoiQ-1; Wed, 27 May 2020 11:53:20 -0400 X-MC-Unique: 5z_4ttklNJKdSjrKZiZoiQ-1 Received: by mail-ej1-f71.google.com with SMTP id hb26so5131000ejb.16 for ; Wed, 27 May 2020 08:53:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=O2Zk9sYuEw46IaqyvVK2r3MBhzi7/nhAUb/0KJV7qBE=; b=SDJ8twJ161e1fS8iljhAP+8hiesjEE99Qh/QGrX976cw8j1ocQCANEa/oIOH+lzZKC HBy3Cc8f5vv+TSx8BdGPQad2kaxaZhawc8kWZdtisiibRcUz9/42hEz1h8XtGEYBD+dh 18x+qMOEz68G94F4OM9c6I8lAfsQzsdFoFYT9+GIsrEaQdVlGIKHpcPOVBwAPZQNy2JW qmvU/JpUI1FqOjvOwrv69GhVhRA9ZD/hf3PSXZsYoyes2FoeE0tMKB43BsNZl6OkWaSp 4WhWInbQ4sWMWxtOVPZR9/09hphKWIraZBkOu5SckLptHszPyG+UIHFEiKFyWGuSP9IQ jI3w== X-Gm-Message-State: AOAM5311XdNsOLSC/yDcGwW04ZEfJm/bZrN8iJ7bM4zwcTaf/Z5Hibgw tqlmzzpR13Mj/CjdZMfPW5Byxn6rPpf9Bjj7zyyjJ5uNKBsoFacwvwziJWiOchsewjr/bUZ2EXL GW5RMwAUVYE2n2bc= X-Received: by 2002:a17:906:d215:: with SMTP id w21mr6462521ejz.383.1590594798993; Wed, 27 May 2020 08:53:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZUvd+zaMv2O9Ynd6Hpq4Pfs42Qp6m+UZAUetlFFF3ZsexPjpRwbZkR4slH/oLkAV7x/TqHA== X-Received: by 2002:a17:906:d215:: with SMTP id w21mr6462503ejz.383.1590594798709; Wed, 27 May 2020 08:53:18 -0700 (PDT) Received: from [192.168.1.36] (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id dk11sm2431787edb.67.2020.05.27.08.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 08:53:18 -0700 (PDT) Subject: Re: [PATCH] hw/vfio/common: Trace in which mode a IOMMU is opened From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Auger Eric , qemu-devel@nongnu.org References: <20200526173542.28710-1-philmd@redhat.com> <6c7c445d-0335-f67d-bb72-5b0c046bb247@redhat.com> <24f88212-9b32-b6dc-fcd4-685cde8bf5d7@redhat.com> Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <864ac8ab-e21e-393e-d1eb-08b3c4579bbf@redhat.com> Date: Wed, 27 May 2020 17:53:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <24f88212-9b32-b6dc-fcd4-685cde8bf5d7@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/27 05:46:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , Cornelia Huck , Peter Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/27/20 9:43 AM, Philippe Mathieu-Daudé wrote: > On 5/27/20 9:08 AM, Auger Eric wrote: >> Hi Philippe, >> >> On 5/26/20 7:35 PM, Philippe Mathieu-Daudé wrote: >>> One might want to check which IOMMU version the host kernel >>> provide. Add a trace event to see in which mode we opened >>> our container. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> hw/vfio/common.c | 19 ++++++++++++++----- >>> hw/vfio/trace-events | 1 + >>> 2 files changed, 15 insertions(+), 5 deletions(-) >>> >>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c >>> index 0b3593b3c0..6b69a259c1 100644 >>> --- a/hw/vfio/common.c >>> +++ b/hw/vfio/common.c >>> @@ -1157,15 +1157,24 @@ static void vfio_put_address_space(VFIOAddressSpace *space) >>> static int vfio_get_iommu_type(VFIOContainer *container, >>> Error **errp) >>> { >>> - int iommu_types[] = { VFIO_TYPE1v2_IOMMU, VFIO_TYPE1_IOMMU, >>> - VFIO_SPAPR_TCE_v2_IOMMU, VFIO_SPAPR_TCE_IOMMU }; >>> + static const struct { >>> + int type; >>> + const char *name; >>> + } iommu[] = { >>> + {VFIO_TYPE1v2_IOMMU, "Type1 (v2)"}, >>> + {VFIO_TYPE1_IOMMU, "Type1 (v1)"}, >>> + {VFIO_SPAPR_TCE_v2_IOMMU, "sPAPR TCE (v2)"}, >>> + {VFIO_SPAPR_TCE_IOMMU, "sPAPR TCE (v1)"} >>> + }; >>> int i; >>> >>> - for (i = 0; i < ARRAY_SIZE(iommu_types); i++) { >>> - if (ioctl(container->fd, VFIO_CHECK_EXTENSION, iommu_types[i])) { >>> - return iommu_types[i]; >>> + for (i = 0; i < ARRAY_SIZE(iommu); i++) { >>> + if (ioctl(container->fd, VFIO_CHECK_EXTENSION, iommu[i].type)) { >>> + trace_vfio_get_iommu_type(iommu[i].type, iommu[i].name); >> Just wondering why you want to trace the type as you now have the name >> string. > > You are right :) > >>> + return iommu[i].type; >>> } >>> } >>> + trace_vfio_get_iommu_type(-1, "Not available or not supported"); >> nit: from a debugging pov, this may be not needed as >> vfio_get_group/vfio_connect_container() fails and this leads to an error >> output. But you can reach this for example using No-IOMMU. If you don't mind, I find having this information in the trace log clearer. > > Indeed. > > Thanks for the review! > >> >> Thanks >> >> Eric >>> error_setg(errp, "No available IOMMU models"); >>> return -EINVAL; >>> } >>> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events >>> index b1ef55a33f..8166c4c50d 100644 >>> --- a/hw/vfio/trace-events >>> +++ b/hw/vfio/trace-events >>> @@ -115,6 +115,7 @@ vfio_region_sparse_mmap_header(const char *name, int index, int nr_areas) "Devic >>> vfio_region_sparse_mmap_entry(int i, unsigned long start, unsigned long end) "sparse entry %d [0x%lx - 0x%lx]" >>> vfio_get_dev_region(const char *name, int index, uint32_t type, uint32_t subtype) "%s index %d, %08x/%0x8" >>> vfio_dma_unmap_overflow_workaround(void) "" >>> +vfio_get_iommu_type(int iommu_type, const char *iommu_name) "IOMMU type %d (%s)" >>> >>> # platform.c >>> vfio_platform_base_device_init(char *name, int groupid) "%s belongs to group #%d" >>> >> >