All of lore.kernel.org
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/nfp: remove compile time log
@ 2021-05-18 10:41 Ferruh Yigit
  2021-06-28 11:13 ` Andrew Rybchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2021-05-18 10:41 UTC (permalink / raw)
  To: Heinrich Kuhn; +Cc: Ferruh Yigit, dev

Logging should be converted to dynamic log.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/nfp/nfp_net_logs.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
index 27dd87611b94..76cc94cb6565 100644
--- a/drivers/net/nfp/nfp_net_logs.h
+++ b/drivers/net/nfp/nfp_net_logs.h
@@ -30,14 +30,7 @@ extern int nfp_logtype_init;
 #define ASSERT(x) do { } while (0)
 #endif
 
-#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
-
-#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
-#define PMD_CPP_LOG(level, fmt, args...) \
-	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
-#else
 #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
-#endif
 
 extern int nfp_logtype_driver;
 #define PMD_DRV_LOG(level, fmt, args...) \
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
  2021-05-18 10:41 [dpdk-dev] [PATCH] net/nfp: remove compile time log Ferruh Yigit
@ 2021-06-28 11:13 ` Andrew Rybchenko
  2021-07-23 14:14   ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Rybchenko @ 2021-06-28 11:13 UTC (permalink / raw)
  To: Heinrich Kuhn; +Cc: dev, Ferruh Yigit

Hi Heinrich,

could you take a look at the patch?

Thanks,
Andrew.

On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> Logging should be converted to dynamic log.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> index 27dd87611b94..76cc94cb6565 100644
> --- a/drivers/net/nfp/nfp_net_logs.h
> +++ b/drivers/net/nfp/nfp_net_logs.h
> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>   #define ASSERT(x) do { } while (0)
>   #endif
>   
> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -
> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -#define PMD_CPP_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> -#else
>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> -#endif
>   
>   extern int nfp_logtype_driver;
>   #define PMD_DRV_LOG(level, fmt, args...) \
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
  2021-06-28 11:13 ` Andrew Rybchenko
@ 2021-07-23 14:14   ` Thomas Monjalon
  2021-07-29 12:18     ` Heinrich Kuhn
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2021-07-23 14:14 UTC (permalink / raw)
  To: Heinrich Kuhn; +Cc: dev, Ferruh Yigit, Andrew Rybchenko

Please review.

28/06/2021 13:13, Andrew Rybchenko:
> Hi Heinrich,
> 
> could you take a look at the patch?
> 
> Thanks,
> Andrew.
> 
> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> > Logging should be converted to dynamic log.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >   drivers/net/nfp/nfp_net_logs.h | 7 -------
> >   1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> > index 27dd87611b94..76cc94cb6565 100644
> > --- a/drivers/net/nfp/nfp_net_logs.h
> > +++ b/drivers/net/nfp/nfp_net_logs.h
> > @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
> >   #define ASSERT(x) do { } while (0)
> >   #endif
> >   
> > -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> > -
> > -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> > -#define PMD_CPP_LOG(level, fmt, args...) \
> > -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> > -#else
> >   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> > -#endif
> >   
> >   extern int nfp_logtype_driver;
> >   #define PMD_DRV_LOG(level, fmt, args...) \




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
  2021-07-23 14:14   ` Thomas Monjalon
@ 2021-07-29 12:18     ` Heinrich Kuhn
  2021-08-16 14:04       ` Ferruh Yigit
  0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Kuhn @ 2021-07-29 12:18 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Ferruh Yigit, Andrew Rybchenko



On 2021/07/23 16:14, Thomas Monjalon wrote:
> Please review.
> 
> 28/06/2021 13:13, Andrew Rybchenko:
>> Hi Heinrich,
>>
>> could you take a look at the patch?
>>
>> Thanks,
>> Andrew.
>>
>> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
>>> Logging should be converted to dynamic log.
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>>>   1 file changed, 7 deletions(-)
>>>
>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
>>> index 27dd87611b94..76cc94cb6565 100644
>>> --- a/drivers/net/nfp/nfp_net_logs.h
>>> +++ b/drivers/net/nfp/nfp_net_logs.h
>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>>>   #define ASSERT(x) do { } while (0)
>>>   #endif
>>>   
>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -
>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -#define PMD_CPP_LOG(level, fmt, args...) \
>>> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
>>> -#else
>>>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>> -#endif
>>>   
>>>   extern int nfp_logtype_driver;
>>>   #define PMD_DRV_LOG(level, fmt, args...) \
> 
> 
> 
Hi Andrew,

Apologies for the delay, looks good thanks

Reviewed-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
  2021-07-29 12:18     ` Heinrich Kuhn
@ 2021-08-16 14:04       ` Ferruh Yigit
  0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2021-08-16 14:04 UTC (permalink / raw)
  To: Heinrich Kuhn, Thomas Monjalon; +Cc: dev, Andrew Rybchenko

On 7/29/2021 1:18 PM, Heinrich Kuhn wrote:
> 
> 
> On 2021/07/23 16:14, Thomas Monjalon wrote:
>> Please review.
>>
>> 28/06/2021 13:13, Andrew Rybchenko:
>>> Hi Heinrich,
>>>
>>> could you take a look at the patch?
>>>
>>> Thanks,
>>> Andrew.
>>>
>>> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
>>>> Logging should be converted to dynamic log.
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> ---
>>>>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>>>>   1 file changed, 7 deletions(-)
>>>>
>>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
>>>> index 27dd87611b94..76cc94cb6565 100644
>>>> --- a/drivers/net/nfp/nfp_net_logs.h
>>>> +++ b/drivers/net/nfp/nfp_net_logs.h
>>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>>>>   #define ASSERT(x) do { } while (0)
>>>>   #endif
>>>>   
>>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>>> -
>>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>>> -#define PMD_CPP_LOG(level, fmt, args...) \
>>>> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
>>>> -#else
>>>>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>>> -#endif
>>>>   
>>>>   extern int nfp_logtype_driver;
>>>>   #define PMD_DRV_LOG(level, fmt, args...) \
>>
>>
>>
> Hi Andrew,
> 
> Apologies for the delay, looks good thanks
> 
> Reviewed-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-16 14:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 10:41 [dpdk-dev] [PATCH] net/nfp: remove compile time log Ferruh Yigit
2021-06-28 11:13 ` Andrew Rybchenko
2021-07-23 14:14   ` Thomas Monjalon
2021-07-29 12:18     ` Heinrich Kuhn
2021-08-16 14:04       ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.