From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E144C433F5 for ; Thu, 11 Nov 2021 10:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4702C61104 for ; Thu, 11 Nov 2021 10:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbhKKKC6 (ORCPT ); Thu, 11 Nov 2021 05:02:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:32956 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbhKKKCo (ORCPT ); Thu, 11 Nov 2021 05:02:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636624795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JJZyqwp1ZfPiiIIAKWZ1DfaVeDawYq4abX63m+PU+To=; b=Y7WigNEiQAQVyYxSZdA5SNGcaXkf8DVTcnH0N2mZdbpuhHWq44rWw2VFCVWZ4Q35ggoI1l yBASPRJRmJd7DfGsWuUSisM7xqB5+bITYE3rkvhNcxWxD3pxOfbP9SXmDQ7iZUq/2uoA1D UUUQBd/h/+YSmfB9gHLPk3huNAHxldE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-_zYVDmFWPHC087w3WM5O1A-1; Thu, 11 Nov 2021 04:59:54 -0500 X-MC-Unique: _zYVDmFWPHC087w3WM5O1A-1 Received: by mail-wr1-f70.google.com with SMTP id v18-20020a5d5912000000b001815910d2c0so921862wrd.1 for ; Thu, 11 Nov 2021 01:59:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=JJZyqwp1ZfPiiIIAKWZ1DfaVeDawYq4abX63m+PU+To=; b=DHlNgLSsWZozzG7hPHt4Nkg34EMBYJBp4jBVfEAe2BehqIlx1p/fTEQXynqj/FI4iz DCIyzZ7xMOmEZ0VvbAvK5haQSiSiJVNOdZj3tBKhel51gMeiBNb5eJ6eU4ebjyu+NndC +C0xWtUlVriKDWbDm1Ay4uyrgk9PXsatFGqSCif1GSVs9OFQ1xfR4FOPCl5Vsnw0e8Ci u32hG22lDENCfXnXY24OL+8D3kbTza/gAv7qhR9lv3phR8hiNQdqSpEhlyjFkmyeS1Ql vP+RuHjD9+mMQmZdZ5BKK8HL68Niu4OTw5m/fJrNnJdEHvD6SiBvZw5ehTNEWkNSZ/fB yJVg== X-Gm-Message-State: AOAM531irTDQbDpL5uKFX+tWFQ0yqIfuCutqz26mEFmHNOxZgIoWbAUE BN4mF/7WJ31+H2uOIBtXXBPAdojwRmk45YbKxMCr+21DHaB0j1VbWpBciXX5713TI7dY5UaUOPI GjDfLfl0Welwu81pn9JBZyCvQ X-Received: by 2002:a05:6000:1acd:: with SMTP id i13mr7515133wry.398.1636624792248; Thu, 11 Nov 2021 01:59:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCMFguV57azEtjX0H9g2qbHnrf05evwsn7R3U/X/5WhRj7wS9zZ6r9M/+fj7ufva631F1UwQ== X-Received: by 2002:a05:6000:1acd:: with SMTP id i13mr7515110wry.398.1636624792096; Thu, 11 Nov 2021 01:59:52 -0800 (PST) Received: from [192.168.3.132] (p4ff23ee8.dip0.t-ipconnect.de. [79.242.62.232]) by smtp.gmail.com with ESMTPSA id d6sm2404299wrx.60.2021.11.11.01.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 01:59:51 -0800 (PST) Message-ID: <864f67e1-6250-57ac-511b-60a3590af2c2@redhat.com> Date: Thu, 11 Nov 2021 10:59:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/7] fs/exec: make __get_task_comm always get a nul terminated string Content-Language: en-US To: Yafang Shao , akpm@linux-foundation.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Kees Cook , Steven Rostedt , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Petr Mladek References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-3-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211108083840.4627-3-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.11.21 09:38, Yafang Shao wrote: > If the dest buffer size is smaller than sizeof(tsk->comm), the buffer > will be without null ternimator, that may cause problem. Using > strscpy_pad() instead of strncpy() in __get_task_comm() can make the string > always nul ternimated. > > Suggested-by: Kees Cook > Suggested-by: Steven Rostedt > Signed-off-by: Yafang Shao > Reviewed-by: Kees Cook > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb