From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Zzb-00007b-3P for qemu-devel@nongnu.org; Wed, 25 May 2016 10:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5ZzW-0007dD-3g for qemu-devel@nongnu.org; Wed, 25 May 2016 10:41:02 -0400 References: <1464179363-19821-1-git-send-email-kwolf@redhat.com> <1464179363-19821-2-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <8656156d-5519-70bb-836a-2f2fd91a5865@redhat.com> Date: Wed, 25 May 2016 16:40:40 +0200 MIME-Version: 1.0 In-Reply-To: <1464179363-19821-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mfC54FhgbrDatJTFKb4EQ2AnCX47BFswF" Subject: Re: [Qemu-devel] [PATCH v3 01/15] block: Rename blk_write_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mfC54FhgbrDatJTFKb4EQ2AnCX47BFswF From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com Message-ID: <8656156d-5519-70bb-836a-2f2fd91a5865@redhat.com> Subject: Re: [PATCH v3 01/15] block: Rename blk_write_zeroes() References: <1464179363-19821-1-git-send-email-kwolf@redhat.com> <1464179363-19821-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1464179363-19821-2-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 25.05.2016 14:29, Kevin Wolf wrote: > From: Eric Blake >=20 > Commit 983a1600 changed the semantics of blk_write_zeroes() to > be byte-based rather than sector-based, but did not change the > name, which is an open invitation for other code to misuse the > function. Renaming to pwrite_zeroes() makes it more in line > with other byte-based interfaces, and will help make it easier > to track which remaining write_zeroes interfaces still need > conversion. >=20 > Reported-by: Kevin Wolf > Signed-off-by: Eric Blake > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 14 +++++++------- > block/parallels.c | 4 ++-- > hw/scsi/scsi-disk.c | 2 +- > include/sysemu/block-backend.h | 14 +++++++------- > qemu-img.c | 4 ++-- > qemu-io-cmds.c | 22 +++++++++++----------- > 6 files changed, 30 insertions(+), 30 deletions(-) Reviewed-by: Max Reitz --mfC54FhgbrDatJTFKb4EQ2AnCX47BFswF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRbloAAoJEDuxQgLoOKytbZ4IAJL+6rdL0NFoxw01BS2SIlt+ UhqieYGljxVk8nMxen2XbIwDdqzuYkCMrr9N/gNcTGv9/39BSv+3JLuChZ9dyAsL q3UHjP/tj6LHRZW45i3DvI/OP+z0p48+tb6fRl/G+elE9p2unG7VeVCoNxx3IRdg CRe+loxrkbrIXMDBMfqEiAefEeDIJ3UQRXZO7PSoASb+UyY1qeFSYpwMhi8k/FRV XnweQ0ogBC7WVKrHCHWNJ9XKO343VUq0ipBgn8wINysZug4RZ4zRQtMJtoTszZCZ dTZJMJVD4LnFUuuj5Ih6RBt+qd8bfqUteYdHZnu2tMfJWPoLPFNB69fCwa9gTR4= =zpyH -----END PGP SIGNATURE----- --mfC54FhgbrDatJTFKb4EQ2AnCX47BFswF--