From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7FBC4332F for ; Sun, 8 Sep 2019 11:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 074412081B for ; Sun, 8 Sep 2019 11:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728938AbfIHLyV (ORCPT ); Sun, 8 Sep 2019 07:54:21 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:36544 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728667AbfIHLyU (ORCPT ); Sun, 8 Sep 2019 07:54:20 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8E5BFA0EC41FADBD4B48; Sun, 8 Sep 2019 19:54:18 +0800 (CST) Received: from [10.45.2.172] (10.45.2.172) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Sun, 8 Sep 2019 19:54:14 +0800 Subject: Re: [Virtio-fs] [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 To: Miklos Szeredi , Stefan Hajnoczi CC: "Michael S. Tsirkin" , , , , , Vivek Goyal References: <20190905194859.16219-1-vgoyal@redhat.com> <20190906103613.GH5900@stefanha-x1.localdomain> From: piaojun Message-ID: <866a1469-2c4b-59ce-cf3f-32f65e861b99@huawei.com> Date: Sun, 8 Sep 2019 19:53:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.45.2.172] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/6 19:52, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: >> >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: >>> On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: >>>> >>>> Hi, >>>> >>>> Michael Tsirkin pointed out issues w.r.t various locking related TODO >>>> items and races w.r.t device removal. >>>> >>>> In this first round of cleanups, I have taken care of most pressing >>>> issues. >>>> >>>> These patches apply on top of following. >>>> >>>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 >>>> >>>> I have tested these patches with mount/umount and device removal using >>>> qemu monitor. For example. >>> >>> Is device removal mandatory? Can't this be made a non-removable >>> device? Is there a good reason why removing the virtio-fs device >>> makes sense? >> >> Hot plugging and unplugging virtio PCI adapters is common. I'd very >> much like removal to work from the beginning. > > Can you give an example use case? I think VirtFS migration need hot plugging, or it may cause QEMU crash or some problems. Thanks, Jun From mboxrd@z Thu Jan 1 00:00:00 1970 References: <20190905194859.16219-1-vgoyal@redhat.com> <20190906103613.GH5900@stefanha-x1.localdomain> From: piaojun Message-ID: <866a1469-2c4b-59ce-cf3f-32f65e861b99@huawei.com> Date: Sun, 8 Sep 2019 19:53:55 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Virtio-fs] [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miklos Szeredi , Stefan Hajnoczi Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-fs@redhat.com, linux-fsdevel@vger.kernel.org, Vivek Goyal On 2019/9/6 19:52, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: >> >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: >>> On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: >>>> >>>> Hi, >>>> >>>> Michael Tsirkin pointed out issues w.r.t various locking related TODO >>>> items and races w.r.t device removal. >>>> >>>> In this first round of cleanups, I have taken care of most pressing >>>> issues. >>>> >>>> These patches apply on top of following. >>>> >>>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 >>>> >>>> I have tested these patches with mount/umount and device removal using >>>> qemu monitor. For example. >>> >>> Is device removal mandatory? Can't this be made a non-removable >>> device? Is there a good reason why removing the virtio-fs device >>> makes sense? >> >> Hot plugging and unplugging virtio PCI adapters is common. I'd very >> much like removal to work from the beginning. > > Can you give an example use case? I think VirtFS migration need hot plugging, or it may cause QEMU crash or some problems. Thanks, Jun