From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511A2C71155 for ; Thu, 3 Dec 2020 06:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02D2320709 for ; Thu, 3 Dec 2020 06:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729748AbgLCGrR (ORCPT ); Thu, 3 Dec 2020 01:47:17 -0500 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:28375 "EHLO esa1.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729687AbgLCGrQ (ORCPT ); Thu, 3 Dec 2020 01:47:16 -0500 IronPort-SDR: J5JZ+jl5yejxI/vXpE30ESShZIrKMfHC5dKjvYBkDXjkIy4kb4Bm5104PkDtVHYGrUmsgQYbQA Qs2n2vredJXCp7pzOGfEjUu013mbE5x2//E5Xk3oBxopiQ4lYWstogItFDYPcNZCsxnNvXkz71 B80MOIW8XfBnRkLTE1i0zRiQRB1dANp2rcuxhdsXUMDQY0qmrTcVsni172a5IRJkbzu5MHDgc+ Yk3Rr98WWGtsy6VrTR8krXKhRsR0Nc8DmWifzq+VdcYP8le8jkBEEhgerm7rtkV5gpeXzGTpGB VbA= X-IronPort-AV: E=Sophos;i="5.78,388,1599552000"; d="scan'208";a="58035282" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 02 Dec 2020 22:46:21 -0800 IronPort-SDR: gJMY6Y/MU+UaXt3QljKs5RRVRB7NvxgCIP09XQgQH74ALAsBuRzPslp00xEDEHiAgJSdmPu3x0 DudZT/WjjAXTKiAMZGLzyrUDhytFPmTYpDf5gg45240zJ2zkN4LKAmCVOw5/epkVMsFCJFXcN7 o3NIKio6ASxnrn19ZZcqYwLSIoAozvEmfbvICzJCZiCZPa+8nLg3iHp6AD2m2vFLVSLwDAIHEy cQcoWcd9fj4mDKQ8qxevS9aefXecPsOslNNoBVYWpWeFGxHHAg9WGUg5VPiBMqSCHIsDW/pMY8 WnU= Subject: Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params To: Kuninori Morimoto CC: , References: <1606907286-32104-1-git-send-email-mikhail_durnev@mentor.com> <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com> From: Mikhail Durnev Message-ID: <866c9619-757b-831b-6955-9245a6071adc@mentor.com> Date: Thu, 3 Dec 2020 16:46:13 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.12.2020 08:57, Kuninori Morimoto wrote: > I think you want to add "fallthrough" between case 1/3/4 and case 0 ? Hi Morimoto-san, Yes, I will add it in the updated version of the patch. Thanks. The checkpatch script did not tell me about that. Best regards, Misha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C3EC4361A for ; Sat, 5 Dec 2020 08:07:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37BC822D0B for ; Sat, 5 Dec 2020 08:07:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37BC822D0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C72F418E9; Sat, 5 Dec 2020 09:06:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C72F418E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607155636; bh=VsRX+xGb8tfXxMSIDzsaHw6m6ALj/pSpVp3B7fsiqck=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aA3Ug8FGn57hASv1+uBymHdkywsOM8pKIz1M5N/ywr+kHnCCgp8McJyzTRStYiN6F DydyGX0fE0nWxxxo3c29Ua3N7XddXbCoJLu73RkW8UFYDrA+JGbRfnbI96hRs+CIbu rZ3UjAgj9uQI/OkJrVgjo8Ub3liofPiRSedWC82c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EF0FDF804E6; Sat, 5 Dec 2020 09:03:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9DABFF8016D; Thu, 3 Dec 2020 07:46:37 +0100 (CET) Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 49468F800E8 for ; Thu, 3 Dec 2020 07:46:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 49468F800E8 IronPort-SDR: 5wsRvo4KB5tludE9CiMBsOqzqS8dJZP/Kgxxw7WUGtA1UPcNl0Y4j8a4iLP+0yF0lQPrIsFGCq mnulkaDGdNbeTHdgzQom2mxRUL+qEaOIKO04WFtk999NipYZd5bdP0XAy+e+W+ohxy9EtIy3xD o7TamFR01ui6QgVrDprXh6B7zp6BLOIfCV+OOEbbFLJWXTcjzTe25CzLq9d/dHAq0/ad3jFo4G uncjW7Cm7IC9jUmi2A0q5o3VayLTWskb7wb+SzMYjDqHrWm+aC/oFLpNH56JzyXVTjUP1dK3VH oyI= X-IronPort-AV: E=Sophos;i="5.78,388,1599552000"; d="scan'208";a="55726689" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 02 Dec 2020 22:46:21 -0800 IronPort-SDR: gJMY6Y/MU+UaXt3QljKs5RRVRB7NvxgCIP09XQgQH74ALAsBuRzPslp00xEDEHiAgJSdmPu3x0 DudZT/WjjAXTKiAMZGLzyrUDhytFPmTYpDf5gg45240zJ2zkN4LKAmCVOw5/epkVMsFCJFXcN7 o3NIKio6ASxnrn19ZZcqYwLSIoAozvEmfbvICzJCZiCZPa+8nLg3iHp6AD2m2vFLVSLwDAIHEy cQcoWcd9fj4mDKQ8qxevS9aefXecPsOslNNoBVYWpWeFGxHHAg9WGUg5VPiBMqSCHIsDW/pMY8 WnU= Subject: Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params To: Kuninori Morimoto References: <1606907286-32104-1-git-send-email-mikhail_durnev@mentor.com> <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com> From: Mikhail Durnev Message-ID: <866c9619-757b-831b-6955-9245a6071adc@mentor.com> Date: Thu, 3 Dec 2020 16:46:13 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-Mailman-Approved-At: Sat, 05 Dec 2020 09:03:14 +0100 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 03.12.2020 08:57, Kuninori Morimoto wrote: > I think you want to add "fallthrough" between case 1/3/4 and case 0 ? Hi Morimoto-san, Yes, I will add it in the updated version of the patch. Thanks. The checkpatch script did not tell me about that. Best regards, Misha