From: Grant Likely <grant.likely@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 1/1] efi_loader: put device tree into EfiACPIReclaimMemory
Date: Mon, 11 May 2020 09:48:50 +0100 [thread overview]
Message-ID: <867623da-8b32-fe0d-4149-261e952d93f9@arm.com> (raw)
In-Reply-To: <20200507181937.8923-1-xypron.glpk@gmx.de>
On 07/05/2020 19:19, Heinrich Schuchardt wrote:
> According to the UEFI spec ACPI tables should be placed in
> EfiACPIReclaimMemory. Let's do the same with the device tree.
>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Cc: Grant Likely <grant.likely@arm.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> v2:
> adjust the unit test
Is there any impact to changing the memory type for current users? Does
the kernel currently expect the EFI_BOOT_SERVICES_DATA memory type? What
happens if Grub or another EFI application replaces the DTB table? Will
it try to use a different memory type, and will that matter?
g.
> ---
> cmd/bootefi.c | 4 ++--
> lib/efi_selftest/efi_selftest_memory.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index 54b4b8f984..06573b14e9 100644
> --- a/cmd/bootefi.c
> +++ b/cmd/bootefi.c
> @@ -127,13 +127,13 @@ static efi_status_t copy_fdt(void **fdtp)
> new_fdt_addr = (uintptr_t)map_sysmem(fdt_ram_start + 0x7f00000 +
> fdt_size, 0);
> ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
> - EFI_BOOT_SERVICES_DATA, fdt_pages,
> + EFI_ACPI_RECLAIM_MEMORY, fdt_pages,
> &new_fdt_addr);
> if (ret != EFI_SUCCESS) {
> /* If we can't put it there, put it somewhere */
> new_fdt_addr = (ulong)memalign(EFI_PAGE_SIZE, fdt_size);
> ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
> - EFI_BOOT_SERVICES_DATA, fdt_pages,
> + EFI_ACPI_RECLAIM_MEMORY, fdt_pages,
> &new_fdt_addr);
> if (ret != EFI_SUCCESS) {
> printf("ERROR: Failed to reserve space for FDT\n");
> diff --git a/lib/efi_selftest/efi_selftest_memory.c b/lib/efi_selftest/efi_selftest_memory.c
> index e71732dc6d..4d32a28006 100644
> --- a/lib/efi_selftest/efi_selftest_memory.c
> +++ b/lib/efi_selftest/efi_selftest_memory.c
> @@ -176,9 +176,9 @@ static int execute(void)
> /* Check memory reservation for the device tree */
> if (fdt_addr &&
> find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
> - EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
> + EFI_ACPI_RECLAIM_MEMORY) != EFI_ST_SUCCESS) {
> efi_st_error
> - ("Device tree not marked as boot services data\n");
> + ("Device tree not marked as ACPI reclaim memory\n");
> return EFI_ST_FAILURE;
> }
> return EFI_ST_SUCCESS;
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-11 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:19 [PATCH v2 1/1] efi_loader: put device tree into EfiACPIReclaimMemory Heinrich Schuchardt
2020-05-11 8:48 ` Grant Likely [this message]
2020-05-11 11:55 ` Heinrich Schuchardt
2020-05-12 14:18 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867623da-8b32-fe0d-4149-261e952d93f9@arm.com \
--to=grant.likely@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.