From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbcGAQiM (ORCPT ); Fri, 1 Jul 2016 12:38:12 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38605 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbcGAQiJ (ORCPT ); Fri, 1 Jul 2016 12:38:09 -0400 Subject: Re: [PATCH v1 03/11] KVM: x86: dynamic kvm_apic_map To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <20160630205429.16480-1-rkrcmar@redhat.com> <20160630205429.16480-4-rkrcmar@redhat.com> <20160701124421.GA2301@potion> <20160701143827.GE27840@potion> <46f7b2e0-3225-8a9b-6155-3588b5f60f78@redhat.com> <20160701154354.GA5965@potion> Cc: Andrew Honig , linux-kernel@vger.kernel.org, kvm , "Lan, Tianyu" , Igor Mammedov , Jan Kiszka , Peter Xu From: Paolo Bonzini Message-ID: <8679b129-a414-d973-0d83-d2c67901e274@redhat.com> Date: Fri, 1 Jul 2016 18:38:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160701154354.GA5965@potion> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 17:43, Radim Krčmář wrote: > > Forgot to reply about this: letting SET_LAPIC change x2APIC IDs is nonsense. > > > > In x2APIC mode + new capability disabled SET_LAPIC should ignore the id > > register altogether for backwards compatibility. > > I'd still shift SET_LAPIC APIC ID to have internal APIC ID register in > hardware-compatible format. With the capability disabled, APIC ID should always be in bits 31-24 for both GET and SET. But I think we agree, it's simpler to reason in v2 code and testcases. :) Paolo