From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [RFC PATCH 6/8] mptcp: refactor shutdown and close
Date: Mon, 28 Sep 2020 16:47:46 +0200 [thread overview]
Message-ID: <8685bde51729292e11779df5dce99ce66b497cce.camel@redhat.com> (raw)
In-Reply-To: 6ba1cefb2825480dc5b5c3a29a14b63373e44dc6.1600955407.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
On Thu, 2020-09-24 at 15:59 +0200, Paolo Abeni wrote:
> @@ -417,9 +435,8 @@ static void mptcp_check_data_fin(struct sock *sk)
> inet_sk_state_store(sk, TCP_CLOSING);
> break;
> case TCP_FIN_WAIT2:
> - inet_sk_state_store(sk, TCP_CLOSE);
> - // @@ Close subflows now?
> - break;
> + inet_sk_state_store(sk, TCP_TIME_WAIT);
> + return;
the 'return;' statement slipped-in unintentionally here: this does not
send data_fin ack, if the fin in received in fin_wait2 state.
I have quite a few pending fixes, so I'll send a v1 soon, even if there
are likely more bugs pending.
/P
next reply other threads:[~2020-09-28 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 14:47 Paolo Abeni [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-28 9:39 [MPTCP] Re: [RFC PATCH 6/8] mptcp: refactor shutdown and close Paolo Abeni
2020-09-25 21:34 Mat Martineau
2020-09-25 17:07 Paolo Abeni
2020-09-25 17:02 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8685bde51729292e11779df5dce99ce66b497cce.camel@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.