From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754377AbaIWH5D (ORCPT ); Tue, 23 Sep 2014 03:57:03 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:57925 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbaIWH5A (ORCPT ); Tue, 23 Sep 2014 03:57:00 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Liviu Dudau , Robert Richter , Benjamin Herrenschmidt , linux-pci , Linus Walleij , Will Deacon , Grant Likely , Tanmay Inamdar , linux-arch , Kukjin Kim , Russell King , Jingoo Han , Jason Gunthorpe , Catalin Marinas , "grant.likely@linaro.org" , Device Tree ML , Rob Herring , Bjorn Helgaas , Sinan Kaya , Sunil Goutham , LKML , Suravee Suthikulanit Subject: Re: [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Date: Tue, 23 Sep 2014 09:56:37 +0200 Message-ID: <8687285.EH4RPBeOB5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140922114317.GN1994@e106497-lin.cambridge.arm.com> References: <1411003825-21521-1-git-send-email-Liviu.Dudau@arm.com> <20140922093228.GA20256@rric.localhost> <20140922114317.GN1994@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:g55Ct4lgQO0B3TAuKTq78jWR6lCyIXKh4W/YzjeKzje 2Jkp5HfuycJ7XRUmqDdeR1wVQErg+UItUAuFzfz1PHqfN8w30c +1OyzJbykASHO9w3qgQUcR7Th1ge1sUSYjVjekQQ+KxW1bg8t5 KRzmRvDwY4PkbQ5RqIhL95eH9sWLFz/jM6hpL14Z9RL1NZSvPZ 7z+h02ZDL/agvKeKYQs2OJQ2dTb19q30NddAKvoeXjx5mnaUjB H21acfUQFT4CiNvJF6SB/97iIdHKbRtDdPOXDJIqbB67Ir4p7B uFeI1ALJ68Wk+ib7ZdGNaxX+tQBP6WN0/ZTMYgwUEYayeUjR9Q hq6Ec7VBRh0JX4gNghJA= X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 22 September 2014 12:43:17 Liviu Dudau wrote: > > > > From e798af4fc2f664d1aff7e863489b8298f90e716e Mon Sep 17 00:00:00 2001 > > From: Robert Richter > > Date: Mon, 22 Sep 2014 10:46:01 +0200 > > Subject: [PATCH] OF: PCI: Fix creation of mem-mapped pci host bridges > > > > The pci host bridge was not created if io_base was not set when > > calling of_pci_get_host_bridge_resources(). This is esp. the case for > > mem-mapped io (IORESOURCE_MEM). This patch fixes this. Function > > parameter io_base is optional now. > > I think the message is misleading. What you want to do is make io_base > optional for the case where the PCI host bridge only expects to have only > IORESOURCE_MEM ranges and doesn't care about IORESOURCE_IO ones. > > As I'm going to touch this area again to address a comment from Bjorn, > do you mind if I roll this patch into mine with your Signed-off-by and > the mention that you have made io_base optional? I think the best way to deal with this is to move the check for io_base down into the place where it is used: As long as the DT only specifies IORESOURCE_MEM windows, we don't need to look at io_base, but if the host controller driver does not support IORESOURCE_IO while the DT specifies it, I guess it would be nice to return an error. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Date: Tue, 23 Sep 2014 09:56:37 +0200 Message-ID: <8687285.EH4RPBeOB5@wuerfel> References: <1411003825-21521-1-git-send-email-Liviu.Dudau@arm.com> <20140922093228.GA20256@rric.localhost> <20140922114317.GN1994@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20140922114317.GN1994@e106497-lin.cambridge.arm.com> Sender: linux-pci-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Liviu Dudau , Robert Richter , Benjamin Herrenschmidt , linux-pci , Linus Walleij , Will Deacon , Grant Likely , Tanmay Inamdar , linux-arch , Kukjin Kim , Russell King , Jingoo Han , Jason Gunthorpe , Catalin Marinas , "grant.likely@linaro.org" , Device Tree ML , Rob Herring , Bjorn Helgaas , Sinan Kaya , Sunil Goutham , LKML , Suravee Suthikulanit List-Id: devicetree@vger.kernel.org On Monday 22 September 2014 12:43:17 Liviu Dudau wrote: > > > > From e798af4fc2f664d1aff7e863489b8298f90e716e Mon Sep 17 00:00:00 2001 > > From: Robert Richter > > Date: Mon, 22 Sep 2014 10:46:01 +0200 > > Subject: [PATCH] OF: PCI: Fix creation of mem-mapped pci host bridges > > > > The pci host bridge was not created if io_base was not set when > > calling of_pci_get_host_bridge_resources(). This is esp. the case for > > mem-mapped io (IORESOURCE_MEM). This patch fixes this. Function > > parameter io_base is optional now. > > I think the message is misleading. What you want to do is make io_base > optional for the case where the PCI host bridge only expects to have only > IORESOURCE_MEM ranges and doesn't care about IORESOURCE_IO ones. > > As I'm going to touch this area again to address a comment from Bjorn, > do you mind if I roll this patch into mine with your Signed-off-by and > the mention that you have made io_base optional? I think the best way to deal with this is to move the check for io_base down into the place where it is used: As long as the DT only specifies IORESOURCE_MEM windows, we don't need to look at io_base, but if the host controller driver does not support IORESOURCE_IO while the DT specifies it, I guess it would be nice to return an error. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 23 Sep 2014 09:56:37 +0200 Subject: [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT In-Reply-To: <20140922114317.GN1994@e106497-lin.cambridge.arm.com> References: <1411003825-21521-1-git-send-email-Liviu.Dudau@arm.com> <20140922093228.GA20256@rric.localhost> <20140922114317.GN1994@e106497-lin.cambridge.arm.com> Message-ID: <8687285.EH4RPBeOB5@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 22 September 2014 12:43:17 Liviu Dudau wrote: > > > > From e798af4fc2f664d1aff7e863489b8298f90e716e Mon Sep 17 00:00:00 2001 > > From: Robert Richter > > Date: Mon, 22 Sep 2014 10:46:01 +0200 > > Subject: [PATCH] OF: PCI: Fix creation of mem-mapped pci host bridges > > > > The pci host bridge was not created if io_base was not set when > > calling of_pci_get_host_bridge_resources(). This is esp. the case for > > mem-mapped io (IORESOURCE_MEM). This patch fixes this. Function > > parameter io_base is optional now. > > I think the message is misleading. What you want to do is make io_base > optional for the case where the PCI host bridge only expects to have only > IORESOURCE_MEM ranges and doesn't care about IORESOURCE_IO ones. > > As I'm going to touch this area again to address a comment from Bjorn, > do you mind if I roll this patch into mine with your Signed-off-by and > the mention that you have made io_base optional? I think the best way to deal with this is to move the check for io_base down into the place where it is used: As long as the DT only specifies IORESOURCE_MEM windows, we don't need to look at io_base, but if the host controller driver does not support IORESOURCE_IO while the DT specifies it, I guess it would be nice to return an error. Arnd